You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/08/16 02:25:43 UTC
[GitHub] [trafficserver] bneradt opened a new pull request #7119: URL::parse fixes for empty paths
bneradt opened a new pull request #7119:
URL: https://github.com/apache/trafficserver/pull/7119
URL::parse could not handle URLs with empty paths, such as the
following:
http://www.example.com?name=something
Note the lack of '/' after the hostname.
This updates the parsing and printing logic to be able to handle this
while being careful not to break current parse expectations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7119: URL::parse fixes for empty paths
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7119:
URL: https://github.com/apache/trafficserver/pull/7119#issuecomment-675077350
[approve ci docs]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #7119: URL::parse fixes for empty paths
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on pull request #7119:
URL: https://github.com/apache/trafficserver/pull/7119#issuecomment-680258809
I spent quite a bit of time reviewing and pondering, and I think this is the best option at this point in time. Doing better would require far more substantial changes, as @bneradt notes in some of the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #7119: URL::parse fixes for empty paths
Posted by GitBox <gi...@apache.org>.
bneradt merged pull request #7119:
URL: https://github.com/apache/trafficserver/pull/7119
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7119: URL::parse fixes for empty paths
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7119:
URL: https://github.com/apache/trafficserver/pull/7119#issuecomment-684924850
With input from Leif and Bryan, I'm setting the 9.0.x milestone for this. It has a bug fix in our URI path parsing logic that could be helpful in the 9.0.x release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7119: URL::parse fixes for empty paths
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7119:
URL: https://github.com/apache/trafficserver/pull/7119#issuecomment-686656734
Cherry-picked to v9.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org