You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/06/07 13:41:40 UTC
[GitHub] [lucene] dweiss opened a new pull request #175: LUCENE-9990: gradle7 support
dweiss opened a new pull request #175:
URL: https://github.com/apache/lucene/pull/175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a change in pull request #175: LUCENE-9990: gradle7 support
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r651498995
##########
File path: gradle/testing/alternative-jdk-support.gradle
##########
@@ -18,60 +18,60 @@
// This adds support for compiling and testing against a different Java runtime.
// This is the only way to build against JVMs not yet supported by Gradle itself.
-JavaInstallationRegistry registry = extensions.getByType(JavaInstallationRegistry)
-
-JavaInstallation currentJvm = registry.installationForCurrentVirtualMachine.get()
-
-JavaInstallation altJvm = {
- def runtimeJavaHome = propertyOrDefault("runtime.java.home", System.getenv('RUNTIME_JAVA_HOME'))
- if (!runtimeJavaHome) {
- return currentJvm
- } else {
- return registry.installationForDirectory(
- layout.projectDirectory.dir(runtimeJavaHome)).get()
- }
-}()
-
-// Set up root project's property.
-rootProject.ext.runtimeJava = altJvm
-rootProject.ext.runtimeJavaVersion = altJvm.javaVersion
-
-if (!currentJvm.javaExecutable.equals(altJvm.javaExecutable)) {
- // Set up java toolchain tasks to use the alternative Java.
- // This is a related Gradle issue for the future:
- // https://github.com/gradle/gradle/issues/1652
-
- configure(rootProject) {
- task altJvmWarning() {
- doFirst {
- logger.warn("""NOTE: Alternative java toolchain will be used for compilation and tests:
- Project will use Java ${altJvm.javaVersion} from: ${altJvm.installationDirectory}
- Gradle runs with Java ${currentJvm.javaVersion} from: ${currentJvm.installationDirectory}
-""")
- }
- }
- }
-
- // Set up toolchain-dependent tasks to use the alternative JVM.
- allprojects {
- // Any tests
- tasks.withType(Test) {
- dependsOn ":altJvmWarning"
- executable = altJvm.javaExecutable
- }
-
- // Any javac compilation tasks
- tasks.withType(JavaCompile) {
- dependsOn ":altJvmWarning"
- options.fork = true
- options.forkOptions.javaHome = altJvm.installationDirectory.asFile
- }
-
- // Javadoc compilation.
- def javadocExecutable = altJvm.jdk.get().javadocExecutable.asFile
- tasks.matching { it.name == "renderJavadoc" || it.name == "renderSiteJavadoc" }.all {
- dependsOn ":altJvmWarning"
- executable = javadocExecutable
- }
- }
-}
+//JavaInstallationRegistry registry = extensions.getByType(JavaInstallationRegistry)
Review comment:
No worries at all. I think Palantir's plugin is the showstopper here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gautamworah96 commented on a change in pull request #175: LUCENE-9990: gradle7 support
Posted by GitBox <gi...@apache.org>.
gautamworah96 commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r647053364
##########
File path: gradle/testing/alternative-jdk-support.gradle
##########
@@ -18,60 +18,60 @@
// This adds support for compiling and testing against a different Java runtime.
// This is the only way to build against JVMs not yet supported by Gradle itself.
-JavaInstallationRegistry registry = extensions.getByType(JavaInstallationRegistry)
-
-JavaInstallation currentJvm = registry.installationForCurrentVirtualMachine.get()
-
-JavaInstallation altJvm = {
- def runtimeJavaHome = propertyOrDefault("runtime.java.home", System.getenv('RUNTIME_JAVA_HOME'))
- if (!runtimeJavaHome) {
- return currentJvm
- } else {
- return registry.installationForDirectory(
- layout.projectDirectory.dir(runtimeJavaHome)).get()
- }
-}()
-
-// Set up root project's property.
-rootProject.ext.runtimeJava = altJvm
-rootProject.ext.runtimeJavaVersion = altJvm.javaVersion
-
-if (!currentJvm.javaExecutable.equals(altJvm.javaExecutable)) {
- // Set up java toolchain tasks to use the alternative Java.
- // This is a related Gradle issue for the future:
- // https://github.com/gradle/gradle/issues/1652
-
- configure(rootProject) {
- task altJvmWarning() {
- doFirst {
- logger.warn("""NOTE: Alternative java toolchain will be used for compilation and tests:
- Project will use Java ${altJvm.javaVersion} from: ${altJvm.installationDirectory}
- Gradle runs with Java ${currentJvm.javaVersion} from: ${currentJvm.installationDirectory}
-""")
- }
- }
- }
-
- // Set up toolchain-dependent tasks to use the alternative JVM.
- allprojects {
- // Any tests
- tasks.withType(Test) {
- dependsOn ":altJvmWarning"
- executable = altJvm.javaExecutable
- }
-
- // Any javac compilation tasks
- tasks.withType(JavaCompile) {
- dependsOn ":altJvmWarning"
- options.fork = true
- options.forkOptions.javaHome = altJvm.installationDirectory.asFile
- }
-
- // Javadoc compilation.
- def javadocExecutable = altJvm.jdk.get().javadocExecutable.asFile
- tasks.matching { it.name == "renderJavadoc" || it.name == "renderSiteJavadoc" }.all {
- dependsOn ":altJvmWarning"
- executable = javadocExecutable
- }
- }
-}
+//JavaInstallationRegistry registry = extensions.getByType(JavaInstallationRegistry)
Review comment:
Sure.
Gradle 7 has something similar to what we have already setup today i.e., using an env variable to send in the location of the JVM. I can get it running and then add instructions in lucene/help/jvms.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a change in pull request #175: LUCENE-9990: gradle7 support
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r647179032
##########
File path: gradle/testing/alternative-jdk-support.gradle
##########
@@ -18,60 +18,60 @@
// This adds support for compiling and testing against a different Java runtime.
// This is the only way to build against JVMs not yet supported by Gradle itself.
-JavaInstallationRegistry registry = extensions.getByType(JavaInstallationRegistry)
-
-JavaInstallation currentJvm = registry.installationForCurrentVirtualMachine.get()
-
-JavaInstallation altJvm = {
- def runtimeJavaHome = propertyOrDefault("runtime.java.home", System.getenv('RUNTIME_JAVA_HOME'))
- if (!runtimeJavaHome) {
- return currentJvm
- } else {
- return registry.installationForDirectory(
- layout.projectDirectory.dir(runtimeJavaHome)).get()
- }
-}()
-
-// Set up root project's property.
-rootProject.ext.runtimeJava = altJvm
-rootProject.ext.runtimeJavaVersion = altJvm.javaVersion
-
-if (!currentJvm.javaExecutable.equals(altJvm.javaExecutable)) {
- // Set up java toolchain tasks to use the alternative Java.
- // This is a related Gradle issue for the future:
- // https://github.com/gradle/gradle/issues/1652
-
- configure(rootProject) {
- task altJvmWarning() {
- doFirst {
- logger.warn("""NOTE: Alternative java toolchain will be used for compilation and tests:
- Project will use Java ${altJvm.javaVersion} from: ${altJvm.installationDirectory}
- Gradle runs with Java ${currentJvm.javaVersion} from: ${currentJvm.installationDirectory}
-""")
- }
- }
- }
-
- // Set up toolchain-dependent tasks to use the alternative JVM.
- allprojects {
- // Any tests
- tasks.withType(Test) {
- dependsOn ":altJvmWarning"
- executable = altJvm.javaExecutable
- }
-
- // Any javac compilation tasks
- tasks.withType(JavaCompile) {
- dependsOn ":altJvmWarning"
- options.fork = true
- options.forkOptions.javaHome = altJvm.installationDirectory.asFile
- }
-
- // Javadoc compilation.
- def javadocExecutable = altJvm.jdk.get().javadocExecutable.asFile
- tasks.matching { it.name == "renderJavadoc" || it.name == "renderSiteJavadoc" }.all {
- dependsOn ":altJvmWarning"
- executable = javadocExecutable
- }
- }
-}
+//JavaInstallationRegistry registry = extensions.getByType(JavaInstallationRegistry)
Review comment:
Just to be clear: I don't know how it works exactly but what we want is not one jvm to run gradle *and* lucene - we want the ability to separate these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gautamworah96 commented on a change in pull request #175: LUCENE-9990: gradle7 support
Posted by GitBox <gi...@apache.org>.
gautamworah96 commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r647053364
##########
File path: gradle/testing/alternative-jdk-support.gradle
##########
@@ -18,60 +18,60 @@
// This adds support for compiling and testing against a different Java runtime.
// This is the only way to build against JVMs not yet supported by Gradle itself.
-JavaInstallationRegistry registry = extensions.getByType(JavaInstallationRegistry)
-
-JavaInstallation currentJvm = registry.installationForCurrentVirtualMachine.get()
-
-JavaInstallation altJvm = {
- def runtimeJavaHome = propertyOrDefault("runtime.java.home", System.getenv('RUNTIME_JAVA_HOME'))
- if (!runtimeJavaHome) {
- return currentJvm
- } else {
- return registry.installationForDirectory(
- layout.projectDirectory.dir(runtimeJavaHome)).get()
- }
-}()
-
-// Set up root project's property.
-rootProject.ext.runtimeJava = altJvm
-rootProject.ext.runtimeJavaVersion = altJvm.javaVersion
-
-if (!currentJvm.javaExecutable.equals(altJvm.javaExecutable)) {
- // Set up java toolchain tasks to use the alternative Java.
- // This is a related Gradle issue for the future:
- // https://github.com/gradle/gradle/issues/1652
-
- configure(rootProject) {
- task altJvmWarning() {
- doFirst {
- logger.warn("""NOTE: Alternative java toolchain will be used for compilation and tests:
- Project will use Java ${altJvm.javaVersion} from: ${altJvm.installationDirectory}
- Gradle runs with Java ${currentJvm.javaVersion} from: ${currentJvm.installationDirectory}
-""")
- }
- }
- }
-
- // Set up toolchain-dependent tasks to use the alternative JVM.
- allprojects {
- // Any tests
- tasks.withType(Test) {
- dependsOn ":altJvmWarning"
- executable = altJvm.javaExecutable
- }
-
- // Any javac compilation tasks
- tasks.withType(JavaCompile) {
- dependsOn ":altJvmWarning"
- options.fork = true
- options.forkOptions.javaHome = altJvm.installationDirectory.asFile
- }
-
- // Javadoc compilation.
- def javadocExecutable = altJvm.jdk.get().javadocExecutable.asFile
- tasks.matching { it.name == "renderJavadoc" || it.name == "renderSiteJavadoc" }.all {
- dependsOn ":altJvmWarning"
- executable = javadocExecutable
- }
- }
-}
+//JavaInstallationRegistry registry = extensions.getByType(JavaInstallationRegistry)
Review comment:
Sure.
Gradle 7 has something similar to what we have already setup today i.e., using an env variable to send in the location of the JVM. I can get it running and then add instructions in lucene/help/jvms.txt, cleanup the comments in this file as well!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gautamworah96 commented on a change in pull request #175: LUCENE-9990: gradle7 support
Posted by GitBox <gi...@apache.org>.
gautamworah96 commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r647040460
##########
File path: gradle/java/javac.gradle
##########
@@ -16,6 +16,15 @@
*/
// Configure Java project defaults.
+java {
+ toolchain {
+ languageVersion = JavaLanguageVersion.of(11)
+ }
+}
+
+tasks.withType( JavaCompile ).configureEach {
Review comment:
Thanks for adding and reviewing the patch!
Sure. gradle/hacks makes sense. I'll also follow up on the ticket to see if there is a better way to solve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on a change in pull request #175: LUCENE-9990: gradle7 support
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r646602463
##########
File path: gradle/wrapper/gradle-wrapper.jar.version
##########
@@ -1 +1 @@
-6.8.3
+7.0.2
Review comment:
You'll also need to update the hash of the wrapper?
##########
File path: gradle/testing/alternative-jdk-support.gradle
##########
@@ -18,60 +18,60 @@
// This adds support for compiling and testing against a different Java runtime.
// This is the only way to build against JVMs not yet supported by Gradle itself.
-JavaInstallationRegistry registry = extensions.getByType(JavaInstallationRegistry)
-
-JavaInstallation currentJvm = registry.installationForCurrentVirtualMachine.get()
-
-JavaInstallation altJvm = {
- def runtimeJavaHome = propertyOrDefault("runtime.java.home", System.getenv('RUNTIME_JAVA_HOME'))
- if (!runtimeJavaHome) {
- return currentJvm
- } else {
- return registry.installationForDirectory(
- layout.projectDirectory.dir(runtimeJavaHome)).get()
- }
-}()
-
-// Set up root project's property.
-rootProject.ext.runtimeJava = altJvm
-rootProject.ext.runtimeJavaVersion = altJvm.javaVersion
-
-if (!currentJvm.javaExecutable.equals(altJvm.javaExecutable)) {
- // Set up java toolchain tasks to use the alternative Java.
- // This is a related Gradle issue for the future:
- // https://github.com/gradle/gradle/issues/1652
-
- configure(rootProject) {
- task altJvmWarning() {
- doFirst {
- logger.warn("""NOTE: Alternative java toolchain will be used for compilation and tests:
- Project will use Java ${altJvm.javaVersion} from: ${altJvm.installationDirectory}
- Gradle runs with Java ${currentJvm.javaVersion} from: ${currentJvm.installationDirectory}
-""")
- }
- }
- }
-
- // Set up toolchain-dependent tasks to use the alternative JVM.
- allprojects {
- // Any tests
- tasks.withType(Test) {
- dependsOn ":altJvmWarning"
- executable = altJvm.javaExecutable
- }
-
- // Any javac compilation tasks
- tasks.withType(JavaCompile) {
- dependsOn ":altJvmWarning"
- options.fork = true
- options.forkOptions.javaHome = altJvm.installationDirectory.asFile
- }
-
- // Javadoc compilation.
- def javadocExecutable = altJvm.jdk.get().javadocExecutable.asFile
- tasks.matching { it.name == "renderJavadoc" || it.name == "renderSiteJavadoc" }.all {
- dependsOn ":altJvmWarning"
- executable = javadocExecutable
- }
- }
-}
+//JavaInstallationRegistry registry = extensions.getByType(JavaInstallationRegistry)
Review comment:
I understand it's a PoC but a plan is needed how to enable what worked previously - pointing at an arbitrary JVM home and have it be the default for compilation, tests, etc. In the current form the patch removes things that are currently used to separate the gradle vs. lucene JVM toolchains - we do need this separation (for example to rule out early access JVM problems stemming from gradle itself vs. lucene).
##########
File path: gradle/java/javac.gradle
##########
@@ -16,6 +16,15 @@
*/
// Configure Java project defaults.
+java {
+ toolchain {
+ languageVersion = JavaLanguageVersion.of(11)
+ }
+}
+
+tasks.withType( JavaCompile ).configureEach {
Review comment:
Add the issue reference you mentioned here. The entire workaround thing should be best moved under a separate file in gradle/hacks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss closed pull request #175: LUCENE-9990: gradle7 support
Posted by GitBox <gi...@apache.org>.
dweiss closed pull request #175:
URL: https://github.com/apache/lucene/pull/175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gautamworah96 commented on a change in pull request #175: LUCENE-9990: gradle7 support
Posted by GitBox <gi...@apache.org>.
gautamworah96 commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r651422401
##########
File path: gradle/testing/alternative-jdk-support.gradle
##########
@@ -18,60 +18,60 @@
// This adds support for compiling and testing against a different Java runtime.
// This is the only way to build against JVMs not yet supported by Gradle itself.
-JavaInstallationRegistry registry = extensions.getByType(JavaInstallationRegistry)
-
-JavaInstallation currentJvm = registry.installationForCurrentVirtualMachine.get()
-
-JavaInstallation altJvm = {
- def runtimeJavaHome = propertyOrDefault("runtime.java.home", System.getenv('RUNTIME_JAVA_HOME'))
- if (!runtimeJavaHome) {
- return currentJvm
- } else {
- return registry.installationForDirectory(
- layout.projectDirectory.dir(runtimeJavaHome)).get()
- }
-}()
-
-// Set up root project's property.
-rootProject.ext.runtimeJava = altJvm
-rootProject.ext.runtimeJavaVersion = altJvm.javaVersion
-
-if (!currentJvm.javaExecutable.equals(altJvm.javaExecutable)) {
- // Set up java toolchain tasks to use the alternative Java.
- // This is a related Gradle issue for the future:
- // https://github.com/gradle/gradle/issues/1652
-
- configure(rootProject) {
- task altJvmWarning() {
- doFirst {
- logger.warn("""NOTE: Alternative java toolchain will be used for compilation and tests:
- Project will use Java ${altJvm.javaVersion} from: ${altJvm.installationDirectory}
- Gradle runs with Java ${currentJvm.javaVersion} from: ${currentJvm.installationDirectory}
-""")
- }
- }
- }
-
- // Set up toolchain-dependent tasks to use the alternative JVM.
- allprojects {
- // Any tests
- tasks.withType(Test) {
- dependsOn ":altJvmWarning"
- executable = altJvm.javaExecutable
- }
-
- // Any javac compilation tasks
- tasks.withType(JavaCompile) {
- dependsOn ":altJvmWarning"
- options.fork = true
- options.forkOptions.javaHome = altJvm.installationDirectory.asFile
- }
-
- // Javadoc compilation.
- def javadocExecutable = altJvm.jdk.get().javadocExecutable.asFile
- tasks.matching { it.name == "renderJavadoc" || it.name == "renderSiteJavadoc" }.all {
- dependsOn ":altJvmWarning"
- executable = javadocExecutable
- }
- }
-}
+//JavaInstallationRegistry registry = extensions.getByType(JavaInstallationRegistry)
Review comment:
Understood :) The gradle website says this (under improvements in Gradle 7):
`Additionally, you may want to build a project using a Java version that is not supported for running Gradle.`
so I am optimistic that we should be able to run Gradle and Lucene on different Java versions.
Sorry for the delay in the response! I will try my best to find some time soon and get this running
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gautamworah96 commented on pull request #175: LUCENE-9990: gradle7 support
Posted by GitBox <gi...@apache.org>.
gautamworah96 commented on pull request #175:
URL: https://github.com/apache/lucene/pull/175#issuecomment-888545634
I gave this PR another shot (since the Palantir plugin has been patched in v2.0.0 for Gradle 7 support), but had some new issues come up. The good news, I *think* that using the `-Porg.gradle.java.installations.paths` command line param points Gradle to use that specific JDK for building and running the project. The bad news, since `JavaInstallationRegistry` is now deprecated, the build fails in multiple places (some that use the Java version to add specific JVM params, and others where we use the plugin to get the Java command to generate some javadoc). As of right now, I am just trial-and-erroring some code to see what works.
Some WIP code is pushed [here](https://github.com/gautamworah96/lucene/pull/new/LUCENE-9990).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gautamworah96 commented on a change in pull request #175: LUCENE-9990: gradle7 support
Posted by GitBox <gi...@apache.org>.
gautamworah96 commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r647040440
##########
File path: gradle/wrapper/gradle-wrapper.jar.version
##########
@@ -1 +1 @@
-6.8.3
+7.0.2
Review comment:
I checked https://services.gradle.org/distributions/ and the SHA256 of the gradle-7.0.2-wrapper.jar.sha256 has remained the same. It was the same for the 6.6.1 to 6.8.3 transition as well
##########
File path: gradle/java/javac.gradle
##########
@@ -16,6 +16,15 @@
*/
// Configure Java project defaults.
+java {
+ toolchain {
+ languageVersion = JavaLanguageVersion.of(11)
+ }
+}
+
+tasks.withType( JavaCompile ).configureEach {
Review comment:
Sure. gradle/hacks makes sense. I'll also follow up on the ticket to see if there is a better way to solve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org