Re: [PR] video/vnc: add vnc_fb_register [nuttx]

["pkarashchenko (via GitHub)" <gi...@apache.org>]

pkarashchenko commented on code in PR #11383:
URL: https://github.com/apache/nuttx/pull/11383#discussion_r1550507164


##########
graphics/nxmu/nxmu_start.c:
##########
@@ -108,6 +112,22 @@ static int nx_server(int argc, char *argv[])
   dev->setpower(dev, ((3 * CONFIG_LCD_MAXPOWER + 3) / 4));
 
 #else /* CONFIG_NX_LCDDRIVER */
+# ifdef CONFIG_VNCSERVER
+  /* Initialize the VNC server */
+    int display;

Review Comment:
   ```suggestion
     int display;
   ```



##########
boards/sim/sim/sim/src/sim_bringup.c:
##########
@@ -61,6 +61,10 @@
 #include <nuttx/lcd/lcd_dev.h>
 #endif
 
+#ifdef CONFIG_VNCSERVER
+#include <nuttx/video/vnc.h>
+#endif
+
 #if defined(CONFIG_INPUT_BUTTONS_LOWER) && defined(CONFIG_SIM_BUTTONS)
 #include <nuttx/input/buttons.h>

Review Comment:
   ```suggestion
   #  include <nuttx/input/buttons.h>
   ```



##########
boards/sim/sim/sim/src/sim_bringup.c:
##########
@@ -61,6 +61,10 @@
 #include <nuttx/lcd/lcd_dev.h>
 #endif
 
+#ifdef CONFIG_VNCSERVER
+#include <nuttx/video/vnc.h>

Review Comment:
   I would say 2 spaces



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org