You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/06 10:32:58 UTC
[GitHub] [kafka] APaMio opened a new pull request #9704: Minor:Using primitive data types for loop index
APaMio opened a new pull request #9704:
URL: https://github.com/apache/kafka/pull/9704
Change the loop index from Object into primitive data type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9704: Minor:Using primitive data types for loop index
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9704:
URL: https://github.com/apache/kafka/pull/9704#issuecomment-739508831
@APaMio Please don't include committed code in your PR. That may confuse reviewers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] APaMio closed pull request #9704: Minor:Using primitive data types for loop index
Posted by GitBox <gi...@apache.org>.
APaMio closed pull request #9704:
URL: https://github.com/apache/kafka/pull/9704
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9704: Minor:Using primitive data types for loop index
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9704:
URL: https://github.com/apache/kafka/pull/9704#issuecomment-739504767
@APaMio Thanks for your patch.
```
18:40:55 > Task :connect:runtime:compileJava FAILED
18:40:55 /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-9704/connect/runtime/src/main/java/org/apache/kafka/connect/tools/VerifiableSinkConnector.java:55: error: ')' expected
18:40:55 props.put(VerifiableSinkTask.ID_CONFIG, String.valueof(i);
18:40:55 ^
18:40:55 1 error
18:40:55
```
Could you check the error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org