[jira] [Resolved] (IMPALA-5104) admission control memory check shouldn't fail queries with estimates equal to MEM_LIMIT

["Matthew Jacobs (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-5104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew Jacobs resolved IMPALA-5104.
------------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 2.10.0

67bc7a774c778c59cdaf7be39ceb5620f75e4f34

> admission control memory check shouldn't fail queries with estimates equal to MEM_LIMIT
> ---------------------------------------------------------------------------------------
>
>                 Key: IMPALA-5104
>                 URL: https://issues.apache.org/jira/browse/IMPALA-5104
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 2.8.0
>            Reporter: Matthew Mulder
>            Assignee: Bikramjeet Vig
>            Priority: Minor
>              Labels: admission-control, newbie
>             Fix For: Impala 2.10.0
>
>
> I got the error{code}MainThread DEBUG:concurrent_select[853]:Error running query with id b647161dd5c826da:8f641d6100000000: Rejected query from pool root.default : request memory needed 256.00 GB per node is greater than process mem limit 256.00 GB.{code}which didn't make sense to me until I looked in the code and saw that the operation used was actually{code}schedule->GetPerHostMemoryEstimate() >= GetProcMemLimit(){code}It is a use case, at least during testing, to run a query through EXPLAIN to get the memory usage and then set MEM_LIMIT to the resulting estimate. To make this use case work, the above comparison should be changed to{code}schedule->GetPerHostMemoryEstimate() > GetProcMemLimit(){code}to avoid rejecting the query. The code is in admission-controller.cc



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)