[jira] [Commented] (CB-8236) INTERNET permission should not be removed when uninstalling a plugin that added it, since it's a default permission set by cordova-android.

["Andrew Grieve (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-8236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262953#comment-14262953 ] 

Andrew Grieve commented on CB-8236:
-----------------------------------

Ideas to fix:
1. Add support for platform-default plugins, then add the default perms to this plugin so that they get captured in config munch
2. First time a config-file is encountered, add all of its top-level nodes to the config munge
3. First time a config-file is encountered, make a backup of it under platform_www/. Upon each prepare, copy in the original version and re-apply munge. Delete all uninstall logic since uninstall is just same as install now (post config-munge updating). This has downside of it making files harder to modify by users, since now they need to modify in platform_www/, which doesn't make sense.
4. Wait for gradle to become default build system, then modify all plugins to use android libraries & Manifest Merger logic instead of config-file tags.

Only #1 and #4 make sense to me... Going to punt for now.

> INTERNET permission should not be removed when uninstalling a plugin that added it, since it's a default permission set by cordova-android.
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-8236
>                 URL: https://issues.apache.org/jira/browse/CB-8236
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>
> Create a plugin that includes:
> {code}
> <config-file target="AndroidManifest.xml" parent="/manifest">
>   <uses-permission android:name="android.permission.INTERNET" />
> </config-file>
> {code}
> Add it to a project, then remove it. Notice that the uses-permission tag is now gone when it shouldn't be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org