You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/20 14:32:49 UTC
[GitHub] [airflow] dimonchik-suvorov opened a new pull request #8475: [AIRFLOW-8474]: Adding possibility to get job_id from Databricks run
dimonchik-suvorov opened a new pull request #8475:
URL: https://github.com/apache/airflow/pull/8475
Basically adding function to get job_id from `api/2.0/jobs/runs/get` Databricks API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zhongjiajie commented on a change in pull request #8475: [AIRFLOW-8474]: Adding possibility to get job_id from Databricks run
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #8475:
URL: https://github.com/apache/airflow/pull/8475#discussion_r412836134
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -236,6 +236,18 @@ def get_run_page_url(self, run_id: str) -> str:
response = self._do_api_call(GET_RUN_ENDPOINT, json)
return response['run_page_url']
+ def get_job_id_from_run(self, run_id: str) -> str:
Review comment:
```suggestion
def get_job_id(self, run_id: str) -> str:
```
Maybe better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zhongjiajie commented on pull request #8475: [AIRFLOW-8474]: Adding possibility to get job_id from Databricks run
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #8475:
URL: https://github.com/apache/airflow/pull/8475#issuecomment-618833638
LGTM, thanks @dimonchik-suvorov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zhongjiajie commented on issue #8475: [AIRFLOW-8474]: Adding possibility to get job_id from Databricks run
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #8475:
URL: https://github.com/apache/airflow/pull/8475#issuecomment-617671782
Related Issue https://github.com/apache/airflow/issues/8474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zhongjiajie commented on issue #8475: [AIRFLOW-8474]: Adding possibility to get job_id from Databricks run
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #8475:
URL: https://github.com/apache/airflow/pull/8475#issuecomment-617675482
Others LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zhongjiajie commented on issue #8475: [AIRFLOW-8474]: Adding possibility to get job_id from Databricks run
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #8475:
URL: https://github.com/apache/airflow/pull/8475#issuecomment-617675187
BTW, CI failed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #8475: [AIRFLOW-8474]: Adding possibility to get job_id from Databricks run
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #8475:
URL: https://github.com/apache/airflow/pull/8475#issuecomment-618833816
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zhongjiajie commented on issue #8475: [AIRFLOW-8474]: Adding possibility to get job_id from Databricks run
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #8475:
URL: https://github.com/apache/airflow/pull/8475#issuecomment-618179345
CI still failed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org