You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/11 17:37:18 UTC

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #2202: Make ParquetExec usable outside of a tokio runtime (#2201)

tustvold commented on code in PR #2202:
URL: https://github.com/apache/arrow-datafusion/pull/2202#discussion_r847580201


##########
datafusion/core/src/physical_plan/file_format/parquet.rs:
##########
@@ -454,141 +587,6 @@ fn build_row_group_predicate(
     )
 }
 
-fn read_partition_no_file_columns(

Review Comment:
   This logic is moved and reformulated into the Iterator implementation for [`ParquetExecStream`]. This simplifies the code and also allows it to be used without an intermediate buffer



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org