You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/24 06:22:04 UTC

[GitHub] [incubator-inlong] healchow opened a new pull request #3344: [INLONG-3334][Manager] Get source field list from stream field table for Sort

healchow opened a new pull request #3344:
URL: https://github.com/apache/incubator-inlong/pull/3344


   ### Title Name: [INLONG-3334][Manager] Get source field list from stream field table for Sort
   
   Fixes #3334 
   
   ### Motivation
   
   Get source field list from stream field table for Sort.
   
   ### Modifications
   
   Add is_meta_field for `InlongStreamFieldEntity` and `StreamSinkFieldEntity`.
   
   ### Verifying this change
   
   - [X] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow merged pull request #3344: [INLONG-3334][Manager] Get source field list from stream field table for Sort

Posted by GitBox <gi...@apache.org>.
healchow merged pull request #3344:
URL: https://github.com/apache/incubator-inlong/pull/3344


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] yunqingmoswu commented on a change in pull request #3344: [INLONG-3334][Manager] Get source field list from stream field table for Sort

Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on a change in pull request #3344:
URL: https://github.com/apache/incubator-inlong/pull/3344#discussion_r833984007



##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/stream/InlongStreamFieldInfo.java
##########
@@ -48,14 +48,16 @@
     @ApiModelProperty(value = "value expression of predefined field")
     private String preExpression;
 
+    @ApiModelProperty("Field type")
     private String fieldType;
 
+    @ApiModelProperty("Field comment")
     private String fieldComment;
 
+    @ApiModelProperty("Is source meta field, 0: no, 1: yes")

Review comment:
       update the comment "Is source meta field, 0: no, 1: yes" to "Is meta field, 0: no, 1:yes"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org