You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ti...@apache.org on 2024/02/24 15:40:02 UTC

(tika) 03/03: TIKA-4203: add @Deprecated / @Override annotation

This is an automated email from the ASF dual-hosted git repository.

tilman pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git

commit f37fcad37f375fc70e01adb68a494fae942f1e67
Author: Tilman Hausherr <ti...@apache.org>
AuthorDate: Sat Feb 24 16:38:53 2024 +0100

    TIKA-4203: add @Deprecated / @Override annotation
---
 .../src/main/java/org/apache/tika/detect/ole/MiscOLEDetector.java     | 4 +++-
 .../src/main/java/org/apache/tika/parser/iptc/IptcAnpaParser.java     | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/main/java/org/apache/tika/detect/ole/MiscOLEDetector.java b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/main/java/org/apache/tika/detect/ole/MiscOLEDetector.java
index aefac501b..b6372903e 100644
--- a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/main/java/org/apache/tika/detect/ole/MiscOLEDetector.java
+++ b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/main/java/org/apache/tika/detect/ole/MiscOLEDetector.java
@@ -75,6 +75,7 @@ public class MiscOLEDetector implements Detector {
      * entry of the filesystem whose type is to be detected, as a
      * second argument.
      */
+    @Deprecated
     protected static MediaType detect(Set<String> names) {
         return detect(names, null);
     }
@@ -90,7 +91,7 @@ public class MiscOLEDetector implements Detector {
      * @return
      */
     protected static MediaType detect(Set<String> names, DirectoryEntry root) {
-        if (names == null || names.size() == 0) {
+        if (names == null || names.isEmpty()) {
             return OLE;
         } else if (names.contains("\u0005HwpSummaryInformation")) {
             // Hangul Word Processor v5+ (previous aren't OLE2-based)
@@ -162,6 +163,7 @@ public class MiscOLEDetector implements Detector {
         }
     }
 
+    @Override
     public MediaType detect(InputStream input, Metadata metadata) throws IOException {
         // Check if we have access to the document
         if (input == null) {
diff --git a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-news-module/src/main/java/org/apache/tika/parser/iptc/IptcAnpaParser.java b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-news-module/src/main/java/org/apache/tika/parser/iptc/IptcAnpaParser.java
index ad52ca775..dac96295c 100644
--- a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-news-module/src/main/java/org/apache/tika/parser/iptc/IptcAnpaParser.java
+++ b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-news-module/src/main/java/org/apache/tika/parser/iptc/IptcAnpaParser.java
@@ -115,6 +115,7 @@ public class IptcAnpaParser implements Parser {
     /**
      * @deprecated This method will be removed in Apache Tika 1.0.
      */
+    @Deprecated
     public void parse(InputStream stream, ContentHandler handler, Metadata metadata)
             throws IOException, SAXException, TikaException {
         parse(stream, handler, metadata, new ParseContext());