You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/05 13:39:34 UTC
[GitHub] [camel-quarkus] lburgazzoli opened a new pull request #849: Support
for camel-xml-io
lburgazzoli opened a new pull request #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849
Fixes #847
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #849:
Support for camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#discussion_r388756145
##########
File path: extensions/xml-io/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -16,8 +16,8 @@
#
---
-name: "Camel Quarkus XML Common"
-description: "The Camel Quarkus code XML module"
+name: "Camel Quarkus XML IO"
+description: "The Camel Quarkus XML IO module"
Review comment:
```suggestion
description: "An XML stack for parsing XML route definitions. A fast an light weight alternative to camel-quarkus-xml-jaxp"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595315766
OK, I hope I am starting to grasp this.
Here a couple of note about this PR (that still may reside on my false assumptions; plz correct me in such cases):
* The naming of the modules that follows the naming in Camel is a good thing.
* If camel-xml-jaxb support and camel-xml-io are there for parsing routes from XML, their pom.xml descriptions (and yaml metadata) should say so. I do not understand them as a general purpose XML parser and a general purpose JAXB package. They are there for end user apps that require parsing routes from XML. They are not there for other Camel Quarkus extensions to get a general XML support (we may need to add new/adapt existing extensions for that). Right?
* camel-xml-jaxp looks like a general purpose JAXP package to used by other camel components on the camel side and I assume it should be similar here in Camel Quarkus: camel-quarkus-xml-jaxp should be used by other extensions that need JAXP. End user apps should not depend on it directly. Right? If so, the current camel-quarkus-support-xml should be merged with camel-xml-jaxp. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #849:
Support for camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#discussion_r388756661
##########
File path: extensions/xml-jaxp/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -0,0 +1,28 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "Camel Quarkus XML Jaxp"
Review comment:
```suggestion
name: "Camel Quarkus XML JAXP"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595365987
I think we should avoid to duplicate the effort and document how the xml thing wotk on camel side, we can link the page here but I’d avoid duplication
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli edited a comment on issue #849: Support
for camel-xml-io
Posted by GitBox <gi...@apache.org>.
lburgazzoli edited a comment on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595250802
the user needs to decide what xml implementation is needed by its application and yes, we can certainly move them to support but there is the same artefact on camel side so to be consistent with the other extension I didn't put them to support folder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #849:
Support for camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#discussion_r388407485
##########
File path: extensions/xml-jaxp/deployment/pom.xml
##########
@@ -0,0 +1,77 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-xml-jaxp-parent</artifactId>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-xml-jaxp-deployment</artifactId>
+ <name>Camel Quarkus :: XML :: Jaxp :: Deployment</name>
Review comment:
`JAXP` here and elsewhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #849:
Support for camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#discussion_r388756498
##########
File path: extensions/xml-jaxb/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -0,0 +1,28 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "Camel Quarkus XML Jaxb"
+description: "The Camel Quarkus XML Jaxb module"
Review comment:
```suggestion
description: "An XML stack for parsing XML route definitions. A legacy alternative to the fast an light weight camel-quarkus-xml-io"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595250802
the user need to decide what xml implementation is needed, we can certainly move them to support but there is the same artifact on camel-side
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595334867
> > we need a separate support JAXP extension for the native quirks - so `camel-quarkus-support-xml` could be renamed to `camel-quarkus-support-jaxp`. WDYT?
>
> Yes that is something I was [thinking about](https://github.com/apache/camel-quarkus/pull/849#issuecomment-595236629)
Perfect. Please file a followup unless you want to amend now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #849:
Support for camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#discussion_r388406710
##########
File path: extensions/xml-io/pom.xml
##########
@@ -26,8 +26,8 @@
<relativePath>../../poms/build-parent/pom.xml</relativePath>
</parent>
- <artifactId>camel-quarkus-core-xml-parent</artifactId>
- <name>Camel Quarkus :: Core XML</name>
+ <artifactId>camel-quarkus-xml-io-parent</artifactId>
+ <name>Camel Quarkus :: XML :: Io</name>
Review comment:
`IO` maybe better? Here and elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595353676
The last open issue from my PoV is to document the purpose of the new extensions in their runtime/pom.xml `<description>`s and yaml metadata. Users should get an idea in which situations they need the dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595249037
A general question: are all these new `camel-xml-*` extensions supposed to be used by the app devs directly? If not, they should rather be support extensions, should they not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595364494
> should we fix it at camel side ?
Ideally both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] gnodet commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
gnodet commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595664601
> > > ```
> > > * If camel-xml-jaxb support and camel-xml-io are there for parsing routes from XML, their pom.xml descriptions (and yaml metadata) should say so. I do not understand them as a general purpose XML parser and a general purpose JAXB package. They are there for end user apps that require parsing routes from XML. They are not there for other Camel Quarkus extensions to get a general XML support (we may need to add new/adapt existing extensions for that). Right?
> > > ```
> >
> >
> > Not really, `camel-xml-io` contains an xml parser implementation as far as i know
>
> Yes, there is a parser implementing Camels own interface `org.apache.camel.xml.io.XmlPullParser` and no other Camel component depends on it except for the core part that parses the XML routes. So, for me this does not look like a general purpose parser ATM. Is it supposed to become one in the future?
>
The goal is not to make the parser public. If other parts/components need a lightweight parser, why not, but it should be part of a public API for users.
The only goal was to avoid having the dependency on the whole JAXP stack, but if users actually need to process XML data, it's safer to get the usual public API/ implementations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595333703
> > > ```
> > > * If camel-xml-jaxb support and camel-xml-io are there for parsing routes from XML, their pom.xml descriptions (and yaml metadata) should say so. I do not understand them as a general purpose XML parser and a general purpose JAXB package. They are there for end user apps that require parsing routes from XML. They are not there for other Camel Quarkus extensions to get a general XML support (we may need to add new/adapt existing extensions for that). Right?
> > > ```
> >
> >
> > Not really, `camel-xml-io` contains an xml parser implementation as far as i know
>
> Yes, there is a parser implementing Camels own interface `org.apache.camel.xml.io.XmlPullParser` and no other Camel component depends on it except for the core part that parses the XML routes. So, for me this does not look like a general purpose parser ATM. Is it supposed to become one in the future?
>
That is a question for @gnodet
> > > ```
> > > * camel-xml-jaxp looks like a general purpose JAXP package to used by other camel components on the camel side and I assume it should be similar here in Camel Quarkus: camel-quarkus-xml-jaxp should be used by other extensions that need JAXP. End user apps should not depend on it directly. Right? If so, the current camel-quarkus-support-xml should be merged with camel-xml-jaxp. WDYT?
> > > ```
> >
> >
> > The artefact contains as example the [XMLTokenizeLanguage](https://github.com/apache/camel/blob/master/core/camel-xml-jaxp/src/main/java/org/apache/camel/language/xtokenizer/XMLTokenizeLanguage.java) so I think it is safe to let the user if/when to include it.
>
> OK, so we need a separate support JAXP extension for the native quirks - so `camel-quarkus-support-xml` could be renamed to `camel-quarkus-support-jaxp`. WDYT?
Yes that is something I was [thinking about ](https://github.com/apache/camel-quarkus/pull/849#issuecomment-595236629)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] oscerd commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
oscerd commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595274114
If this is your idea probably you didn't look too deep in the camel code. They are not just alias.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga edited a comment on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga edited a comment on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595315766
OK, I hope I am starting to grasp this.
Here a couple of notes about this PR (that still may reside on my false assumptions; plz correct me in such cases):
* The naming of the modules that follows the naming in Camel is a good thing.
* If camel-xml-jaxb support and camel-xml-io are there for parsing routes from XML, their pom.xml descriptions (and yaml metadata) should say so. I do not understand them as a general purpose XML parser and a general purpose JAXB package. They are there for end user apps that require parsing routes from XML. They are not there for other Camel Quarkus extensions to get a general XML support (we may need to add new/adapt existing extensions for that). Right?
* camel-xml-jaxp looks like a general purpose JAXP package to used by other camel components on the camel side and I assume it should be similar here in Camel Quarkus: camel-quarkus-xml-jaxp should be used by other extensions that need JAXP. End user apps should not depend on it directly. Right? If so, the current camel-quarkus-support-xml should be merged with camel-xml-jaxp. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] gnodet commented on a change in pull request #849:
Support for camel-xml-io
Posted by GitBox <gi...@apache.org>.
gnodet commented on a change in pull request #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#discussion_r388778142
##########
File path: extensions/xml-io/runtime/pom.xml
##########
@@ -0,0 +1,81 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-xml-io-parent</artifactId>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-xml-io</artifactId>
+ <name>Camel Quarkus :: XML :: IO :: Runtime</name>
+ <description>Includes implementations of Camel's fast and lightweight XML parse</description>
Review comment:
I would not mention "XML stack", as this should not be made public. (and the parser is very limited, so _stack_ is a bit too much for it).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595329973
> > ```
> > * If camel-xml-jaxb support and camel-xml-io are there for parsing routes from XML, their pom.xml descriptions (and yaml metadata) should say so. I do not understand them as a general purpose XML parser and a general purpose JAXB package. They are there for end user apps that require parsing routes from XML. They are not there for other Camel Quarkus extensions to get a general XML support (we may need to add new/adapt existing extensions for that). Right?
> > ```
>
> Not really, `camel-xml-io` contains an xml parser implementation as far as i know
Yes, there is a parser implementing Camels own interface `org.apache.camel.xml.io.XmlPullParser` and no other Camel component depends on it except for the core part that parses the XML routes. So, for me this does not look like a general purpose parser ATM. Is it supposed to become one in the future?
> > ```
> > * camel-xml-jaxp looks like a general purpose JAXP package to used by other camel components on the camel side and I assume it should be similar here in Camel Quarkus: camel-quarkus-xml-jaxp should be used by other extensions that need JAXP. End user apps should not depend on it directly. Right? If so, the current camel-quarkus-support-xml should be merged with camel-xml-jaxp. WDYT?
> > ```
>
> The artefact contains as example the [XMLTokenizeLanguage](https://github.com/apache/camel/blob/master/core/camel-xml-jaxp/src/main/java/org/apache/camel/language/xtokenizer/XMLTokenizeLanguage.java) so I think it is safe to let the user if/when to include it.
OK, so we need a separate support JAXP extension for the native quirks - so `camel-quarkus-support-xml` could be renamed to `camel-quarkus-support-jaxp`. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595362680
should we fix it at camel side ? those extensions here are mainly wrapper
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #849:
Support for camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#discussion_r388754918
##########
File path: extensions/xml-jaxb/runtime/pom.xml
##########
@@ -21,17 +21,17 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.camel.quarkus</groupId>
- <artifactId>camel-quarkus-core-xml-parent</artifactId>
+ <artifactId>camel-quarkus-xml-jaxb-parent</artifactId>
<version>1.1.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
- <artifactId>camel-quarkus-core-xml</artifactId>
- <name>Camel Quarkus :: Core XML :: Runtime</name>
- <description>Includes implementations of Java Architecture for XML Binding (JAXB) and Java API for XML Processing (JAXP)</description>
+ <artifactId>camel-quarkus-xml-jaxb</artifactId>
+ <name>Camel Quarkus :: XML :: JAXB :: Runtime</name>
+ <description>Includes implementations of Java Architecture for XML Binding (JAXB)</description>
Review comment:
```suggestion
<description>An XML stack for parsing XML route definitions. A legacy alternative to the fast an light weight camel-quarkus-xml-io</description>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #849:
Support for camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#discussion_r388756275
##########
File path: extensions/xml-jaxb/runtime/src/main/resources/META-INF/quarkus-extension.yaml
##########
@@ -0,0 +1,28 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+---
+name: "Camel Quarkus XML Jaxb"
Review comment:
```suggestion
name: "Camel Quarkus XML JAXB"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #849:
Support for camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#discussion_r388407059
##########
File path: extensions/xml-jaxb/deployment/pom.xml
##########
@@ -21,13 +21,13 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.camel.quarkus</groupId>
- <artifactId>camel-quarkus-core-xml-parent</artifactId>
+ <artifactId>camel-quarkus-xml-jaxb-parent</artifactId>
<version>1.1.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
- <artifactId>camel-quarkus-core-xml-deployment</artifactId>
- <name>Camel Quarkus :: Core XML :: Deployment</name>
+ <artifactId>camel-quarkus-xml-jaxb-deployment</artifactId>
+ <name>Camel Quarkus :: XML :: Jaxb :: Deployment</name>
Review comment:
`JAXB` here and elsewhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595236629
With this PR, `camel-quarkus-support-xml` has no dependencies and the only task is to add reflective classes.
I'm not sure if this extension should be kept as it is (i.e. the name is misleading) but I think we need to have a better view about the requirements of other extensions in relation to XML so we may re-factor it when we have a better idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga edited a comment on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga edited a comment on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595279653
Ah, sorry, indeed there is actually some code in those modules. I am deformed by Camel Quarkus where we just wrap things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595271248
I am struggling to understand the purpose of camel-xml-jaxp and camel-xml-io (in Camel). camel-xml-jaxp is just an alias for camel-support and and camel-xml-io is just an alias for camel-core-engine. What is the actual reason for their existence?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595336645
> > > we need a separate support JAXP extension for the native quirks - so `camel-quarkus-support-xml` could be renamed to `camel-quarkus-support-jaxp`. WDYT?
> >
> >
> > Yes that is something I was [thinking about](https://github.com/apache/camel-quarkus/pull/849#issuecomment-595236629)
>
> Perfect. Please file a followup unless you want to amend now.
Will open a follow up issue as soon this get merged so I have the right pointers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga merged pull request #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli edited a comment on issue #849: Support
for camel-xml-io
Posted by GitBox <gi...@apache.org>.
lburgazzoli edited a comment on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595250802
the user need to decide what xml implementation is needed by its application and yes, we can certainly move them to support but there is the same artefact on camel-side so to be consistent with the other extension I didn't put them to support folder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] gnodet commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
gnodet commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595275530
@ppalaga we're trying to make camel a bit more modular. In addition to that, we want to have a camel which is lightweight enough in Quarkus. Previsouly, xml routes were supported through jaxb only. Now, we do support loading xml routes either using JAXB (using `camel-xml-jaxb` support) or using a generated lightweight parser (using `camel-xml-io`).
In the same idea, all the xml related support (mostly things that do use the JDK XML support) has been moved to `camel-xml-jaxp`.
The overall goal is that camel quarkus native binaries will be as light as possible, not including the xml parsers (xerces / xalan embedded in the JDK) or jaxb if not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595279653
Ah, sorry, indeed there is actually some code in those modules. I am fully by Camel Quarkus where we just wrap things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #849:
Support for camel-xml-io
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#discussion_r388754576
##########
File path: extensions/xml-io/runtime/pom.xml
##########
@@ -0,0 +1,81 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-xml-io-parent</artifactId>
+ <version>1.1.0-SNAPSHOT</version>
+ <relativePath>../pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-xml-io</artifactId>
+ <name>Camel Quarkus :: XML :: IO :: Runtime</name>
+ <description>Includes implementations of Camel's fast and lightweight XML parse</description>
Review comment:
```suggestion
<description>An XML stack for parsing XML route definitions. A fast an light weight alternative to camel-quarkus-xml-jaxp</description>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #849: Support for
camel-xml-io
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #849: Support for camel-xml-io
URL: https://github.com/apache/camel-quarkus/pull/849#issuecomment-595322753
> * If camel-xml-jaxb support and camel-xml-io are there for parsing routes from XML, their pom.xml descriptions (and yaml metadata) should say so. I do not understand them as a general purpose XML parser and a general purpose JAXB package. They are there for end user apps that require parsing routes from XML. They are not there for other Camel Quarkus extensions to get a general XML support (we may need to add new/adapt existing extensions for that). Right?
>
Not really, `camel-xml-io` contains an xml parser implementation as far as i know
> * camel-xml-jaxp looks like a general purpose JAXP package to used by other camel components on the camel side and I assume it should be similar here in Camel Quarkus: camel-quarkus-xml-jaxp should be used by other extensions that need JAXP. End user apps should not depend on it directly. Right? If so, the current camel-quarkus-support-xml should be merged with camel-xml-jaxp. WDYT?
The artefact contains as example the [XMLTokenizeLanguage](https://github.com/apache/camel/blob/master/core/camel-xml-jaxp/src/main/java/org/apache/camel/language/xtokenizer/XMLTokenizeLanguage.java) so I think it is safe to let the user if/when to include it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services