You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/29 20:03:43 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #6504: Python: Add tests
Fokko opened a new pull request, #6504:
URL: https://github.com/apache/iceberg/pull/6504
To maintain 90% code coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #6504: Python: Add tests
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #6504:
URL: https://github.com/apache/iceberg/pull/6504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #6504: Python: Add tests
Posted by GitBox <gi...@apache.org>.
Fokko commented on code in PR #6504:
URL: https://github.com/apache/iceberg/pull/6504#discussion_r1059129800
##########
python/pyiceberg/typedef.py:
##########
@@ -54,12 +54,9 @@ def __init__(self, default_factory: Callable[[K], V]):
self.default_factory = default_factory
def __missing__(self, key: K) -> V:
- if self.default_factory is None:
Review Comment:
`self.default_factory` cannot be null because of the type signature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org