[GitHub] [beam] TheNeuralBit commented on a change in pull request #15821: [BEAM-11936] Fix errorprone warnings

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #15821:
URL: https://github.com/apache/beam/pull/15821#discussion_r739513205



##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnInvokersTest.java
##########
@@ -92,6 +92,7 @@
 @RunWith(JUnit4.class)
 @SuppressWarnings({
   "rawtypes", // TODO(https://issues.apache.org/jira/browse/BEAM-10556)
+  "SameNameButDifferent"

Review comment:
       Here as well

##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/transforms/GroupTest.java
##########
@@ -70,6 +70,7 @@
 @Category(UsesSchema.class)
 @SuppressWarnings({
   "rawtypes", // TODO(https://issues.apache.org/jira/browse/BEAM-10556)
+  "SameNameButDifferent"

Review comment:
       Why not fix this one?

##########
File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/ProcessRemoteBundleOperation.java
##########
@@ -54,13 +54,16 @@
   private final StageBundleFactory stageBundleFactory;
   private static final OutputReceiver[] EMPTY_RECEIVER_ARRAY = new OutputReceiver[0];
   private final Map<String, OutputReceiver> outputReceiverMap;
+
+  @SuppressWarnings("UnnecessaryAnonymousClass")

Review comment:
       I was going to request we go ahead and resolve these, but I'm not really clear on how to do it. It seems like we'd need to do some refactoring. So I think this is fine for now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org