You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/17 14:18:49 UTC
[GitHub] [cloudstack] mib1185 opened a new pull request #6134: Ffix linux native bridge for SUSE in cloudutils
mib1185 opened a new pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134
### Description
- This PR fixes #6112
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [x] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1072929094
@blueorangutan test suse15 kvm-suse15 keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1075219576
Merging based on the approvals and manual tests + smoke test results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1074579341
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1073040127
<b>Trillian test result (tid-3672)</b>
Environment: kvm-suse15 (x2), Advanced Networking with Mgmt server s15
Total time taken: 45629 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6134-t3672-kvm-suse15.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 152.22 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 50.27 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1071008368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#discussion_r829716845
##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -374,6 +374,8 @@ def addBridge(self, brName, dev):
if self.syscfg.env.bridgeType == "openvswitch":
if cfo.getEntry("IPADDR"):
cfo.rmEntry("IPADDR", cfo.getEntry("IPADDR"))
+ elif self.syscfg.env.bridgeType == "native":
+ cfo.addEntry("BRIDGE", brName)
Review comment:
```suggestion
pass
```
At this point, we're modifying the interface not the bridge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1074578275
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1074606512
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1075099009
rebase and re-targeting done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1075147297
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1075173703
@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1071082871
@blueorangutan help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1072089136
Can run `cloudstack-setup-agent` with this fix. Since this doesn't affect any features, smoke tests can be ignored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 edited a comment on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
mib1185 edited a comment on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1071008368
> Lgtm needs testing
Have tested it in my test environment, but would like to see this working in your Trilian test system :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1070987202
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1072929256
@nvazquez a Trillian-Jenkins test job (suse15 mgmt + kvm-suse15) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#discussion_r829716845
##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -374,6 +374,8 @@ def addBridge(self, brName, dev):
if self.syscfg.env.bridgeType == "openvswitch":
if cfo.getEntry("IPADDR"):
cfo.rmEntry("IPADDR", cfo.getEntry("IPADDR"))
+ elif self.syscfg.env.bridgeType == "native":
+ cfo.addEntry("BRIDGE", brName)
Review comment:
```suggestion
pass
```
At this point, we're modifying the interface not the bridge
##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -374,6 +374,8 @@ def addBridge(self, brName, dev):
if self.syscfg.env.bridgeType == "openvswitch":
if cfo.getEntry("IPADDR"):
cfo.rmEntry("IPADDR", cfo.getEntry("IPADDR"))
+ elif self.syscfg.env.bridgeType == "native":
+ cfo.addEntry("BRIDGE", brName)
Review comment:
```suggestion
pass
```
At this point, we're modifying the interface not the bridge. In suse, the bridge is mapped to the device, not the other way around https://github.com/apache/cloudstack/blob/main/python/lib/cloudutils/serviceConfig.py#L393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1071082871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1075070881
Hi @mib1185 thanks for the fix - could you please target it for the branch 4.16?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1075212341
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1071325390
@DaanHoogland does the `kvm-suse15` use ovs oder Linux native bridge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1072054667
@mib1185 It uses Linux bridges, however they are preconfigured before installing the cloudstack agent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
mib1185 commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1071008368
> Lgtm needs testing
Have tested it in my test environment, but would like to see this working in your Trilian test system working :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1074722318
No need to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1071065226
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1071083745
@DaanHoogland I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['suse15', 'centos7', 'centos6', 'alma8', 'ubuntu18', 'ubuntu20', 'rocky8']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-alma8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.
Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'nvazquez', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti', 'weizhouapache', 'NuxRo']
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1072086910
<b>Trillian test result (tid-3655)</b>
Environment: kvm-suse15 (x2), Advanced Networking with Mgmt server s15
Total time taken: 48839 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6134-t3655-kvm-suse15.zip
Smoke tests completed. 87 look OK, 5 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.48 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.10 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.19 | test_primary_storage.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 29.90 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 75.96 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 71.75 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 73.47 | test_kubernetes_clusters.py
test_01_migrate_VM_and_root_volume | `Error` | 154.32 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 49.26 | test_vm_life_cycle.py
test_01_secure_vm_migration | `Error` | 225.67 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 265.69 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 142.77 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 43.71 | test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store | `Error` | 8.42 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 8.42 | test_snapshots.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 303.88 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1070988256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1075231340
Thanks @mib1185 - have marked it as a draft PR to prevent merging before our testing concludes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez removed a comment on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
nvazquez removed a comment on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1075219576
Merging based on the approvals and manual tests + smoke test results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1070987202
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1071097200
@DaanHoogland a Trillian-Jenkins test job (suse15 mgmt + kvm-suse15) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1075125447
Thanks @mib1185 kicking new packages
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] mib1185 edited a comment on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
mib1185 edited a comment on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1071008368
> Lgtm needs testing
Have tested it in my test environment, but would like to see this working in your Trilian test system :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1071095465
@blueorangutan test suse15 kvm-suse15 keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#discussion_r829716845
##########
File path: python/lib/cloudutils/serviceConfig.py
##########
@@ -374,6 +374,8 @@ def addBridge(self, brName, dev):
if self.syscfg.env.bridgeType == "openvswitch":
if cfo.getEntry("IPADDR"):
cfo.rmEntry("IPADDR", cfo.getEntry("IPADDR"))
+ elif self.syscfg.env.bridgeType == "native":
+ cfo.addEntry("BRIDGE", brName)
Review comment:
```suggestion
pass
```
At this point, we're modifying the interface not the bridge. In suse, the bridge is mapped to the device, not the other way around https://github.com/apache/cloudstack/blob/main/python/lib/cloudutils/serviceConfig.py#L393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1070988256
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6134: Fix linux native bridge for SUSE in cloudutils
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6134:
URL: https://github.com/apache/cloudstack/pull/6134#issuecomment-1072054667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org