You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/11/17 17:03:58 UTC
[PR] [multistage] canonicalize SqlKind.OTHERS as well as SqlKind.OTHER_FUNCTIONS [pinot]
walterddr opened a new pull request, #12025:
URL: https://github.com/apache/pinot/pull/12025
Fix the following issues:
When compiling the RexExpression
- SqlKind.OTHERS should extract actual function name inside obj instead of getting the toString functionName "others"
- SqlKind.OTHERS/OTHER_FUNCTIONS should canonicalized function name during parsing instead of rely on downstream operator to parse and interpret them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [multistage][bugfix] canonicalize SqlKind.OTHERS as well as SqlKind.OTHER_FUNCTIONS [pinot]
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #12025:
URL: https://github.com/apache/pinot/pull/12025#discussion_r1397833822
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/parser/CalciteRexExpressionParser.java:
##########
@@ -223,12 +226,13 @@ private static Expression compileFunctionExpression(RexExpression.FunctionCall r
return compileAndExpression(rexCall, pinotQuery);
case OR:
return compileOrExpression(rexCall, pinotQuery);
+ case OTHER:
Review Comment:
yes.
in our RexExpression context. RexExpression type `FunctionCall` stems from RexCall which encapsulates an `SqlOperator#SqlKind` and `SqlOperator#name` --> thus it should always have a name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [multistage][bugfix] canonicalize SqlKind.OTHERS as well as SqlKind.OTHER_FUNCTIONS [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #12025:
URL: https://github.com/apache/pinot/pull/12025#discussion_r1397808096
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/parser/CalciteRexExpressionParser.java:
##########
@@ -223,12 +226,13 @@ private static Expression compileFunctionExpression(RexExpression.FunctionCall r
return compileAndExpression(rexCall, pinotQuery);
case OR:
return compileOrExpression(rexCall, pinotQuery);
+ case OTHER:
Review Comment:
Does `OTHER` always have function name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [multistage][bugfix] canonicalize SqlKind.OTHERS as well as SqlKind.OTHER_FUNCTIONS [pinot]
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr merged PR #12025:
URL: https://github.com/apache/pinot/pull/12025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org