[jira] [Commented] (BEAM-7143) adding withConsumerConfigUpdates

["Alexey Romanenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829548#comment-16829548 ] 

Alexey Romanenko commented on BEAM-7143:
----------------------------------------

Thanks for opening this issue but I'm not sure that we need to rename this method {{updateConsumerProperties}} by analogy with {{withOffsetConsumerConfigOverrides}} since they work a bit differently - the former just updates new config properties and keep old ones, whereas the latter overrides configuration completely. So, it can be confusing.
We also have similar method {{updateProducerProperties}} for Producer which works similar to {{updateConsumerProperties}}.

> adding withConsumerConfigUpdates
> --------------------------------
>
>                 Key: BEAM-7143
>                 URL: https://issues.apache.org/jira/browse/BEAM-7143
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-kafka
>            Reporter: Heejong Lee
>            Assignee: Heejong Lee
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> To modify `ConsumerConfig` for main consumer, we use `updateConsumerProperties`. However, to modify `ConsumerConfig` for offset consumer, the right method is `withOffsetConsumerConfigOverrides`. It would be good to match both names for improving usability.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)