You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/25 15:46:55 UTC

[GitHub] [arrow] ianmcook commented on a change in pull request #10390: ARROW-12751: [C++] Implement minimum/maximum kernels

ianmcook commented on a change in pull request #10390:
URL: https://github.com/apache/arrow/pull/10390#discussion_r638925147



##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -42,6 +42,11 @@ struct ArithmeticOptions : public FunctionOptions {
   bool check_overflow;
 };
 
+struct ARROW_EXPORT MinMaxOptions : public FunctionOptions {

Review comment:
       I think it is worth giving this a more general name, because there are other potential uses. Maybe `ElementWiseAggregateOptions`? (since this is aggregation, just across instead of down)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org