You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Anna Szonyi <sz...@cloudera.com> on 2016/12/14 15:09:01 UTC
Review Request 54746: SQOOP-3083 Fault injection targets no longer
work after SQOOP-2983 due to introducing try with resource
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54746/
-----------------------------------------------------------
Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and Erzsebet Szilagyi.
Bugs: SQOOP-3083
https://issues.apache.org/jira/browse/SQOOP-3083
Repository: sqoop-trunk
Description
-------
SQOOP-3083 Fault injection targets no longer work after SQOOP-2983 due to introducing try with resource
Diffs
-----
ivy/libraries.properties e2c2516
src/test/aop/build/aop.xml 77320aa
Diff: https://reviews.apache.org/r/54746/diff/
Testing
-------
ant compile, ant test, ant jar-fault-inject
Thanks,
Anna Szonyi
Re: Review Request 54746: SQOOP-3083 Fault injection targets no
longer work after SQOOP-2983 due to introducing try with resource
Posted by Erzsebet Szilagyi <er...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54746/#review159312
-----------------------------------------------------------
Ship it!
Ship It!
- Erzsebet Szilagyi
On Dec. 14, 2016, 4:45 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54746/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 4:45 p.m.)
>
>
> Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and Erzsebet Szilagyi.
>
>
> Bugs: SQOOP-3083
> https://issues.apache.org/jira/browse/SQOOP-3083
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3083 Fault injection targets no longer work after SQOOP-2983 due to introducing try with resource
>
>
> Diffs
> -----
>
> ivy/libraries.properties e2c2516
> src/test/aop/build/aop.xml 77320aa
>
> Diff: https://reviews.apache.org/r/54746/diff/
>
>
> Testing
> -------
>
> ant compile, ant test, ant jar-fault-inject
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 54746: SQOOP-3083 Fault injection targets no
longer work after SQOOP-2983 due to introducing try with resource
Posted by Attila Szabo <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54746/#review159428
-----------------------------------------------------------
Ship it!
Hey Anna,
Thanks for spotting+patching this!
Cheers,
Attila
- Attila Szabo
On Dec. 15, 2016, 7:37 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54746/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2016, 7:37 p.m.)
>
>
> Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and Erzsebet Szilagyi.
>
>
> Bugs: SQOOP-3083
> https://issues.apache.org/jira/browse/SQOOP-3083
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3083 Fault injection targets no longer work after SQOOP-2983 due to introducing try with resource
>
>
> Diffs
> -----
>
> ivy/libraries.properties e2c2516
> src/test/aop/build/aop.xml 77320aa
>
> Diff: https://reviews.apache.org/r/54746/diff/
>
>
> Testing
> -------
>
> ant compile, ant test, ant jar-fault-inject
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 54746: SQOOP-3083 Fault injection targets no
longer work after SQOOP-2983 due to introducing try with resource
Posted by Anna Szonyi <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54746/
-----------------------------------------------------------
(Updated Dec. 15, 2016, 7:37 p.m.)
Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and Erzsebet Szilagyi.
Changes
-------
removed change for aspectjTaskdefs.properties path
Bugs: SQOOP-3083
https://issues.apache.org/jira/browse/SQOOP-3083
Repository: sqoop-trunk
Description
-------
SQOOP-3083 Fault injection targets no longer work after SQOOP-2983 due to introducing try with resource
Diffs (updated)
-----
ivy/libraries.properties e2c2516
src/test/aop/build/aop.xml 77320aa
Diff: https://reviews.apache.org/r/54746/diff/
Testing
-------
ant compile, ant test, ant jar-fault-inject
Thanks,
Anna Szonyi
Re: Review Request 54746: SQOOP-3083 Fault injection targets no
longer work after SQOOP-2983 due to introducing try with resource
Posted by Anna Szonyi <sz...@cloudera.com>.
> On Dec. 15, 2016, 4:32 p.m., Szabolcs Vasas wrote:
> > src/test/aop/build/aop.xml, line 41
> > <https://reviews.apache.org/r/54746/diff/2/?file=1584274#file1584274line41>
> >
> > It seems this patch contains the content of SQOOP-3084 too, so if won't apply if SQOOP-3084 gets committed first. Or do you want to merge to 2 changes?
You're right, I wanted to separate them, so they could be ported/backported independedntly as they stem from two different issues.
- Anna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54746/#review159313
-----------------------------------------------------------
On Dec. 15, 2016, 7:37 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54746/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2016, 7:37 p.m.)
>
>
> Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and Erzsebet Szilagyi.
>
>
> Bugs: SQOOP-3083
> https://issues.apache.org/jira/browse/SQOOP-3083
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3083 Fault injection targets no longer work after SQOOP-2983 due to introducing try with resource
>
>
> Diffs
> -----
>
> ivy/libraries.properties e2c2516
> src/test/aop/build/aop.xml 77320aa
>
> Diff: https://reviews.apache.org/r/54746/diff/
>
>
> Testing
> -------
>
> ant compile, ant test, ant jar-fault-inject
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 54746: SQOOP-3083 Fault injection targets no
longer work after SQOOP-2983 due to introducing try with resource
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54746/#review159313
-----------------------------------------------------------
src/test/aop/build/aop.xml (line 41)
<https://reviews.apache.org/r/54746/#comment230288>
It seems this patch contains the content of SQOOP-3084 too, so if won't apply if SQOOP-3084 gets committed first. Or do you want to merge to 2 changes?
- Szabolcs Vasas
On Dec. 14, 2016, 3:45 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54746/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 3:45 p.m.)
>
>
> Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and Erzsebet Szilagyi.
>
>
> Bugs: SQOOP-3083
> https://issues.apache.org/jira/browse/SQOOP-3083
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3083 Fault injection targets no longer work after SQOOP-2983 due to introducing try with resource
>
>
> Diffs
> -----
>
> ivy/libraries.properties e2c2516
> src/test/aop/build/aop.xml 77320aa
>
> Diff: https://reviews.apache.org/r/54746/diff/
>
>
> Testing
> -------
>
> ant compile, ant test, ant jar-fault-inject
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 54746: SQOOP-3083 Fault injection targets no
longer work after SQOOP-2983 due to introducing try with resource
Posted by Anna Szonyi <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54746/
-----------------------------------------------------------
(Updated Dec. 14, 2016, 3:45 p.m.)
Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and Erzsebet Szilagyi.
Changes
-------
re-added newlines
Bugs: SQOOP-3083
https://issues.apache.org/jira/browse/SQOOP-3083
Repository: sqoop-trunk
Description
-------
SQOOP-3083 Fault injection targets no longer work after SQOOP-2983 due to introducing try with resource
Diffs (updated)
-----
ivy/libraries.properties e2c2516
src/test/aop/build/aop.xml 77320aa
Diff: https://reviews.apache.org/r/54746/diff/
Testing
-------
ant compile, ant test, ant jar-fault-inject
Thanks,
Anna Szonyi