[GitHub] [jclouds] SATYANAN-ANAND commented on pull request #133: JCLOUDS-1597: Support for Alerts

[GitBox <gi...@apache.org>]

SATYANAN-ANAND commented on pull request #133:
URL: https://github.com/apache/jclouds/pull/133#issuecomment-1043188067


   > Thanks @SATYANAN-ANAND! This is looking much better!
   > 
   > > Is it possible to add any integration tests?
   > 
   > As @gaul says, it is important to add the corresponding tests to this PR. Every single method in the API you have created should have:
   > 
   > * The corresponding `Mock` tests that verify that the requests that are generated when calling those methods are correct. These tests run offline and helps us verify our methods generate the requests as expected. It is important here to test the behavior with different options to verify query parameters are properly populated, simulate requests that should return 404, etc, to make sure the API handles correctly normal and error responses.
   > * The corresponding `Live` tests that will execute the methods for real. This is what will give us the confidence that the API works as expected and we'll be able to run them as part of our CI and to do proper checks before releasing newer versions.
   > 
   > You can take a look at the existing tests for other APIs and use them s a reference: https://github.com/apache/jclouds/tree/master/providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features
   
   Added 
   1. ActivityLogAlertApiMockTest.java
   2. ActivityLogAlertApiLiveTest.java
   3. AlertApiMockTest.java
   4. AlertApiLiveTest.java 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org