You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2013/06/10 13:42:21 UTC

[jira] [Commented] (WICKET-5215) Better exception message when Page instantiation fails in DefaultPageFactory

    [ https://issues.apache.org/jira/browse/WICKET-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679446#comment-13679446 ] 

Martin Grigorov commented on WICKET-5215:
-----------------------------------------

Hi,

I've improved the exception messages for the non-visible case with: https://git-wip-us.apache.org/repos/asf/wicket/repo?p=wicket.git;a=commitdiff;h=397f89954f753dd343f48ec68bbf3f0d0e81b6d4

What do you mean with "injecting dependencies" ?
Please create a failing test case in org.apache.wicket.session.DefaultPageFactoryTest if the new improvement doesn't cover all requirements.
                
> Better exception message when Page instantiation fails in DefaultPageFactory
> ----------------------------------------------------------------------------
>
>                 Key: WICKET-5215
>                 URL: https://issues.apache.org/jira/browse/WICKET-5215
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 6.8.0
>            Reporter: Edvard Fonsell
>            Assignee: Martin Grigorov
>            Priority: Minor
>
> If injecting dependencies to a page fails in DefaultPageFactory.newPage, the exception message is a bit misleading:
> "Can't instantiate page using constructor '...' and argument '...'. Might be it doesn't exist, may be it is not visible (public)."
> It could also mention the possibility of failing to inject the dependencies, which seems to be the case in many occasions.
> Even better, when calling the constructor fails, it could check the existence and visibility of the constructor instead of guessing what was the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira