[GitHub] [airflow] Taragolis commented on a diff in pull request #29395: Fix validation of date-time field in API and Parameter schemas

["Taragolis (via GitHub)" <gi...@apache.org>]

Taragolis commented on code in PR #29395:
URL: https://github.com/apache/airflow/pull/29395#discussion_r1098031946


##########
newsfragments/29395.significant.rst:
##########
@@ -0,0 +1,7 @@
+The date-time fields passed as API parameters or Params should be RFC3999-compliant.
+
+In case of API calls, it was possible that "+" passed as part of the date-time fields were not URL-encoded, and
+such date-time fields could pass validation. Such date-time parameters should now be URL-encoded (as ``%2B``).

Review Comment:
   OMG! I've broke my head when I tried to understand why on Earth `tests/api_connexion/endpoints/test_dag_run_endpoint.py::TestGetDagRunsPaginationFilters::test_date_filters_gte_and_lte` failed what the component changed `2020-06-18T18:00:00+00:00` to `2020-06-18T18:00:00 00:00`



##########
newsfragments/29395.significant.rst:
##########
@@ -0,0 +1,7 @@
+The date-time fields passed as API parameters or Params should be RFC3999-compliant.

Review Comment:
   ```suggestion
   The date-time fields passed as API parameters or Params should be RFC3339-compliant.
   ```



##########
newsfragments/29395.significant.rst:
##########
@@ -0,0 +1,7 @@
+The date-time fields passed as API parameters or Params should be RFC3999-compliant.
+
+In case of API calls, it was possible that "+" passed as part of the date-time fields were not URL-encoded, and
+such date-time fields could pass validation. Such date-time parameters should now be URL-encoded (as ``%2B``).
+
+In case of parameters, it was possible that ' ' was used instead of ``T`` separating date from time and no
+timezone was specified, which was invalid specification (not compliant with RFC3999).

Review Comment:
   ```suggestion
   timezone was specified, which was invalid specification (not compliant with RFC3339).
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org