You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/10/14 12:02:06 UTC
[GitHub] weijietong opened a new pull request #1504: DRILL-6792: Find the right probe side fragment wrapper & fix DrillBuf…
weijietong opened a new pull request #1504: DRILL-6792: Find the right probe side fragment wrapper & fix DrillBuf…
URL: https://github.com/apache/drill/pull/1504
This PR mainly solves two problems about JPPD:
1. Refactor the logic to find the right probe side fragment wrapper which contains the `RuntimeFilterPOP` at the physical operator tree.
The reason to do this is that the original implementation logic depends on `GroupScan`'s digest. But that value maybe changed after being first time attached to the `RuntimeFilterDef` due to different plugin implementation logics. Now we generate a unique identifier to represent the `RuntimeFilterPOP` ,attach this identifier to the `RuntimeFilterDef`, find the right probe side fragment `Wrapper` according to the identifier.
2. Fix BloomFilter's `DrillBuf` reference counter bugs while passing `RuntimeFilterWritable` between different threads.
The original implementation logic lacks the logic to retain the `RuntimeFilterWritable` underlying DrillBuf reference count while the receiving thread received it.
@sohami @amansinha100 please review it, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services