You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:09:28 UTC

[GitHub] [gobblin] ZihanLi58 opened a new pull request #3309: [GOBBLIN-1469]Fix Issue that hive registration cannot process when schema.literal is not set

ZihanLi58 opened a new pull request #3309:
URL: https://github.com/apache/gobblin/pull/3309

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1469

### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
We have noticed two instances where the streaming topics were having Missing/Orphan hive partition issues. After investigating, it's because the schema.literal is missing when creating the table, and thus the following partition registration in ingestion job are all fail which cause the hourly partition missing. So create this ticket to make it able to proceed hive registration even if schema.literal is missing.

### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:

### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] hanghangliu commented on pull request #3309: [GOBBLIN-1469]Fix Issue that hive registration cannot process when schema.literal is not set

Posted by GitBox <gi...@apache.org>.

hanghangliu commented on pull request #3309:
URL: https://github.com/apache/gobblin/pull/3309#issuecomment-860923788


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] ZihanLi58 commented on pull request #3309: [GOBBLIN-1469]Fix Issue that hive registration cannot process when schema.literal is not set

Posted by GitBox <gi...@apache.org>.

ZihanLi58 commented on pull request #3309:
URL: https://github.com/apache/gobblin/pull/3309#issuecomment-860912190


   @hanghangliu can you help take a look at this small change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] autumnust merged pull request #3309: [GOBBLIN-1469]Fix Issue that hive registration cannot process when schema.literal is not set

Posted by GitBox <gi...@apache.org>.

autumnust merged pull request #3309:
URL: https://github.com/apache/gobblin/pull/3309


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org