[jira] [Comment Edited] (THRIFT-5368) fb303 doesn't compile in c++

["Jens Geyer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299143#comment-17299143 ] 

Jens Geyer edited comment on THRIFT-5368 at 3/10/21, 9:43 PM:
--------------------------------------------------------------

The code in the contrib folder is not maintained on a regular basis and its purpose is mainly to serve as sample code what can be done with Thrift. You are of course free to provide patches for it but other than that the contrib stuff may or may not work.

Here's a good explanation of how it works.
https://drewdevault.com/2020/06/06/Add-a-contrib-directory.html


was (Author: jensg):
The code in the contrib folder is not maintained on a regular basis and its purpose is mainly to serve as sample code what can be done with Thrift. You are of course free to provide patches for it but other than that the contrib stuff may or may not work.

> fb303 doesn't compile in c++
> ----------------------------
>
>                 Key: THRIFT-5368
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5368
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.13.0
>            Reporter: Csaba Ringhofer
>            Priority: Major
>
> I tried to build Thrift 0.13.0 for Impala, and fb303 doesn' t compile due to missing apache::thrift::concurrency::ReadWriteMutex. If I understand correctly it was removed in https://github.com/apache/thrift/commit/ca8af9b48f9e62edc57c4a233c6377144214ef5
> Note that I am not exactly sure why we need fb303 in Impala. so it may turn out that it can be removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)