You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Gerolf Seitz <ge...@gmail.com> on 2008/05/16 17:04:37 UTC

include OSGi bundle metadata?

hey,

I was wondering whether we should follow the recent trend and include
OSGi metadata with our releases?
we could do this unobtrusively with the org.apache.felix:maven-bundle-plugin
plugin.
see the patch at the end of this mail.

wdyt?

 Gerolf




Index: pom.xml
===================================================================
--- pom.xml    (revision 650770)
+++ pom.xml    (working copy)
@@ -545,6 +545,11 @@
                     </execution>
                 </executions>
             </plugin>
+            <plugin>
+                <groupId>org.apache.felix</groupId>
+                <artifactId>maven-bundle-plugin</artifactId>
+                <inherited>true</inherited>
+            </plugin>
         </plugins>

         <pluginManagement>
@@ -615,6 +620,7 @@

<addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>

<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
                             </manifest>
+
<manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
                             <manifestEntries>
                             </manifestEntries>
                         </archive>
@@ -694,6 +700,19 @@
                     </executions>
                     <inherited>true</inherited>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.felix</groupId>
+                    <artifactId>maven-bundle-plugin</artifactId>
+                    <executions>
+                        <execution>
+                            <id>bundle-manifest</id>
+                            <phase>process-classes</phase>
+                            <goals>
+                                <goal>manifest</goal>
+                            </goals>
+                        </execution>
+                    </executions>
+                </plugin>
             </plugins>
         </pluginManagement>
     </build>

Re: include OSGi bundle metadata?

Posted by Igor Vaynberg <ig...@gmail.com>.
sounds good. i dont have anything against this.

-igor


On Fri, May 16, 2008 at 8:26 AM, Gerolf Seitz <ge...@gmail.com> wrote:
>>
>> fine by me. i assume the plugin will export every package?
>>
>
> yes,
> "Additionally, it generates imports for every export to ensure package
> substitutability, ..."
>
>  Gerolf
>

Re: include OSGi bundle metadata?

Posted by Gerolf Seitz <ge...@gmail.com>.
>
> fine by me. i assume the plugin will export every package?
>

yes,
"Additionally, it generates imports for every export to ensure package
substitutability, ..."

  Gerolf

Re: include OSGi bundle metadata?

Posted by James Carman <ja...@carmanconsulting.com>.
Oops, hit send too early:

...and it didn't really impact any of our normal settings.  It was
quite seamless.

On Fri, May 16, 2008 at 11:20 AM, James Carman
<ja...@carmanconsulting.com> wrote:
> It's fairly straightforward to include this.  We added to the Apache
> Commons parent pom.xml.
>
> On Fri, May 16, 2008 at 11:17 AM, Igor Vaynberg <ig...@gmail.com> wrote:
>> fine by me. i assume the plugin will export every package?
>>
>> -igor
>>
>>
>> On Fri, May 16, 2008 at 8:04 AM, Gerolf Seitz <ge...@gmail.com> wrote:
>>> hey,
>>>
>>> I was wondering whether we should follow the recent trend and include
>>> OSGi metadata with our releases?
>>> we could do this unobtrusively with the org.apache.felix:maven-bundle-plugin
>>> plugin.
>>> see the patch at the end of this mail.
>>>
>>> wdyt?
>>>
>>>  Gerolf
>>>
>>>
>>>
>>>
>>> Index: pom.xml
>>> ===================================================================
>>> --- pom.xml    (revision 650770)
>>> +++ pom.xml    (working copy)
>>> @@ -545,6 +545,11 @@
>>>                     </execution>
>>>                 </executions>
>>>             </plugin>
>>> +            <plugin>
>>> +                <groupId>org.apache.felix</groupId>
>>> +                <artifactId>maven-bundle-plugin</artifactId>
>>> +                <inherited>true</inherited>
>>> +            </plugin>
>>>         </plugins>
>>>
>>>         <pluginManagement>
>>> @@ -615,6 +620,7 @@
>>>
>>> <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
>>>
>>> <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
>>>                             </manifest>
>>> +
>>> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
>>>                             <manifestEntries>
>>>                             </manifestEntries>
>>>                         </archive>
>>> @@ -694,6 +700,19 @@
>>>                     </executions>
>>>                     <inherited>true</inherited>
>>>                 </plugin>
>>> +                <plugin>
>>> +                    <groupId>org.apache.felix</groupId>
>>> +                    <artifactId>maven-bundle-plugin</artifactId>
>>> +                    <executions>
>>> +                        <execution>
>>> +                            <id>bundle-manifest</id>
>>> +                            <phase>process-classes</phase>
>>> +                            <goals>
>>> +                                <goal>manifest</goal>
>>> +                            </goals>
>>> +                        </execution>
>>> +                    </executions>
>>> +                </plugin>
>>>             </plugins>
>>>         </pluginManagement>
>>>     </build>
>>>
>>
>

Re: include OSGi bundle metadata?

Posted by James Carman <ja...@carmanconsulting.com>.
It's fairly straightforward to include this.  We added to the Apache
Commons parent pom.xml.

On Fri, May 16, 2008 at 11:17 AM, Igor Vaynberg <ig...@gmail.com> wrote:
> fine by me. i assume the plugin will export every package?
>
> -igor
>
>
> On Fri, May 16, 2008 at 8:04 AM, Gerolf Seitz <ge...@gmail.com> wrote:
>> hey,
>>
>> I was wondering whether we should follow the recent trend and include
>> OSGi metadata with our releases?
>> we could do this unobtrusively with the org.apache.felix:maven-bundle-plugin
>> plugin.
>> see the patch at the end of this mail.
>>
>> wdyt?
>>
>>  Gerolf
>>
>>
>>
>>
>> Index: pom.xml
>> ===================================================================
>> --- pom.xml    (revision 650770)
>> +++ pom.xml    (working copy)
>> @@ -545,6 +545,11 @@
>>                     </execution>
>>                 </executions>
>>             </plugin>
>> +            <plugin>
>> +                <groupId>org.apache.felix</groupId>
>> +                <artifactId>maven-bundle-plugin</artifactId>
>> +                <inherited>true</inherited>
>> +            </plugin>
>>         </plugins>
>>
>>         <pluginManagement>
>> @@ -615,6 +620,7 @@
>>
>> <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
>>
>> <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
>>                             </manifest>
>> +
>> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
>>                             <manifestEntries>
>>                             </manifestEntries>
>>                         </archive>
>> @@ -694,6 +700,19 @@
>>                     </executions>
>>                     <inherited>true</inherited>
>>                 </plugin>
>> +                <plugin>
>> +                    <groupId>org.apache.felix</groupId>
>> +                    <artifactId>maven-bundle-plugin</artifactId>
>> +                    <executions>
>> +                        <execution>
>> +                            <id>bundle-manifest</id>
>> +                            <phase>process-classes</phase>
>> +                            <goals>
>> +                                <goal>manifest</goal>
>> +                            </goals>
>> +                        </execution>
>> +                    </executions>
>> +                </plugin>
>>             </plugins>
>>         </pluginManagement>
>>     </build>
>>
>

Re: include OSGi bundle metadata?

Posted by Igor Vaynberg <ig...@gmail.com>.
fine by me. i assume the plugin will export every package?

-igor


On Fri, May 16, 2008 at 8:04 AM, Gerolf Seitz <ge...@gmail.com> wrote:
> hey,
>
> I was wondering whether we should follow the recent trend and include
> OSGi metadata with our releases?
> we could do this unobtrusively with the org.apache.felix:maven-bundle-plugin
> plugin.
> see the patch at the end of this mail.
>
> wdyt?
>
>  Gerolf
>
>
>
>
> Index: pom.xml
> ===================================================================
> --- pom.xml    (revision 650770)
> +++ pom.xml    (working copy)
> @@ -545,6 +545,11 @@
>                     </execution>
>                 </executions>
>             </plugin>
> +            <plugin>
> +                <groupId>org.apache.felix</groupId>
> +                <artifactId>maven-bundle-plugin</artifactId>
> +                <inherited>true</inherited>
> +            </plugin>
>         </plugins>
>
>         <pluginManagement>
> @@ -615,6 +620,7 @@
>
> <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
>
> <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
>                             </manifest>
> +
> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
>                             <manifestEntries>
>                             </manifestEntries>
>                         </archive>
> @@ -694,6 +700,19 @@
>                     </executions>
>                     <inherited>true</inherited>
>                 </plugin>
> +                <plugin>
> +                    <groupId>org.apache.felix</groupId>
> +                    <artifactId>maven-bundle-plugin</artifactId>
> +                    <executions>
> +                        <execution>
> +                            <id>bundle-manifest</id>
> +                            <phase>process-classes</phase>
> +                            <goals>
> +                                <goal>manifest</goal>
> +                            </goals>
> +                        </execution>
> +                    </executions>
> +                </plugin>
>             </plugins>
>         </pluginManagement>
>     </build>
>

Re: include OSGi bundle metadata?

Posted by Igor Vaynberg <ig...@gmail.com>.
+1 Thanks Stuart

-igor

On Sat, May 17, 2008 at 5:26 AM, Gerolf Seitz <ge...@gmail.com> wrote:
> Hi Stuart,
> thank you very much. it works like a charm ;)
>
> i will attach the patch to WICKET-1641, just that we have it on file.
>
> Cheers,
>  Gerolf
>
> On Sat, May 17, 2008 at 8:04 AM, Stuart McCulloch <
> stuart.mcculloch@jayway.net> wrote:
>
>> On 17/05/2008, Gerolf Seitz <ge...@gmail.com> wrote:
>>
>>> yes, trunk for 1.4.x
>>> appreciate your help with this...
>>
>>
>> Hi Gerolf,
>>
>> the following patch should work - I bumped the maven-jar-plugin to
>> v2.2 because that version has the "useDefaultManifestFile" switch
>> that will use the manifest created by the bundleplugin, but won't fail
>> when the manifest file is missing (as happens in the parent pom)
>>
>> I also moved the "test-jar" execution to pluginManagement, like the
>> rest of the plugins and switched off "useDefaultManifestFile" just for
>> this execution, so it doesn't accidentally pick up the OSGi manifest
>> when jar'ing up the tests
>>
>> Note: by default, the manifest goal will export+import all packages
>> found in each project, and import any packages that are used but
>> not included in the jar.
>>
>> because this can lead to large sets of import constraints, I decided
>> to limit the explicit set of imports to "org.apache.wicket..." for now
>> and add a "Dynamic-ImportPackage: *" setting which will defer any
>> other import resolution to runtime (ie. on-demand).
>>
>> (this saves users from having to hunt around for OSGi bundles of
>> other dependencies, that they may never need because they don't
>> actually call that code)
>>
>> I also turned off the calculation of "uses" constraints because this
>> also adds a lot of verbiage to the manifest that you probably don't
>> need right now.
>>
>> I was able to successfully build the trunk with this patch and also
>> made sure the jars could be loaded into various OSGi frameworks,
>> although I haven't got time to actually try using them in a full-blown
>> OSGi web-application
>>
>> HTH
>>
>> ###########################################################################
>> Index: wicket/pom.xml
>> ===================================================================
>> --- wicket/pom.xml    (revision 657291)
>> +++ wicket/pom.xml    (working copy)
>> @@ -62,16 +62,6 @@
>>
>> <licenseLocation>${basedir}/../../../common/lib/clover.license</licenseLocation>
>>                  </configuration>
>>              </plugin>
>> -            <plugin>
>> -                <artifactId>maven-jar-plugin</artifactId>
>> -                <executions>
>> -                    <execution>
>> -                        <goals>
>> -                            <goal>test-jar</goal>
>> -                        </goals>
>> -                    </execution>
>> -                </executions>
>> -            </plugin>
>>          </plugins>
>>      </build>
>>  </project>
>> Index: pom.xml
>> ===================================================================
>> --- pom.xml    (revision 657291)
>> +++ pom.xml    (working copy)
>> @@ -545,15 +545,15 @@
>>                  <inherited>true</inherited>
>>              </plugin>
>>              <plugin>
>> +                <groupId>org.apache.maven.plugins</groupId>
>>                  <artifactId>maven-jar-plugin</artifactId>
>> -                <executions>
>> -                    <execution>
>> -                        <goals>
>> -                            <goal>test-jar</goal>
>> -                        </goals>
>> -                    </execution>
>> -                </executions>
>> +                <inherited>true</inherited>
>>              </plugin>
>> +            <plugin>
>> +                <groupId>org.apache.felix</groupId>
>> +                <artifactId>maven-bundle-plugin</artifactId>
>> +                <inherited>true</inherited>
>> +            </plugin>
>>          </plugins>
>>
>>          <pluginManagement>
>> @@ -616,8 +616,9 @@
>>                  <plugin>
>>                      <groupId>org.apache.maven.plugins</groupId>
>>                      <artifactId>maven-jar-plugin</artifactId>
>> -                    <version>2.1</version>
>> +                    <version>2.2</version>
>>                      <configuration>
>> +
>> <useDefaultManifestFile>true</useDefaultManifestFile>
>>                          <archive>
>>                              <index>true</index>
>>                              <manifest>
>> @@ -628,6 +629,16 @@
>>                              </manifestEntries>
>>                          </archive>
>>                      </configuration>
>> +                    <executions>
>> +                        <execution>
>> +                            <goals>
>> +                                <goal>test-jar</goal>
>> +                            </goals>
>> +                            <configuration>
>> +
>> <useDefaultManifestFile>false</useDefaultManifestFile>
>> +                            </configuration>
>> +                        </execution>
>> +                    </executions>
>>                  </plugin>
>>                  <plugin>
>>                      <groupId>org.apache.maven.plugins</groupId>
>> @@ -703,6 +714,27 @@
>>                      </executions>
>>                      <inherited>true</inherited>
>>                  </plugin>
>> +                <plugin>
>> +                    <groupId>org.apache.felix</groupId>
>> +                    <artifactId>maven-bundle-plugin</artifactId>
>> +                    <version>1.4.1</version>
>> +                    <executions>
>> +                        <execution>
>> +                            <id>bundle-manifest</id>
>> +                            <phase>process-classes</phase>
>> +                            <goals>
>> +                                <goal>manifest</goal>
>> +                            </goals>
>> +                            <configuration>
>> +                                <instructions>
>> +
>> <Import-Package>org.apache.wicket*</Import-Package>
>> +
>> <Dynamic-ImportPackage>*</Dynamic-ImportPackage>
>> +                                    <_nouses>true</_nouses>
>> +                                </instructions>
>> +                            </configuration>
>> +                        </execution>
>> +                    </executions>
>> +                </plugin>
>>              </plugins>
>>          </pluginManagement>
>>      </build>
>> ###########################################################################
>>
>>
>>
>

Re: include OSGi bundle metadata?

Posted by Gerolf Seitz <ge...@gmail.com>.
Hi Stuart,
thank you very much. it works like a charm ;)

i will attach the patch to WICKET-1641, just that we have it on file.

Cheers,
  Gerolf

On Sat, May 17, 2008 at 8:04 AM, Stuart McCulloch <
stuart.mcculloch@jayway.net> wrote:

> On 17/05/2008, Gerolf Seitz <ge...@gmail.com> wrote:
>
>> yes, trunk for 1.4.x
>> appreciate your help with this...
>
>
> Hi Gerolf,
>
> the following patch should work - I bumped the maven-jar-plugin to
> v2.2 because that version has the "useDefaultManifestFile" switch
> that will use the manifest created by the bundleplugin, but won't fail
> when the manifest file is missing (as happens in the parent pom)
>
> I also moved the "test-jar" execution to pluginManagement, like the
> rest of the plugins and switched off "useDefaultManifestFile" just for
> this execution, so it doesn't accidentally pick up the OSGi manifest
> when jar'ing up the tests
>
> Note: by default, the manifest goal will export+import all packages
> found in each project, and import any packages that are used but
> not included in the jar.
>
> because this can lead to large sets of import constraints, I decided
> to limit the explicit set of imports to "org.apache.wicket..." for now
> and add a "Dynamic-ImportPackage: *" setting which will defer any
> other import resolution to runtime (ie. on-demand).
>
> (this saves users from having to hunt around for OSGi bundles of
> other dependencies, that they may never need because they don't
> actually call that code)
>
> I also turned off the calculation of "uses" constraints because this
> also adds a lot of verbiage to the manifest that you probably don't
> need right now.
>
> I was able to successfully build the trunk with this patch and also
> made sure the jars could be loaded into various OSGi frameworks,
> although I haven't got time to actually try using them in a full-blown
> OSGi web-application
>
> HTH
>
> ###########################################################################
> Index: wicket/pom.xml
> ===================================================================
> --- wicket/pom.xml    (revision 657291)
> +++ wicket/pom.xml    (working copy)
> @@ -62,16 +62,6 @@
>
> <licenseLocation>${basedir}/../../../common/lib/clover.license</licenseLocation>
>                  </configuration>
>              </plugin>
> -            <plugin>
> -                <artifactId>maven-jar-plugin</artifactId>
> -                <executions>
> -                    <execution>
> -                        <goals>
> -                            <goal>test-jar</goal>
> -                        </goals>
> -                    </execution>
> -                </executions>
> -            </plugin>
>          </plugins>
>      </build>
>  </project>
> Index: pom.xml
> ===================================================================
> --- pom.xml    (revision 657291)
> +++ pom.xml    (working copy)
> @@ -545,15 +545,15 @@
>                  <inherited>true</inherited>
>              </plugin>
>              <plugin>
> +                <groupId>org.apache.maven.plugins</groupId>
>                  <artifactId>maven-jar-plugin</artifactId>
> -                <executions>
> -                    <execution>
> -                        <goals>
> -                            <goal>test-jar</goal>
> -                        </goals>
> -                    </execution>
> -                </executions>
> +                <inherited>true</inherited>
>              </plugin>
> +            <plugin>
> +                <groupId>org.apache.felix</groupId>
> +                <artifactId>maven-bundle-plugin</artifactId>
> +                <inherited>true</inherited>
> +            </plugin>
>          </plugins>
>
>          <pluginManagement>
> @@ -616,8 +616,9 @@
>                  <plugin>
>                      <groupId>org.apache.maven.plugins</groupId>
>                      <artifactId>maven-jar-plugin</artifactId>
> -                    <version>2.1</version>
> +                    <version>2.2</version>
>                      <configuration>
> +
> <useDefaultManifestFile>true</useDefaultManifestFile>
>                          <archive>
>                              <index>true</index>
>                              <manifest>
> @@ -628,6 +629,16 @@
>                              </manifestEntries>
>                          </archive>
>                      </configuration>
> +                    <executions>
> +                        <execution>
> +                            <goals>
> +                                <goal>test-jar</goal>
> +                            </goals>
> +                            <configuration>
> +
> <useDefaultManifestFile>false</useDefaultManifestFile>
> +                            </configuration>
> +                        </execution>
> +                    </executions>
>                  </plugin>
>                  <plugin>
>                      <groupId>org.apache.maven.plugins</groupId>
> @@ -703,6 +714,27 @@
>                      </executions>
>                      <inherited>true</inherited>
>                  </plugin>
> +                <plugin>
> +                    <groupId>org.apache.felix</groupId>
> +                    <artifactId>maven-bundle-plugin</artifactId>
> +                    <version>1.4.1</version>
> +                    <executions>
> +                        <execution>
> +                            <id>bundle-manifest</id>
> +                            <phase>process-classes</phase>
> +                            <goals>
> +                                <goal>manifest</goal>
> +                            </goals>
> +                            <configuration>
> +                                <instructions>
> +
> <Import-Package>org.apache.wicket*</Import-Package>
> +
> <Dynamic-ImportPackage>*</Dynamic-ImportPackage>
> +                                    <_nouses>true</_nouses>
> +                                </instructions>
> +                            </configuration>
> +                        </execution>
> +                    </executions>
> +                </plugin>
>              </plugins>
>          </pluginManagement>
>      </build>
> ###########################################################################
>
>
>

Re: include OSGi bundle metadata?

Posted by Stuart McCulloch <st...@jayway.net>.
On 17/05/2008, Gerolf Seitz <ge...@gmail.com> wrote:
>
> yes, trunk for 1.4.x
> appreciate your help with this...


Hi Gerolf,

the following patch should work - I bumped the maven-jar-plugin to
v2.2 because that version has the "useDefaultManifestFile" switch
that will use the manifest created by the bundleplugin, but won't fail
when the manifest file is missing (as happens in the parent pom)

I also moved the "test-jar" execution to pluginManagement, like the
rest of the plugins and switched off "useDefaultManifestFile" just for
this execution, so it doesn't accidentally pick up the OSGi manifest
when jar'ing up the tests

Note: by default, the manifest goal will export+import all packages
found in each project, and import any packages that are used but
not included in the jar.

because this can lead to large sets of import constraints, I decided
to limit the explicit set of imports to "org.apache.wicket..." for now
and add a "Dynamic-ImportPackage: *" setting which will defer any
other import resolution to runtime (ie. on-demand).

(this saves users from having to hunt around for OSGi bundles of
other dependencies, that they may never need because they don't
actually call that code)

I also turned off the calculation of "uses" constraints because this
also adds a lot of verbiage to the manifest that you probably don't
need right now.

I was able to successfully build the trunk with this patch and also
made sure the jars could be loaded into various OSGi frameworks,
although I haven't got time to actually try using them in a full-blown
OSGi web-application

HTH

###########################################################################
Index: wicket/pom.xml
===================================================================
--- wicket/pom.xml    (revision 657291)
+++ wicket/pom.xml    (working copy)
@@ -62,16 +62,6 @@

<licenseLocation>${basedir}/../../../common/lib/clover.license</licenseLocation>
                 </configuration>
             </plugin>
-            <plugin>
-                <artifactId>maven-jar-plugin</artifactId>
-                <executions>
-                    <execution>
-                        <goals>
-                            <goal>test-jar</goal>
-                        </goals>
-                    </execution>
-                </executions>
-            </plugin>
         </plugins>
     </build>
 </project>
Index: pom.xml
===================================================================
--- pom.xml    (revision 657291)
+++ pom.xml    (working copy)
@@ -545,15 +545,15 @@
                 <inherited>true</inherited>
             </plugin>
             <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
-                <executions>
-                    <execution>
-                        <goals>
-                            <goal>test-jar</goal>
-                        </goals>
-                    </execution>
-                </executions>
+                <inherited>true</inherited>
             </plugin>
+            <plugin>
+                <groupId>org.apache.felix</groupId>
+                <artifactId>maven-bundle-plugin</artifactId>
+                <inherited>true</inherited>
+            </plugin>
         </plugins>

         <pluginManagement>
@@ -616,8 +616,9 @@
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-jar-plugin</artifactId>
-                    <version>2.1</version>
+                    <version>2.2</version>
                     <configuration>
+
<useDefaultManifestFile>true</useDefaultManifestFile>
                         <archive>
                             <index>true</index>
                             <manifest>
@@ -628,6 +629,16 @@
                             </manifestEntries>
                         </archive>
                     </configuration>
+                    <executions>
+                        <execution>
+                            <goals>
+                                <goal>test-jar</goal>
+                            </goals>
+                            <configuration>
+
<useDefaultManifestFile>false</useDefaultManifestFile>
+                            </configuration>
+                        </execution>
+                    </executions>
                 </plugin>
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
@@ -703,6 +714,27 @@
                     </executions>
                     <inherited>true</inherited>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.felix</groupId>
+                    <artifactId>maven-bundle-plugin</artifactId>
+                    <version>1.4.1</version>
+                    <executions>
+                        <execution>
+                            <id>bundle-manifest</id>
+                            <phase>process-classes</phase>
+                            <goals>
+                                <goal>manifest</goal>
+                            </goals>
+                            <configuration>
+                                <instructions>
+
<Import-Package>org.apache.wicket*</Import-Package>
+
<Dynamic-ImportPackage>*</Dynamic-ImportPackage>
+                                    <_nouses>true</_nouses>
+                                </instructions>
+                            </configuration>
+                        </execution>
+                    </executions>
+                </plugin>
             </plugins>
         </pluginManagement>
     </build>
###########################################################################

Re: include OSGi bundle metadata?

Posted by Gerolf Seitz <ge...@gmail.com>.
yes, trunk for 1.4.x
appreciate your help with this...

cheers,
  Gerolf

On Fri, May 16, 2008 at 8:00 PM, Stuart McCulloch <
stuart.mcculloch@jayway.net> wrote:

> 2008/5/17 Gerolf Seitz <ge...@gmail.com>:
>
> > ah, good to know. thanks.
> > unfortunately, it doesn't work with the packaging type "pom",
> > because there is no compile phase for this packaging type.
> >
>
> yes - it's more for actual artifact types like war rather than
> pom packaging, normally you don't want it to do anything
> for module poms
>
> btw, are you applying the patch to the current wicket trunk?
> if so I'll check it out tomorrow and see what's going wrong
> (it's 2am here in KL and my wife wants to get some sleep)
>
> Gerolf
> >
> > On Fri, May 16, 2008 at 7:44 PM, Stuart McCulloch <
> > stuart.mcculloch@jayway.net> wrote:
> >
> > > 2008/5/17 Gerolf Seitz <ge...@gmail.com>:
> > >
> > > > right, i only tried "mvn install" on a particular project ;)
> > > >
> > > > the problem is that maven-bundle-plugin doesn't generate a manifest,
> > > > because the parent pom has an unsupported value for <packaging>,
> > > > (only jar and bundle are supported).
> > > >
> > >
> > > FYI, you can enable other packaging types using:
> > >
> > >  <configuration>
> > >    <supportedProjectTypes>
> > >      <param>jar</param>
> > >      <param>bundle</param>
> > >      <param>war</param>
> > >      <!-- etc -->
> > >    </supportedProjectTypes>
> > >  </configuration>
> > >
> > > more options are covered in the online docs:
> > >
> > >   http://felix.apache.org/site/maven-bundle-plugin-bnd.html
> > >
> > > it should be possible to set things up to avoid having to add
> > > the plugin manually to every sub-project (as that's a real pain)
> > > - it's one of the reasons we added this setting
> > >
> > > if you need any help just reply to this thread, or send a note
> > > to the Felix mailing list with any relevant info / maven logs
> > >
> > > so i guess we'll have to include the plugin manually for every
> submodule.
> > > >
> > > > or is it possible to tell the parent pom to only include the
> > > bundle-plugin
> > > > for submodules?
> > > >
> > > >  Gerolf
> > > >
> > > > On Fri, May 16, 2008 at 5:33 PM, Frank van Lankvelt <
> > > > f.vanlankvelt@onehippo.com> wrote:
> > > >
> > > > > Could you help out with applying this patch?  Simply applying it to
> > the
> > > > > parent pom breaks my "mvn install".  Do I need to change the
> > packaging
> > > > > in the sub-projects to "bundle"?
> > > > >
> > > > > thanks, Frank
> > > > >
> > > > > On Fri, 2008-05-16 at 17:04 +0200, Gerolf Seitz wrote:
> > > > > > hey,
> > > > > >
> > > > > > I was wondering whether we should follow the recent trend and
> > include
> > > > > > OSGi metadata with our releases?
> > > > > > we could do this unobtrusively with the
> > > > > org.apache.felix:maven-bundle-plugin
> > > > > > plugin.
> > > > > > see the patch at the end of this mail.
> > > > > >
> > > > > > wdyt?
> > > > > >
> > > > > >  Gerolf
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > Index: pom.xml
> > > > > >
> ===================================================================
> > > > > > --- pom.xml    (revision 650770)
> > > > > > +++ pom.xml    (working copy)
> > > > > > @@ -545,6 +545,11 @@
> > > > > >                      </execution>
> > > > > >                  </executions>
> > > > > >              </plugin>
> > > > > > +            <plugin>
> > > > > > +                <groupId>org.apache.felix</groupId>
> > > > > > +                <artifactId>maven-bundle-plugin</artifactId>
> > > > > > +                <inherited>true</inherited>
> > > > > > +            </plugin>
> > > > > >          </plugins>
> > > > > >
> > > > > >          <pluginManagement>
> > > > > > @@ -615,6 +620,7 @@
> > > > > >
> > > > > >
> > <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
> > > > > >
> > > > > >
> > > <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
> > > > > >                              </manifest>
> > > > > > +
> > > > > >
> > > > >
> > > >
> > >
> >
> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
> > > > > >                              <manifestEntries>
> > > > > >                              </manifestEntries>
> > > > > >                          </archive>
> > > > > > @@ -694,6 +700,19 @@
> > > > > >                      </executions>
> > > > > >                      <inherited>true</inherited>
> > > > > >                  </plugin>
> > > > > > +                <plugin>
> > > > > > +                    <groupId>org.apache.felix</groupId>
> > > > > > +                    <artifactId>maven-bundle-plugin</artifactId>
> > > > > > +                    <executions>
> > > > > > +                        <execution>
> > > > > > +                            <id>bundle-manifest</id>
> > > > > > +                            <phase>process-classes</phase>
> > > > > > +                            <goals>
> > > > > > +                                <goal>manifest</goal>
> > > > > > +                            </goals>
> > > > > > +                        </execution>
> > > > > > +                    </executions>
> > > > > > +                </plugin>
> > > > > >              </plugins>
> > > > > >          </pluginManagement>
> > > > > >      </build>
> > > > > --
> > > > > -------------------------------------------------------------
> > > > > Amsterdam - Hippo B.V. Oosteinde 11 1017 WT Amsterdam
> > +31(0)20-5224466
> > > > > San Francisco - Hippo USA Inc. 101 H Street, suite Q Petaluma CA
> > > > > 94952-3329 +1 (707) 773-4646
> > > > > -------------------------------------------------------------
> > > > >
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Cheers, Stuart
> > >
> >
>
>
>
> --
> Cheers, Stuart
>

Re: include OSGi bundle metadata?

Posted by Stuart McCulloch <st...@jayway.net>.
2008/5/17 Gerolf Seitz <ge...@gmail.com>:

> ah, good to know. thanks.
> unfortunately, it doesn't work with the packaging type "pom",
> because there is no compile phase for this packaging type.
>

yes - it's more for actual artifact types like war rather than
pom packaging, normally you don't want it to do anything
for module poms

btw, are you applying the patch to the current wicket trunk?
if so I'll check it out tomorrow and see what's going wrong
(it's 2am here in KL and my wife wants to get some sleep)

Gerolf
>
> On Fri, May 16, 2008 at 7:44 PM, Stuart McCulloch <
> stuart.mcculloch@jayway.net> wrote:
>
> > 2008/5/17 Gerolf Seitz <ge...@gmail.com>:
> >
> > > right, i only tried "mvn install" on a particular project ;)
> > >
> > > the problem is that maven-bundle-plugin doesn't generate a manifest,
> > > because the parent pom has an unsupported value for <packaging>,
> > > (only jar and bundle are supported).
> > >
> >
> > FYI, you can enable other packaging types using:
> >
> >  <configuration>
> >    <supportedProjectTypes>
> >      <param>jar</param>
> >      <param>bundle</param>
> >      <param>war</param>
> >      <!-- etc -->
> >    </supportedProjectTypes>
> >  </configuration>
> >
> > more options are covered in the online docs:
> >
> >   http://felix.apache.org/site/maven-bundle-plugin-bnd.html
> >
> > it should be possible to set things up to avoid having to add
> > the plugin manually to every sub-project (as that's a real pain)
> > - it's one of the reasons we added this setting
> >
> > if you need any help just reply to this thread, or send a note
> > to the Felix mailing list with any relevant info / maven logs
> >
> > so i guess we'll have to include the plugin manually for every submodule.
> > >
> > > or is it possible to tell the parent pom to only include the
> > bundle-plugin
> > > for submodules?
> > >
> > >  Gerolf
> > >
> > > On Fri, May 16, 2008 at 5:33 PM, Frank van Lankvelt <
> > > f.vanlankvelt@onehippo.com> wrote:
> > >
> > > > Could you help out with applying this patch?  Simply applying it to
> the
> > > > parent pom breaks my "mvn install".  Do I need to change the
> packaging
> > > > in the sub-projects to "bundle"?
> > > >
> > > > thanks, Frank
> > > >
> > > > On Fri, 2008-05-16 at 17:04 +0200, Gerolf Seitz wrote:
> > > > > hey,
> > > > >
> > > > > I was wondering whether we should follow the recent trend and
> include
> > > > > OSGi metadata with our releases?
> > > > > we could do this unobtrusively with the
> > > > org.apache.felix:maven-bundle-plugin
> > > > > plugin.
> > > > > see the patch at the end of this mail.
> > > > >
> > > > > wdyt?
> > > > >
> > > > >  Gerolf
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > Index: pom.xml
> > > > > ===================================================================
> > > > > --- pom.xml    (revision 650770)
> > > > > +++ pom.xml    (working copy)
> > > > > @@ -545,6 +545,11 @@
> > > > >                      </execution>
> > > > >                  </executions>
> > > > >              </plugin>
> > > > > +            <plugin>
> > > > > +                <groupId>org.apache.felix</groupId>
> > > > > +                <artifactId>maven-bundle-plugin</artifactId>
> > > > > +                <inherited>true</inherited>
> > > > > +            </plugin>
> > > > >          </plugins>
> > > > >
> > > > >          <pluginManagement>
> > > > > @@ -615,6 +620,7 @@
> > > > >
> > > > >
> <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
> > > > >
> > > > >
> > <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
> > > > >                              </manifest>
> > > > > +
> > > > >
> > > >
> > >
> >
> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
> > > > >                              <manifestEntries>
> > > > >                              </manifestEntries>
> > > > >                          </archive>
> > > > > @@ -694,6 +700,19 @@
> > > > >                      </executions>
> > > > >                      <inherited>true</inherited>
> > > > >                  </plugin>
> > > > > +                <plugin>
> > > > > +                    <groupId>org.apache.felix</groupId>
> > > > > +                    <artifactId>maven-bundle-plugin</artifactId>
> > > > > +                    <executions>
> > > > > +                        <execution>
> > > > > +                            <id>bundle-manifest</id>
> > > > > +                            <phase>process-classes</phase>
> > > > > +                            <goals>
> > > > > +                                <goal>manifest</goal>
> > > > > +                            </goals>
> > > > > +                        </execution>
> > > > > +                    </executions>
> > > > > +                </plugin>
> > > > >              </plugins>
> > > > >          </pluginManagement>
> > > > >      </build>
> > > > --
> > > > -------------------------------------------------------------
> > > > Amsterdam - Hippo B.V. Oosteinde 11 1017 WT Amsterdam
> +31(0)20-5224466
> > > > San Francisco - Hippo USA Inc. 101 H Street, suite Q Petaluma CA
> > > > 94952-3329 +1 (707) 773-4646
> > > > -------------------------------------------------------------
> > > >
> > > >
> > >
> >
> >
> >
> > --
> > Cheers, Stuart
> >
>



-- 
Cheers, Stuart

Re: include OSGi bundle metadata?

Posted by Gerolf Seitz <ge...@gmail.com>.
ah, good to know. thanks.
unfortunately, it doesn't work with the packaging type "pom",
because there is no compile phase for this packaging type.

  Gerolf

On Fri, May 16, 2008 at 7:44 PM, Stuart McCulloch <
stuart.mcculloch@jayway.net> wrote:

> 2008/5/17 Gerolf Seitz <ge...@gmail.com>:
>
> > right, i only tried "mvn install" on a particular project ;)
> >
> > the problem is that maven-bundle-plugin doesn't generate a manifest,
> > because the parent pom has an unsupported value for <packaging>,
> > (only jar and bundle are supported).
> >
>
> FYI, you can enable other packaging types using:
>
>  <configuration>
>    <supportedProjectTypes>
>      <param>jar</param>
>      <param>bundle</param>
>      <param>war</param>
>      <!-- etc -->
>    </supportedProjectTypes>
>  </configuration>
>
> more options are covered in the online docs:
>
>   http://felix.apache.org/site/maven-bundle-plugin-bnd.html
>
> it should be possible to set things up to avoid having to add
> the plugin manually to every sub-project (as that's a real pain)
> - it's one of the reasons we added this setting
>
> if you need any help just reply to this thread, or send a note
> to the Felix mailing list with any relevant info / maven logs
>
> so i guess we'll have to include the plugin manually for every submodule.
> >
> > or is it possible to tell the parent pom to only include the
> bundle-plugin
> > for submodules?
> >
> >  Gerolf
> >
> > On Fri, May 16, 2008 at 5:33 PM, Frank van Lankvelt <
> > f.vanlankvelt@onehippo.com> wrote:
> >
> > > Could you help out with applying this patch?  Simply applying it to the
> > > parent pom breaks my "mvn install".  Do I need to change the packaging
> > > in the sub-projects to "bundle"?
> > >
> > > thanks, Frank
> > >
> > > On Fri, 2008-05-16 at 17:04 +0200, Gerolf Seitz wrote:
> > > > hey,
> > > >
> > > > I was wondering whether we should follow the recent trend and include
> > > > OSGi metadata with our releases?
> > > > we could do this unobtrusively with the
> > > org.apache.felix:maven-bundle-plugin
> > > > plugin.
> > > > see the patch at the end of this mail.
> > > >
> > > > wdyt?
> > > >
> > > >  Gerolf
> > > >
> > > >
> > > >
> > > >
> > > > Index: pom.xml
> > > > ===================================================================
> > > > --- pom.xml    (revision 650770)
> > > > +++ pom.xml    (working copy)
> > > > @@ -545,6 +545,11 @@
> > > >                      </execution>
> > > >                  </executions>
> > > >              </plugin>
> > > > +            <plugin>
> > > > +                <groupId>org.apache.felix</groupId>
> > > > +                <artifactId>maven-bundle-plugin</artifactId>
> > > > +                <inherited>true</inherited>
> > > > +            </plugin>
> > > >          </plugins>
> > > >
> > > >          <pluginManagement>
> > > > @@ -615,6 +620,7 @@
> > > >
> > > > <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
> > > >
> > > >
> <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
> > > >                              </manifest>
> > > > +
> > > >
> > >
> >
> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
> > > >                              <manifestEntries>
> > > >                              </manifestEntries>
> > > >                          </archive>
> > > > @@ -694,6 +700,19 @@
> > > >                      </executions>
> > > >                      <inherited>true</inherited>
> > > >                  </plugin>
> > > > +                <plugin>
> > > > +                    <groupId>org.apache.felix</groupId>
> > > > +                    <artifactId>maven-bundle-plugin</artifactId>
> > > > +                    <executions>
> > > > +                        <execution>
> > > > +                            <id>bundle-manifest</id>
> > > > +                            <phase>process-classes</phase>
> > > > +                            <goals>
> > > > +                                <goal>manifest</goal>
> > > > +                            </goals>
> > > > +                        </execution>
> > > > +                    </executions>
> > > > +                </plugin>
> > > >              </plugins>
> > > >          </pluginManagement>
> > > >      </build>
> > > --
> > > -------------------------------------------------------------
> > > Amsterdam - Hippo B.V. Oosteinde 11 1017 WT Amsterdam +31(0)20-5224466
> > > San Francisco - Hippo USA Inc. 101 H Street, suite Q Petaluma CA
> > > 94952-3329 +1 (707) 773-4646
> > > -------------------------------------------------------------
> > >
> > >
> >
>
>
>
> --
> Cheers, Stuart
>

Re: include OSGi bundle metadata?

Posted by Stuart McCulloch <st...@jayway.net>.
2008/5/17 Gerolf Seitz <ge...@gmail.com>:

> right, i only tried "mvn install" on a particular project ;)
>
> the problem is that maven-bundle-plugin doesn't generate a manifest,
> because the parent pom has an unsupported value for <packaging>,
> (only jar and bundle are supported).
>

FYI, you can enable other packaging types using:

  <configuration>
    <supportedProjectTypes>
      <param>jar</param>
      <param>bundle</param>
      <param>war</param>
      <!-- etc -->
    </supportedProjectTypes>
  </configuration>

more options are covered in the online docs:

   http://felix.apache.org/site/maven-bundle-plugin-bnd.html

it should be possible to set things up to avoid having to add
the plugin manually to every sub-project (as that's a real pain)
- it's one of the reasons we added this setting

if you need any help just reply to this thread, or send a note
to the Felix mailing list with any relevant info / maven logs

so i guess we'll have to include the plugin manually for every submodule.
>
> or is it possible to tell the parent pom to only include the bundle-plugin
> for submodules?
>
>  Gerolf
>
> On Fri, May 16, 2008 at 5:33 PM, Frank van Lankvelt <
> f.vanlankvelt@onehippo.com> wrote:
>
> > Could you help out with applying this patch?  Simply applying it to the
> > parent pom breaks my "mvn install".  Do I need to change the packaging
> > in the sub-projects to "bundle"?
> >
> > thanks, Frank
> >
> > On Fri, 2008-05-16 at 17:04 +0200, Gerolf Seitz wrote:
> > > hey,
> > >
> > > I was wondering whether we should follow the recent trend and include
> > > OSGi metadata with our releases?
> > > we could do this unobtrusively with the
> > org.apache.felix:maven-bundle-plugin
> > > plugin.
> > > see the patch at the end of this mail.
> > >
> > > wdyt?
> > >
> > >  Gerolf
> > >
> > >
> > >
> > >
> > > Index: pom.xml
> > > ===================================================================
> > > --- pom.xml    (revision 650770)
> > > +++ pom.xml    (working copy)
> > > @@ -545,6 +545,11 @@
> > >                      </execution>
> > >                  </executions>
> > >              </plugin>
> > > +            <plugin>
> > > +                <groupId>org.apache.felix</groupId>
> > > +                <artifactId>maven-bundle-plugin</artifactId>
> > > +                <inherited>true</inherited>
> > > +            </plugin>
> > >          </plugins>
> > >
> > >          <pluginManagement>
> > > @@ -615,6 +620,7 @@
> > >
> > > <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
> > >
> > > <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
> > >                              </manifest>
> > > +
> > >
> >
> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
> > >                              <manifestEntries>
> > >                              </manifestEntries>
> > >                          </archive>
> > > @@ -694,6 +700,19 @@
> > >                      </executions>
> > >                      <inherited>true</inherited>
> > >                  </plugin>
> > > +                <plugin>
> > > +                    <groupId>org.apache.felix</groupId>
> > > +                    <artifactId>maven-bundle-plugin</artifactId>
> > > +                    <executions>
> > > +                        <execution>
> > > +                            <id>bundle-manifest</id>
> > > +                            <phase>process-classes</phase>
> > > +                            <goals>
> > > +                                <goal>manifest</goal>
> > > +                            </goals>
> > > +                        </execution>
> > > +                    </executions>
> > > +                </plugin>
> > >              </plugins>
> > >          </pluginManagement>
> > >      </build>
> > --
> > -------------------------------------------------------------
> > Amsterdam - Hippo B.V. Oosteinde 11 1017 WT Amsterdam +31(0)20-5224466
> > San Francisco - Hippo USA Inc. 101 H Street, suite Q Petaluma CA
> > 94952-3329 +1 (707) 773-4646
> > -------------------------------------------------------------
> >
> >
>



-- 
Cheers, Stuart

Re: include OSGi bundle metadata?

Posted by Gerolf Seitz <ge...@gmail.com>.
right, i only tried "mvn install" on a particular project ;)

the problem is that maven-bundle-plugin doesn't generate a manifest,
because the parent pom has an unsupported value for <packaging>,
(only jar and bundle are supported).

so i guess we'll have to include the plugin manually for every submodule.

or is it possible to tell the parent pom to only include the bundle-plugin
for submodules?

  Gerolf

On Fri, May 16, 2008 at 5:33 PM, Frank van Lankvelt <
f.vanlankvelt@onehippo.com> wrote:

> Could you help out with applying this patch?  Simply applying it to the
> parent pom breaks my "mvn install".  Do I need to change the packaging
> in the sub-projects to "bundle"?
>
> thanks, Frank
>
> On Fri, 2008-05-16 at 17:04 +0200, Gerolf Seitz wrote:
> > hey,
> >
> > I was wondering whether we should follow the recent trend and include
> > OSGi metadata with our releases?
> > we could do this unobtrusively with the
> org.apache.felix:maven-bundle-plugin
> > plugin.
> > see the patch at the end of this mail.
> >
> > wdyt?
> >
> >  Gerolf
> >
> >
> >
> >
> > Index: pom.xml
> > ===================================================================
> > --- pom.xml    (revision 650770)
> > +++ pom.xml    (working copy)
> > @@ -545,6 +545,11 @@
> >                      </execution>
> >                  </executions>
> >              </plugin>
> > +            <plugin>
> > +                <groupId>org.apache.felix</groupId>
> > +                <artifactId>maven-bundle-plugin</artifactId>
> > +                <inherited>true</inherited>
> > +            </plugin>
> >          </plugins>
> >
> >          <pluginManagement>
> > @@ -615,6 +620,7 @@
> >
> > <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
> >
> > <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
> >                              </manifest>
> > +
> >
> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
> >                              <manifestEntries>
> >                              </manifestEntries>
> >                          </archive>
> > @@ -694,6 +700,19 @@
> >                      </executions>
> >                      <inherited>true</inherited>
> >                  </plugin>
> > +                <plugin>
> > +                    <groupId>org.apache.felix</groupId>
> > +                    <artifactId>maven-bundle-plugin</artifactId>
> > +                    <executions>
> > +                        <execution>
> > +                            <id>bundle-manifest</id>
> > +                            <phase>process-classes</phase>
> > +                            <goals>
> > +                                <goal>manifest</goal>
> > +                            </goals>
> > +                        </execution>
> > +                    </executions>
> > +                </plugin>
> >              </plugins>
> >          </pluginManagement>
> >      </build>
> --
> -------------------------------------------------------------
> Amsterdam - Hippo B.V. Oosteinde 11 1017 WT Amsterdam +31(0)20-5224466
> San Francisco - Hippo USA Inc. 101 H Street, suite Q Petaluma CA
> 94952-3329 +1 (707) 773-4646
> -------------------------------------------------------------
>
>

Re: include OSGi bundle metadata?

Posted by Frank van Lankvelt <f....@onehippo.com>.
Could you help out with applying this patch?  Simply applying it to the
parent pom breaks my "mvn install".  Do I need to change the packaging
in the sub-projects to "bundle"?

thanks, Frank

On Fri, 2008-05-16 at 17:04 +0200, Gerolf Seitz wrote:
> hey,
> 
> I was wondering whether we should follow the recent trend and include
> OSGi metadata with our releases?
> we could do this unobtrusively with the org.apache.felix:maven-bundle-plugin
> plugin.
> see the patch at the end of this mail.
> 
> wdyt?
> 
>  Gerolf
> 
> 
> 
> 
> Index: pom.xml
> ===================================================================
> --- pom.xml    (revision 650770)
> +++ pom.xml    (working copy)
> @@ -545,6 +545,11 @@
>                      </execution>
>                  </executions>
>              </plugin>
> +            <plugin>
> +                <groupId>org.apache.felix</groupId>
> +                <artifactId>maven-bundle-plugin</artifactId>
> +                <inherited>true</inherited>
> +            </plugin>
>          </plugins>
> 
>          <pluginManagement>
> @@ -615,6 +620,7 @@
> 
> <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
> 
> <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
>                              </manifest>
> +
> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
>                              <manifestEntries>
>                              </manifestEntries>
>                          </archive>
> @@ -694,6 +700,19 @@
>                      </executions>
>                      <inherited>true</inherited>
>                  </plugin>
> +                <plugin>
> +                    <groupId>org.apache.felix</groupId>
> +                    <artifactId>maven-bundle-plugin</artifactId>
> +                    <executions>
> +                        <execution>
> +                            <id>bundle-manifest</id>
> +                            <phase>process-classes</phase>
> +                            <goals>
> +                                <goal>manifest</goal>
> +                            </goals>
> +                        </execution>
> +                    </executions>
> +                </plugin>
>              </plugins>
>          </pluginManagement>
>      </build>
-- 
-------------------------------------------------------------
Amsterdam - Hippo B.V. Oosteinde 11 1017 WT Amsterdam +31(0)20-5224466 
San Francisco - Hippo USA Inc. 101 H Street, suite Q Petaluma CA
94952-3329 +1 (707) 773-4646
-------------------------------------------------------------