[GitHub] [apisix-dashboard] starsz commented on a change in pull request #2117: feat: basic support Apache APISIX 2.9

[GitBox <gi...@apache.org>]

starsz commented on a change in pull request #2117:
URL: https://github.com/apache/apisix-dashboard/pull/2117#discussion_r701671271



##########
File path: api/internal/core/entity/entity.go
##########
@@ -133,16 +134,16 @@ type UnHealthy struct {
 }
 
 type Active struct {
-	Type                   string    `json:"type,omitempty"`
-	Timeout                int       `json:"timeout,omitempty"`
-	Concurrency            int       `json:"concurrency,omitempty"`
-	Host                   string    `json:"host,omitempty"`
-	Port                   int       `json:"port,omitempty"`
-	HTTPPath               string    `json:"http_path,omitempty"`
-	HTTPSVerifyCertificate string    `json:"https_verify_certificate,omitempty"`
-	Healthy                Healthy   `json:"healthy,omitempty"`
-	UnHealthy              UnHealthy `json:"unhealthy,omitempty"`
-	ReqHeaders             []string  `json:"req_headers,omitempty"`
+	Type                   string       `json:"type,omitempty"`
+	Timeout                TimeoutValue `json:"timeout,omitempty"`

Review comment:
       Why change this to float32?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org