You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rebenitez1802 (via GitHub)" <gi...@apache.org> on 2026/08/11 20:56:27 UTC
[PR] fix(GridTable): remove unused rowSelection option to silence AG Grid error #200 [superset]
rebenitez1802 opened a new pull request, #43078:
URL: https://github.com/apache/superset/pull/43078
### SUMMARY
Explore's **Results/Samples** data panel and **SQL Lab** result grids render `GridTable`, which set the AG Grid option `rowSelection: 'multiple'`. Since the AG Grid tree-shaking migration (#32334, Feb 2025, moving to the modular v33+ architecture), the global module registry in `ThemedAgGridReact/setupAGGridModules.ts` registers an opt-in subset of modules and **never includes `RowSelectionModule`**. Using a feature whose module isn't registered makes AG Grid log, on every grid mount/re-render (notably after clicking **Stop** on a running Explore query):
```
AG Grid: error #200 … moduleName=RowSelection&reasonOrId=rowSelection
```
Investigation shows the `rowSelection` option is **dead config**:
- No consumer reads selection — no `onSelectionChanged`, no checkbox column, no `getSelectedRows`, and none since it was introduced.
- It was only functional for ~26 days on ag-grid `32.2.1` (batteries-included) before the modular migration silently broke it; it has logged #200 continuously ever since (~1.5 years).
- Cell copy (Ctrl/Cmd+C) is **unaffected** — it relies on `enableCellTextSelection` + the `onCellKeyDown` handler, independent of `rowSelection`.
Rather than register `RowSelectionModule` and migrate to the v33+ object form (which would *newly* introduce a checkbox column and select-all UX that nothing consumes), this PR removes the unused option. That fully silences error #200 (and the deprecated string-form warning) with **zero user-facing change**.
Note: the AG Grid chart plugin (`plugin-chart-ag-grid-table`) also uses the deprecated `rowSelection="multiple"` string, but it registers `AllCommunityModule`, so it does not throw #200 (only a cosmetic deprecation warning). That's out of scope here and can be a follow-up.
Internal ref: sc-112604.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**Before:** console logs `AG Grid: error #200 … moduleName=RowSelection` when the Explore Results/Samples (or SQL Lab) grid renders — e.g. after Stop-ing a running query.
**After:** no #200 error; grids render and cell copy behave identically.
### TESTING INSTRUCTIONS
1. Open Explore on any chart with query results (e.g. Degrees vs Income).
2. Expand the data panel and open the **Results** or **Samples** tab; open DevTools → Console.
3. Click **Update chart**, then **Stop** while the query runs (or let it finish and re-render).
4. Confirm **no** `AG Grid: error #200 … RowSelection` message appears.
5. Repeat in **SQL Lab** (result set and table preview grids).
6. Confirm Ctrl/Cmd+C cell copy still works.
Unit tests: `cd superset-frontend && npm run test -- GridTable`
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(GridTable): remove unused rowSelection option to silence AG Grid error #200 [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43078:
URL: https://github.com/apache/superset/pull/43078#issuecomment-5258762104
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(GridTable): remove unused rowSelection option to silence AG Grid error #200 [superset]
Posted by "rebenitez1802 (via GitHub)" <gi...@apache.org>.
rebenitez1802 merged PR #43078:
URL: https://github.com/apache/superset/pull/43078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(GridTable): remove unused rowSelection option to silence AG Grid error #200 [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43078:
URL: https://github.com/apache/superset/pull/43078#issuecomment-5258942596
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43078?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 66.56%. Comparing base ([`9086bab`](https://app.codecov.io/gh/apache/superset/commit/9086bab2c223f639b6af5e09783bf52f671b3854?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`633bb9f`](https://app.codecov.io/gh/apache/superset/commit/633bb9ffcb1686f3792b635d105d2d29a17415f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #43078 +/- ##
=======================================
Coverage 66.56% 66.56%
=======================================
Files 2866 2866
Lines 162261 162261
Branches 37346 37346
=======================================
Hits 108010 108010
Misses 52185 52185
Partials 2066 2066
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/43078/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/43078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.63% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43078?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(GridTable): remove unused rowSelection option to silence AG Grid error #200 [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43078:
URL: https://github.com/apache/superset/pull/43078#issuecomment-5260325987
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org