You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/08 13:28:39 UTC

[GitHub] [spark] gengliangwang commented on a change in pull request #24318: [SPARK-27407][SQL] File source V2: Invalidate cache data on overwrite/append

gengliangwang commented on a change in pull request #24318: [SPARK-27407][SQL] File source V2: Invalidate cache data on overwrite/append
URL: https://github.com/apache/spark/pull/24318#discussion_r273045206
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetQuerySuite.scala
 ##########
 @@ -70,30 +70,6 @@ class ParquetQuerySuite extends QueryTest with ParquetTest with SharedSQLContext
       TableIdentifier("tmp"), ignoreIfNotExists = true, purge = false)
   }
 
-  test("SPARK-15678: not use cache on overwrite") {
 
 Review comment:
   Delete the original test case for following reasons:
   1. The cache invalidation is for all file sources
   2. The two test cases in ParquetQuerySuite is covered by the new test cases of this PR.
   3. The Parquet data source is not migrated to V2 yet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org