You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/04/28 00:48:16 UTC
Review Request 58830: Updated Suppress / Revive calls to take
multiple roles.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58830/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/allocator/allocator.hpp 6eda1b8619269c1501a935045b18b1deaf845b33
include/mesos/scheduler/scheduler.proto cee0a175fcdcbb8b56d41a5b4b6fd965afd822bd
include/mesos/v1/scheduler/scheduler.proto 00a54eceb435de8e8fea3ccab285f39ed13c6fee
src/master/allocator/mesos/allocator.hpp 57b54b86c43c7731e64d422d285c4b8ca7e27a60
src/master/allocator/mesos/hierarchical.hpp 219f508dacb3b372c12da3f15e07a3bf5f27e6e6
src/master/allocator/mesos/hierarchical.cpp 984a0a4e2671ee7bb2a3515849342f49f2c4e3aa
src/master/master.hpp d537933d0b467a6f9996951c601b31338bb9d034
src/master/master.cpp a0cb505a1300637f42fa8062c57deb1590779dd4
src/messages/messages.proto 6cc06eb0f30cddac0a222215c777dcd7f0db2ff6
src/tests/allocator.hpp 6b71c574e0e4facd1795ef50ee0869c03b87833d
src/tests/hierarchical_allocator_tests.cpp 84bb6f302f6ff6f8a93fa891795df9ef7380629f
Diff: https://reviews.apache.org/r/58830/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 58830: Updated Suppress / Revive calls to take
multiple roles.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58830/#review173301
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On April 27, 2017, 5:48 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58830/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 5:48 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/allocator/allocator.hpp 6eda1b8619269c1501a935045b18b1deaf845b33
> include/mesos/scheduler/scheduler.proto cee0a175fcdcbb8b56d41a5b4b6fd965afd822bd
> include/mesos/v1/scheduler/scheduler.proto 00a54eceb435de8e8fea3ccab285f39ed13c6fee
> src/master/allocator/mesos/allocator.hpp 57b54b86c43c7731e64d422d285c4b8ca7e27a60
> src/master/allocator/mesos/hierarchical.hpp 219f508dacb3b372c12da3f15e07a3bf5f27e6e6
> src/master/allocator/mesos/hierarchical.cpp 984a0a4e2671ee7bb2a3515849342f49f2c4e3aa
> src/master/master.hpp d537933d0b467a6f9996951c601b31338bb9d034
> src/master/master.cpp a0cb505a1300637f42fa8062c57deb1590779dd4
> src/messages/messages.proto 6cc06eb0f30cddac0a222215c777dcd7f0db2ff6
> src/tests/allocator.hpp 6b71c574e0e4facd1795ef50ee0869c03b87833d
> src/tests/hierarchical_allocator_tests.cpp 84bb6f302f6ff6f8a93fa891795df9ef7380629f
>
>
> Diff: https://reviews.apache.org/r/58830/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 58830: Updated Suppress / Revive calls to take
multiple roles.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58830/#review173311
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58828, 58829, 58830]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 28, 2017, 12:48 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58830/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 12:48 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/allocator/allocator.hpp 6eda1b8619269c1501a935045b18b1deaf845b33
> include/mesos/scheduler/scheduler.proto cee0a175fcdcbb8b56d41a5b4b6fd965afd822bd
> include/mesos/v1/scheduler/scheduler.proto 00a54eceb435de8e8fea3ccab285f39ed13c6fee
> src/master/allocator/mesos/allocator.hpp 57b54b86c43c7731e64d422d285c4b8ca7e27a60
> src/master/allocator/mesos/hierarchical.hpp 219f508dacb3b372c12da3f15e07a3bf5f27e6e6
> src/master/allocator/mesos/hierarchical.cpp 984a0a4e2671ee7bb2a3515849342f49f2c4e3aa
> src/master/master.hpp d537933d0b467a6f9996951c601b31338bb9d034
> src/master/master.cpp a0cb505a1300637f42fa8062c57deb1590779dd4
> src/messages/messages.proto 6cc06eb0f30cddac0a222215c777dcd7f0db2ff6
> src/tests/allocator.hpp 6b71c574e0e4facd1795ef50ee0869c03b87833d
> src/tests/hierarchical_allocator_tests.cpp 84bb6f302f6ff6f8a93fa891795df9ef7380629f
>
>
> Diff: https://reviews.apache.org/r/58830/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>