You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/03/23 02:28:17 UTC

[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull request #121: kv history support rotate

tianxiaoliang commented on a change in pull request #121: kv history support rotate
URL: https://github.com/apache/servicecomb-kie/pull/121#discussion_r396185802
 
 

 ##########
 File path: server/service/mongo/kv/kv_dao.go
 ##########
 @@ -183,6 +183,10 @@ func deleteKV(ctx context.Context, kvID, project, domain string) error {
 	} else {
 		openlogging.Info(fmt.Sprintf("delete success,kvID=%s", kvID))
 	}
+	err = history.DeleteHistories(ctx, kvID, project, domain)
 
 Review comment:
   不可删除history，这部分你如何考虑的
   
   因为存在误删，所以后台应当留底

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services