You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/13 14:57:17 UTC
[GitHub] [dubbo] kylixs opened a new pull request #8789: [3.0] Multi instance - multi module and spring support
kylixs opened a new pull request #8789:
URL: https://github.com/apache/dubbo/pull/8789
## What is the purpose of the change
* Extract `ApplicationDeployer` and `ModuleDeployer` from `DubboBootstrap`, support start/destroy module.
* Extract `ModuleConfigManager` from `ConfigManager`
* Remove `DubboBootstrap` ref from `ReferenceConfig` and `ServiceConfig`
* DubboBootstrap.newInstance() is changed to share the default FrameworkModel
* Add spring support for multi module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8789: [3.0] Multi instance - multi module config/deploy and spring support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8789:
URL: https://github.com/apache/dubbo/pull/8789#issuecomment-918343795
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8789](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c1774e) into [3.0](https://codecov.io/gh/apache/dubbo/commit/675aead1e578cc783f58f7ce480b0872d259e2b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (675aead) will **decrease** coverage by `0.18%`.
> The diff coverage is `69.29%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8789/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8789 +/- ##
============================================
- Coverage 63.89% 63.70% -0.19%
Complexity 313 313
============================================
Files 1151 1156 +5
Lines 48381 48643 +262
Branches 7294 7288 -6
============================================
+ Hits 30914 30990 +76
- Misses 14088 14248 +160
- Partials 3379 3405 +26
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../rpc/cluster/router/tag/TagDynamicStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdEeW5hbWljU3RhdGVSb3V0ZXIuamF2YQ==) | `32.67% <ø> (ø)` | |
| [...o/rpc/cluster/router/tag/TagStaticStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdTdGF0aWNTdGF0ZVJvdXRlci5qYXZh) | `59.52% <ø> (ø)` | |
| [...g/apache/dubbo/common/bytecode/ClassGenerator.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYnl0ZWNvZGUvQ2xhc3NHZW5lcmF0b3IuamF2YQ==) | `62.43% <ø> (ø)` | |
| [...figcenter/file/FileSystemDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL2NvbmZpZ2NlbnRlci9maWxlL0ZpbGVTeXN0ZW1EeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../dubbo/config/bootstrap/BootstrapTakeoverMode.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9ib290c3RyYXAvQm9vdHN0cmFwVGFrZW92ZXJNb2RlLmphdmE=) | `100.00% <ø> (ø)` | |
| [.../metadata/ConfigurableMetadataServiceExporter.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9tZXRhZGF0YS9Db25maWd1cmFibGVNZXRhZGF0YVNlcnZpY2VFeHBvcnRlci5qYXZh) | `86.15% <ø> (-0.21%)` | :arrow_down: |
| [...g/apache/dubbo/config/spring/ConfigCenterBean.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvQ29uZmlnQ2VudGVyQmVhbi5qYXZh) | `21.87% <ø> (-2.37%)` | :arrow_down: |
| [.../org/apache/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvUmVmZXJlbmNlQmVhbi5qYXZh) | `94.36% <ø> (ø)` | |
| [...ring/context/event/DubboAnnotationInitedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Fubm90YXRpb25Jbml0ZWRFdmVudC5qYXZh) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...apache/dubbo/container/spring/SpringContainer.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29udGFpbmVyL2R1YmJvLWNvbnRhaW5lci1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbnRhaW5lci9zcHJpbmcvU3ByaW5nQ29udGFpbmVyLmphdmE=) | `72.22% <ø> (ø)` | |
| ... and [163 more](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [675aead...6c1774e](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8789: [3.0] Multi instance - multi module config/deploy and spring support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8789:
URL: https://github.com/apache/dubbo/pull/8789#issuecomment-918343795
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8789](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c1774e) into [3.0](https://codecov.io/gh/apache/dubbo/commit/675aead1e578cc783f58f7ce480b0872d259e2b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (675aead) will **increase** coverage by `0.00%`.
> The diff coverage is `69.31%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8789/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8789 +/- ##
==========================================
Coverage 63.89% 63.90%
Complexity 313 313
==========================================
Files 1151 1156 +5
Lines 48381 48690 +309
Branches 7294 7323 +29
==========================================
+ Hits 30914 31114 +200
- Misses 14088 14181 +93
- Partials 3379 3395 +16
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../rpc/cluster/router/tag/TagDynamicStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdEeW5hbWljU3RhdGVSb3V0ZXIuamF2YQ==) | `32.67% <ø> (ø)` | |
| [...o/rpc/cluster/router/tag/TagStaticStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdTdGF0aWNTdGF0ZVJvdXRlci5qYXZh) | `59.52% <ø> (ø)` | |
| [...g/apache/dubbo/common/bytecode/ClassGenerator.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYnl0ZWNvZGUvQ2xhc3NHZW5lcmF0b3IuamF2YQ==) | `62.43% <ø> (ø)` | |
| [...figcenter/file/FileSystemDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL2NvbmZpZ2NlbnRlci9maWxlL0ZpbGVTeXN0ZW1EeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../dubbo/config/bootstrap/BootstrapTakeoverMode.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9ib290c3RyYXAvQm9vdHN0cmFwVGFrZW92ZXJNb2RlLmphdmE=) | `100.00% <ø> (ø)` | |
| [.../metadata/ConfigurableMetadataServiceExporter.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9tZXRhZGF0YS9Db25maWd1cmFibGVNZXRhZGF0YVNlcnZpY2VFeHBvcnRlci5qYXZh) | `86.15% <ø> (-0.21%)` | :arrow_down: |
| [...g/apache/dubbo/config/spring/ConfigCenterBean.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvQ29uZmlnQ2VudGVyQmVhbi5qYXZh) | `21.87% <ø> (-2.37%)` | :arrow_down: |
| [.../org/apache/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvUmVmZXJlbmNlQmVhbi5qYXZh) | `94.36% <ø> (ø)` | |
| [...ring/context/event/DubboAnnotationInitedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Fubm90YXRpb25Jbml0ZWRFdmVudC5qYXZh) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...apache/dubbo/container/spring/SpringContainer.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29udGFpbmVyL2R1YmJvLWNvbnRhaW5lci1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbnRhaW5lci9zcHJpbmcvU3ByaW5nQ29udGFpbmVyLmphdmE=) | `72.22% <ø> (ø)` | |
| ... and [130 more](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [675aead...6c1774e](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #8789: [3.0] Multi instance - multi module config/deploy and spring support
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #8789:
URL: https://github.com/apache/dubbo/pull/8789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #8789: [3.0] Multi instance - multi module config/deploy and spring support
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8789:
URL: https://github.com/apache/dubbo/pull/8789#issuecomment-918343795
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8789](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83dbde1) into [3.0](https://codecov.io/gh/apache/dubbo/commit/675aead1e578cc783f58f7ce480b0872d259e2b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (675aead) will **decrease** coverage by `0.07%`.
> The diff coverage is `68.78%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8789/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8789 +/- ##
============================================
- Coverage 63.89% 63.82% -0.08%
Complexity 313 313
============================================
Files 1151 1156 +5
Lines 48381 48693 +312
Branches 7294 7323 +29
============================================
+ Hits 30914 31076 +162
- Misses 14088 14217 +129
- Partials 3379 3400 +21
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../rpc/cluster/router/tag/TagDynamicStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdEeW5hbWljU3RhdGVSb3V0ZXIuamF2YQ==) | `32.67% <ø> (ø)` | |
| [...o/rpc/cluster/router/tag/TagStaticStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdTdGF0aWNTdGF0ZVJvdXRlci5qYXZh) | `59.52% <ø> (ø)` | |
| [...g/apache/dubbo/common/bytecode/ClassGenerator.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYnl0ZWNvZGUvQ2xhc3NHZW5lcmF0b3IuamF2YQ==) | `62.43% <ø> (ø)` | |
| [...figcenter/file/FileSystemDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL2NvbmZpZ2NlbnRlci9maWxlL0ZpbGVTeXN0ZW1EeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../dubbo/config/bootstrap/BootstrapTakeoverMode.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9ib290c3RyYXAvQm9vdHN0cmFwVGFrZW92ZXJNb2RlLmphdmE=) | `100.00% <ø> (ø)` | |
| [.../metadata/ConfigurableMetadataServiceExporter.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9tZXRhZGF0YS9Db25maWd1cmFibGVNZXRhZGF0YVNlcnZpY2VFeHBvcnRlci5qYXZh) | `86.15% <ø> (-0.21%)` | :arrow_down: |
| [...g/apache/dubbo/config/spring/ConfigCenterBean.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvQ29uZmlnQ2VudGVyQmVhbi5qYXZh) | `21.87% <ø> (-2.37%)` | :arrow_down: |
| [.../org/apache/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvUmVmZXJlbmNlQmVhbi5qYXZh) | `94.36% <ø> (ø)` | |
| [...ring/context/event/DubboAnnotationInitedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Fubm90YXRpb25Jbml0ZWRFdmVudC5qYXZh) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...apache/dubbo/container/spring/SpringContainer.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29udGFpbmVyL2R1YmJvLWNvbnRhaW5lci1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbnRhaW5lci9zcHJpbmcvU3ByaW5nQ29udGFpbmVyLmphdmE=) | `72.22% <ø> (ø)` | |
| ... and [131 more](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [675aead...83dbde1](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8789: [3.0] Multi instance - multi module config/deploy and spring support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8789:
URL: https://github.com/apache/dubbo/pull/8789#issuecomment-918343795
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8789](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c1774e) into [3.0](https://codecov.io/gh/apache/dubbo/commit/675aead1e578cc783f58f7ce480b0872d259e2b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (675aead) will **decrease** coverage by `0.02%`.
> The diff coverage is `69.31%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8789/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #8789 +/- ##
============================================
- Coverage 63.89% 63.87% -0.03%
Complexity 313 313
============================================
Files 1151 1156 +5
Lines 48381 48690 +309
Branches 7294 7323 +29
============================================
+ Hits 30914 31100 +186
- Misses 14088 14195 +107
- Partials 3379 3395 +16
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../rpc/cluster/router/tag/TagDynamicStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdEeW5hbWljU3RhdGVSb3V0ZXIuamF2YQ==) | `32.67% <ø> (ø)` | |
| [...o/rpc/cluster/router/tag/TagStaticStateRouter.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdTdGF0aWNTdGF0ZVJvdXRlci5qYXZh) | `59.52% <ø> (ø)` | |
| [...g/apache/dubbo/common/bytecode/ClassGenerator.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYnl0ZWNvZGUvQ2xhc3NHZW5lcmF0b3IuamF2YQ==) | `62.43% <ø> (ø)` | |
| [...figcenter/file/FileSystemDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL2NvbmZpZ2NlbnRlci9maWxlL0ZpbGVTeXN0ZW1EeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../dubbo/config/bootstrap/BootstrapTakeoverMode.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9ib290c3RyYXAvQm9vdHN0cmFwVGFrZW92ZXJNb2RlLmphdmE=) | `100.00% <ø> (ø)` | |
| [.../metadata/ConfigurableMetadataServiceExporter.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9tZXRhZGF0YS9Db25maWd1cmFibGVNZXRhZGF0YVNlcnZpY2VFeHBvcnRlci5qYXZh) | `86.15% <ø> (-0.21%)` | :arrow_down: |
| [...g/apache/dubbo/config/spring/ConfigCenterBean.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvQ29uZmlnQ2VudGVyQmVhbi5qYXZh) | `21.87% <ø> (-2.37%)` | :arrow_down: |
| [.../org/apache/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvUmVmZXJlbmNlQmVhbi5qYXZh) | `94.36% <ø> (ø)` | |
| [...ring/context/event/DubboAnnotationInitedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Fubm90YXRpb25Jbml0ZWRFdmVudC5qYXZh) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...apache/dubbo/container/spring/SpringContainer.java](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29udGFpbmVyL2R1YmJvLWNvbnRhaW5lci1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbnRhaW5lci9zcHJpbmcvU3ByaW5nQ29udGFpbmVyLmphdmE=) | `72.22% <ø> (ø)` | |
| ... and [131 more](https://codecov.io/gh/apache/dubbo/pull/8789/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [675aead...6c1774e](https://codecov.io/gh/apache/dubbo/pull/8789?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org