You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "laglangyue (via GitHub)" <gi...@apache.org> on 2023/12/21 13:31:10 UTC
[PR] [Chore] remove unused import [incubator-pekko-http]
laglangyue opened a new pull request, #378:
URL: https://github.com/apache/incubator-pekko-http/pull/378
This PR includes:
such as title,remvoe some not import package
motivations:
I find there are some waning about `unused`
test:
Removed some `unused import`, so I just compiled locally,it will test by CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [Chore] remove unused import [incubator-pekko-http]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #378:
URL: https://github.com/apache/incubator-pekko-http/pull/378#issuecomment-1868198665
> this breaks the scala 2.12 build - please close this
Sorry,I didn't test it carefully on 2.12 before, and I still think some imports are not related to the scala version. I will review this PR again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [Chore] remove unused import [incubator-pekko-http]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #378:
URL: https://github.com/apache/incubator-pekko-http/pull/378#issuecomment-1866256238
I also find a warning about thie,But I think that this may be a false warning.
```shell
[warn] /home/laglang/coding/incubator-pekko-http/parsing/src/main/scala-2/org/apache/pekko/http/ccompat/pre213macro.scala:17:36: Unused import
[warn] import scala.language.experimental.macros
[warn] ^
[warn] /home/laglang/coding/incubator-pekko-http/parsing/src/main/scala-2/org/apache/pekko/http/ccompat/since213macro.scala:17:36: Unused import
[warn] import scala.language.experimental.macros
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Remove unused import [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #378:
URL: https://github.com/apache/incubator-pekko-http/pull/378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [Chore] remove unused import [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #378:
URL: https://github.com/apache/incubator-pekko-http/pull/378#issuecomment-1868119873
this breaks the scala 2.12 build - please close this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org