[GitHub] [iceberg] jfz commented on a diff in pull request #4760: API: Allow extra options in LocationProvider.

[GitBox <gi...@apache.org>]

jfz commented on code in PR #4760:
URL: https://github.com/apache/iceberg/pull/4760#discussion_r873087151


##########
api/src/main/java/org/apache/iceberg/io/LocationProvider.java:
##########
@@ -37,6 +38,17 @@ public interface LocationProvider extends Serializable {
    */
   String newDataLocation(String filename);
 
+  /**
+   * Return a fully-qualified data file location for the given filename and options.
+   *
+   * @param filename a file name
+   * @param options options for deciding the location
+   * @return a fully-qualified location URI for a data file
+   */
+  default String newDataLocation(String filename, Map<String, String> options) {

Review Comment:
   These options is provided when user wants to write data to data file directly and need a valid location, the values would depend on the specific implementation - the unit tests shows a simple example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org