You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/11/01 01:41:18 UTC
[GitHub] [skywalking] hanahmily commented on issue #3718: [WIP]Scripts which
deploy Istio + OAP + ES to a standard k8s cluster
hanahmily commented on issue #3718: [WIP]Scripts which deploy Istio + OAP + ES to a standard k8s cluster
URL: https://github.com/apache/skywalking/pull/3718#issuecomment-548633330
Thanks @innerpeacez. some nits here:
1. we should consider adding "timeout" to all status wait. if deployments don't work in a particular duration, the task should be marked as failed.
1. add "set -e" in your scripts, if there's some error, scripts will stop there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services