You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/05 03:45:18 UTC

[GitHub] [pulsar] jiazhai opened a new pull request #7454: [doc] fix doc after remove bc-shaded

jiazhai opened a new pull request #7454:
URL: https://github.com/apache/pulsar/pull/7454


   ### Motivation
   
   This is related with fix #7453.
   After remove module bc-shaded, we should updated the docs.
   
   ### Modifications
   
   update related doc related to remove module bc-shaded.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jennifer88huang merged pull request #7454: [doc] fix doc after remove bc-shaded

Posted by GitBox <gi...@apache.org>.
Jennifer88huang merged pull request #7454:
URL: https://github.com/apache/pulsar/pull/7454


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #7454: [doc] fix doc after remove bc-shaded

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #7454:
URL: https://github.com/apache/pulsar/pull/7454#discussion_r449941739



##########
File path: site2/docs/security-bouncy-castle.md
##########
@@ -37,8 +37,7 @@ Pulsar module `bouncy-castle-bc`, which defined by `bouncy-castle/bc/pom.xml` co
     </dependency>
 ```
 
-And based on Pulsar module `bouncy-castle-bc`, Pulsar shades a fat jar in module `bouncy-castle-bc-shaded` that contains needed classes of BouncyCastle non-FIPS jars.
-By using this `bouncy-castle-bc-shaded` module, user can easily include and exclude BouncyCastle non-FIPS jars.
+By using this `bouncy-castle-bc` module, user can easily include and exclude BouncyCastle non-FIPS jars.

Review comment:
       ```suggestion
   By using this `bouncy-castle-bc` module, you can easily include and exclude BouncyCastle non-FIPS jars.
   ```
   
   Use the second-person pronoun `you` as much as possible in technical writing.
   
   Please check all occurrences. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org