You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Michael Vorburger (Jira)" <ji...@apache.org> on 2022/01/07 13:10:00 UTC

[jira] [Comment Edited] (FINERACT-1482) Docker Hub Build broke with switch from Dockerfile to JIB

    [ https://issues.apache.org/jira/browse/FINERACT-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470602#comment-17470602 ] 

Michael Vorburger edited comment on FINERACT-1482 at 1/7/22, 1:09 PM:
----------------------------------------------------------------------

That approach (above) would make sense to me as well. So basically we would have to do something like what [https://www.baeldung.com/jib-dockerizing#overview-4] describes (NB that JIB won't generate an actual {{{}Dockerfile{}}}, see [https://github.com/GoogleContainerTools/jib/issues/2394]) during [https://github.com/apache/fineract/actions/workflows/build-docker.yml] is what you are suggesting?

I'm happy to "support" this, and collaborate to e.g. make the Credz to be able to push to Docker Hub available as a GitHub Secret as [recently reminded about|https://github.com/vorburger/www.fineract.dev/issues/4#issuecomment-1005333150], described on [this slide from my ApacheCon prez|https://docs.google.com/presentation/d/1-VP4bNkc5kZ3B0yme_vYLiY1qpswnfz8ainnX5fp3l8/edit#slide=id.g96b92e9d0e_0_14] linking to [this old blog post of mine|http://blog2.vorburger.ch/2020/05/fineractdev-cicd-from-github-to-google.html], which explains how to set up a Secret on repos one only has Write but not Admin to, such as ASF, but someone else should "drive" this.


was (Author: vorburger):
That approach (above) would make sense to me as well. So basically we would have to do something like what [https://www.baeldung.com/jib-dockerizing#overview-4] describes (NB that JIB won't generate an actual {{{}Dockerfile{}}}, see [https://github.com/GoogleContainerTools/jib/issues/2394]) during [https://github.com/apache/fineract/actions/workflows/build-docker.yml] is what you are suggesting?

I'm happy to "support" this, and collaborate to e.g. make the Credz to be able to push to Docker Hub available as a GitHub Secret as [recently reminded about|https://github.com/vorburger/www.fineract.dev/issues/4#issuecomment-1005333150], described on [this slide from my ApacheCon prez](https://docs.google.com/presentation/d/1-VP4bNkc5kZ3B0yme_vYLiY1qpswnfz8ainnX5fp3l8/edit#slide=id.g96b92e9d0e_0_14) linking to [this old blog post of mine](http://blog2.vorburger.ch/2020/05/fineractdev-cicd-from-github-to-google.html), which explains how to set up a Secret on repos one only has Write but not Admin to, such as ASF, but someone else should "drive" this.

> Docker Hub Build broke with switch from Dockerfile to JIB
> ---------------------------------------------------------
>
>                 Key: FINERACT-1482
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1482
>             Project: Apache Fineract
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 1.6.0
>            Reporter: Michael Vorburger
>            Priority: Blocker
>             Fix For: 1.6.0
>
>
> https://github.com/apache/fineract/commits/develop shows a lot of ugly red crosses since recently.
> I've had a look at why that is so, and one issue (together with another one re. Sonar) is _ci/dockercloud-stage — Your image failed to build_.
> I originally had set this up, see FINERACT-760 (and have access to the Docker Hub Build Logs). 
> This is an impact of https://github.com/apache/fineract/pull/2009 for FINERACT-1469, just like https://github.com/vorburger/www.fineract.dev/issues/11.
> I'm not going to be able to further look much into this myself, but perhaps [~aleks] you would be interested in researching how this could be fixed?
> If we cannot fix it (whether just time wise, or for some technical reasons), then I would propose that we remove https://hub.docker.com/repository/docker/apache/fineract/general. That may warrant some discussion on the mailing list though - last time I looked at the numbers (for ApacheCon) this container had HUGE (!) numbers of downloads.
> A possible alternative could be to open up the container I'm anyway building on https://www.fineract.dev and distribute that one instead?



--
This message was sent by Atlassian Jira
(v8.20.1#820001)