You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Gareth Carter (JIRA)" <ji...@apache.org> on 2017/02/08 13:45:41 UTC
[jira] [Updated] (OFBIZ-9208) reinstate url cache in
UtilURL.fromResource
[ https://issues.apache.org/jira/browse/OFBIZ-9208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gareth Carter updated OFBIZ-9208:
---------------------------------
Description:
Adrian created the following commit to cache URL objects
{noformat}
Revision: 1649979
Author: adrianc
Date: 07 January 2015 00:24:28
Message:
Some optimizations for URL lookups.
----
Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilProperties.java
Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java
{noformat}
and was later reverted in this commit
{noformat}
Revision: 1650347
Author: adrianc
Date: 08 January 2015 17:53:59
Message:
Some small fixups for some of my previous commits.
----
Modified : /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityClassLoader.java
Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java
{noformat}
We have found in one of our production servers that line 98 in UtilURL.java
{code}
url = loader.getResource(resourceName);
{code}
has caused locking and looking at the stack trace (from jstack) there are numerous threads waiting on locks from within this method
I propose the cache gets added back (we have done this as a patch on our systems with no ill effect)
FYI - The commits are in reference to the EntityClassLoader which is not used and does not work see OFBIZ-6210
was:
Adrian created the following commit to cache URL objects
Revision: 1649979
Author: adrianc
Date: 07 January 2015 00:24:28
Message:
Some optimizations for URL lookups.
----
Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilProperties.java
Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java
and was later reverted in this commit
Revision: 1650347
Author: adrianc
Date: 08 January 2015 17:53:59
Message:
Some small fixups for some of my previous commits.
----
Modified : /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityClassLoader.java
Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java
We have found in one of our production servers that
url = loader.getResource(resourceName);
has caused locking and looking at the stack trace (from jstack) there are numerous threads waiting on locks from within this method
I propose the cache gets added back (we have done this as a patch on our systems with no ill effect)
FYI - The commits are in reference to the EntityClassLoader which is not used and does not work see OFBIZ-6210
> reinstate url cache in UtilURL.fromResource
> -------------------------------------------
>
> Key: OFBIZ-9208
> URL: https://issues.apache.org/jira/browse/OFBIZ-9208
> Project: OFBiz
> Issue Type: Bug
> Components: base
> Affects Versions: Trunk
> Reporter: Gareth Carter
> Priority: Trivial
>
> Adrian created the following commit to cache URL objects
> {noformat}
> Revision: 1649979
> Author: adrianc
> Date: 07 January 2015 00:24:28
> Message:
> Some optimizations for URL lookups.
> ----
> Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilProperties.java
> Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java
> {noformat}
> and was later reverted in this commit
> {noformat}
> Revision: 1650347
> Author: adrianc
> Date: 08 January 2015 17:53:59
> Message:
> Some small fixups for some of my previous commits.
> ----
> Modified : /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityClassLoader.java
> Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java
> {noformat}
> We have found in one of our production servers that line 98 in UtilURL.java
> {code}
> url = loader.getResource(resourceName);
> {code}
> has caused locking and looking at the stack trace (from jstack) there are numerous threads waiting on locks from within this method
> I propose the cache gets added back (we have done this as a patch on our systems with no ill effect)
> FYI - The commits are in reference to the EntityClassLoader which is not used and does not work see OFBIZ-6210
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)