You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by fe...@apache.org on 2022/11/05 08:12:39 UTC
[incubator-kyuubi] branch master updated: [KYUUBI #3753] Fix flaky test - AdminResourceSuite: delete engine - user share level
This is an automated email from the ASF dual-hosted git repository.
feiwang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new bd3578488 [KYUUBI #3753] Fix flaky test - AdminResourceSuite: delete engine - user share level
bd3578488 is described below
commit bd3578488ff6fc591adc0fb9fba48672c3de3506
Author: Fei Wang <fw...@ebay.com>
AuthorDate: Sat Nov 5 16:12:32 2022 +0800
[KYUUBI #3753] Fix flaky test - AdminResourceSuite: delete engine - user share level
### _Why are the changes needed?_
close #3751
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #3753 from turboFei/delete.
Closes #3753
bd9c59913 [Fei Wang] save
ff453f0c9 [Fei Wang] test
Authored-by: Fei Wang <fw...@ebay.com>
Signed-off-by: Fei Wang <fw...@ebay.com>
---
.../scala/org/apache/kyuubi/server/api/v1/AdminResourceSuite.scala | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/AdminResourceSuite.scala b/kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/AdminResourceSuite.scala
index f97ff5c1a..4d1088442 100644
--- a/kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/AdminResourceSuite.scala
+++ b/kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/AdminResourceSuite.scala
@@ -100,7 +100,9 @@ class AdminResourceSuite extends KyuubiFunSuite with RestFrontendTestHelper {
assert(200 == response.getStatus)
assert(client.pathExists(engineSpace))
- assert(client.getChildren(engineSpace).size == 0)
+ eventually(timeout(5.seconds), interval(100.milliseconds)) {
+ assert(client.getChildren(engineSpace).size == 0, s"refId same with $id?")
+ }
// kill the engine application
engineMgr.killApplication(None, id)