[GitHub] beliefer commented on a change in pull request #23869: [SPARK-26967][CORE] Put MetricsSystem instance names together for clearer management

[GitBox <gi...@apache.org>]

beliefer commented on a change in pull request #23869: [SPARK-26967][CORE] Put MetricsSystem instance names together for clearer management
URL: https://github.com/apache/spark/pull/23869#discussion_r259303255
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SparkEnv.scala
 ##########
 @@ -349,13 +349,14 @@ object SparkEnv extends Logging {
       // Don't start metrics system right now for Driver.
       // We need to wait for the task scheduler to give us an app ID.
       // Then we can start the metrics system.
-      MetricsSystem.createMetricsSystem("driver", conf, securityManager)
+      MetricsSystem.createMetricsSystem(MetricsSystemInstances.DRIVER, conf, securityManager)
 
 Review comment:
   The MetricsSystemInstances put the pieces together.
   Looks good!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org