You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/06 07:52:13 UTC
[GitHub] [airflow] kishvanchee opened a new pull request #11293: Move dummy_operator.py to dummy.py (#11178)
kishvanchee opened a new pull request #11293:
URL: https://github.com/apache/airflow/pull/11293
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This change is related to #11178 for the `dummy_operator`
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-732829715
@ashb can you please have a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-737153607
> @ashb Yes sure, I will do this tomorrow. Apologies for the delay.
The delay was all us, no need to apologise!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-721446314
Can you please rebase your PR on latest Master since we have applied [Black](https://github.com/apache/airflow/commit/4e8f9cc8d02b29c325b8a5a76b4837671bdf5f68) and [PyUpgrade](https://github.com/apache/airflow/commit/8c42cf1b00c90f0d7f11b8a3a455381de8e003c5) on Master.
It will help if your squash your commits into single commit first so that there are less conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-732766323
@kaxil @turbaszek Can you please have a look now? I have updated, rebased and squashed the commits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-704098530
@turbaszek @mik-laj Please review the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-736831742
@kishvanchee Could you rebase this please? And check if there are any new instances that have "snuck in" in the mean time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #11293:
URL: https://github.com/apache/airflow/pull/11293
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#discussion_r532120385
##########
File path: UPDATING.md
##########
@@ -219,8 +219,15 @@ with third party services to the ``airflow.providers`` package.
All changes made are backward compatible, but if you use the old import paths you will
see a deprecation warning. The old import paths can be abandoned in the future.
+According to [AIP-21](https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths)
+`_operator` suffix has been removed from operators. A deprecation warning has also been raised for paths
+importing with the suffix.
+The following table shows changes in import paths.
+| Old path | New path |
+|-------------------------------------|----------------------------|
+| airflow.operators.dummy_operator.py | airflow.operators.dummy.py |
Review comment:
There's this block further on.
```
#### Removed deprecated import mechanism
The deprecated import mechanism has been removed so the import of modules becomes more consistent and explicit.
For example: `from airflow.operators import BashOperator`
becomes `from airflow.operators.bash_operator import BashOperator`
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-704216574
I'm not sure how to fix **CI Build / Backport packages (pull_request)**. The error states
```
Traceback (most recent call last):
File "/import_all_provider_classes.py", line 60, in import_all_provider_classes
_module = importlib.import_module(module_name)
File "/usr/local/lib/python3.6/importlib/__init__.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "<frozen importlib._bootstrap>", line 994, in _gcd_import
File "<frozen importlib._bootstrap>", line 971, in _find_and_load
File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 678, in exec_module
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
File "/usr/local/lib/python3.6/site-packages/airflow/providers/qubole/example_dags/example_qubole.py", line 24, in <module>
from airflow.operators.dummy import DummyOperator
ModuleNotFoundError: No module named 'airflow.operators.dummy'
```
but this should have failed for imports from other places too right? I don't see this error popping up in the breeze environment.
```
root@b20475852b92:/opt/airflow# python
Python 3.6.12 (default, Sep 10 2020, 18:03:29)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from airflow.operators.dummy import DummyOperator as d1
>>> from airflow.operators.dummy_operator import DummyOperator as d2
>>> d2.__name__
'DummyOperator'
>>> d1.__name__
'DummyOperator'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-740254598
I think this needs updating https://github.com/apache/airflow/blob/23e743ec09bffe30a9a2b17cc873af5ef9d3cd9f/dev/provider_packages/refactor_provider_packages.py#L141-L145 too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee edited a comment on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee edited a comment on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-732807049
> This needs a note added to UPDATING.md and UPGRADING_TO_2.0.md please
@ashb Can you please point out where exactly? In UPDATING.md I found a section ** Changes to import paths **. I couldn't find something similar in UPGRADING_TO_2.0.md.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee edited a comment on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee edited a comment on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-732807049
> This needs a note added to UPDATING.md and UPGRADING_TO_2.0.md please
@ashb Can you please point out where exactly? In UPDATING.md I found a section **Changes to import paths**. I couldn't find something similar in UPGRADING_TO_2.0.md.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-704275042
@kishvanchee c The files in the providers directory must be either compatible with Airflow 1.10.13, or we must provide automatically refactor to be compatible. When we release Airflow 1.10.13 this problem will disappear. Details: https://github.com/apache/airflow/issues/11178
https://github.com/apache/airflow/issues/10152 Migration to Airflow 2.0
Now you can either revert all changes to the providers directory or add auto-refactor (preferred). To do it, add a new tuple here: https://github.com/apache/airflow/blob/9514cfe64b35289566c4e56c491c36b43c4fb737/backport_packages/refactor_backport_packages.py#L145-L155
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-736850672
@ashb Yes sure, I will do this tomorrow. Apologies for the delay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee edited a comment on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee edited a comment on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-705073215
@turbaszek Can you please confirm? I was excluding `docs/_api` from my search since I thought these would get generated automatically. I guess from your comment I'm wrong.
Or are you referring to these 2 files?
```
./docs/lineage.rst:34: from airflow.operators.dummy_operator import DummyOperator
./docs/concepts.rst:1053: from airflow.operators.dummy_operator import DummyOperator
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-731855141
@kishvanchee any update on this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-705076909
We should fix all occurrences 😉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-732808695
Oh yes, there's nothing in there (perhaps there should be) -- so just UPDATING.md will be fine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-704275042
@kishvanchee c The files in the providers directory must be either compatible with Airflow 1.10.13, or they must be automatically refactor to be compatible. When we release Airflow 1.10.13 this problem will disappear. Details: https://github.com/apache/airflow/issues/11178
https://github.com/apache/airflow/issues/10152 Migration to Airflow 2.0
Now you can either revert all changes to the providers directory or add auto-refactor (preferred). To do it, add a new tuple here: https://github.com/apache/airflow/blob/9514cfe64b35289566c4e56c491c36b43c4fb737/backport_packages/refactor_backport_packages.py#L145-L155
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-704758457
@mik-laj please review the changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-704308029
@mik-laj Got it thanks. I'll make that change. How does this affect only certain operators and not all operators? Since so far I see only bash and python are incorporated, and now we'll incorporate dummy too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil removed a comment on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kaxil removed a comment on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-740254598
I think this needs updating https://github.com/apache/airflow/blob/23e743ec09bffe30a9a2b17cc873af5ef9d3cd9f/dev/provider_packages/refactor_provider_packages.py#L141-L145 too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#discussion_r532120158
##########
File path: UPDATING.md
##########
@@ -219,8 +219,15 @@ with third party services to the ``airflow.providers`` package.
All changes made are backward compatible, but if you use the old import paths you will
see a deprecation warning. The old import paths can be abandoned in the future.
+According to [AIP-21](https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths)
+`_operator` suffix has been removed from operators. A deprecation warning has also been raised for paths
+importing with the suffix.
+The following table shows changes in import paths.
+| Old path | New path |
+|-------------------------------------|----------------------------|
+| airflow.operators.dummy_operator.py | airflow.operators.dummy.py |
Review comment:
I'm surprised to see we don't have more info here/a table like this already!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee edited a comment on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee edited a comment on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-704308029
@mik-laj Got it thanks. I'll make that change. How does this affect only certain operators and not all operators (for example email that you had modified earlier)? Since so far I see only bash and python are incorporated, and now we'll incorporate dummy too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-732807049
> This needs a note added to UPDATING.md and UPGRADING_TO_2.0.md please
Can you please point out where exactly? In UPDATING.md I found a section ** Changes to import paths **. I couldn't find something similar in UPGRADING_TO_2.0.md.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee edited a comment on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee edited a comment on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-705073215
@turbaszek Can you please confirm? I was excluding `docs/_api` from my search since I thought these would get generated automatically. I guess from your comment I'm wrong.
Or are you referring to these 2 files?
```
./docs/lineage.rst:34: from airflow.operators.dummy_operator import DummyOperator
./docs/concepts.rst:1053: from airflow.operators.dummy_operator import DummyOperator
```
I'm surprised I didn't catch these either
```
./backport_packages/airflow/providers/qubole/example_dags/example_qubole.py:24:from airflow.operators.dummy_operator import DummyOperator
./backport_packages/airflow/providers/amazon/aws/example_dags/example_google_api_to_s3_transfer_advanced.py:39:from airflow.operators.dummy_operator import DummyOperator
./backport_packages/airflow/providers/microsoft/winrm/example_dags/example_winrm.py:34:from airflow.operators.dummy_operator import DummyOperator
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-732343227
@turbaszek @kaxil Hi, I apologize for the delay. I'll update this by tomorrow afternoon IST.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-706734820
@kishvanchee can you please rebase due to conflicts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-706529906
@kishvanchee can you rebase please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#discussion_r532120517
##########
File path: UPDATING.md
##########
@@ -219,8 +219,15 @@ with third party services to the ``airflow.providers`` package.
All changes made are backward compatible, but if you use the old import paths you will
see a deprecation warning. The old import paths can be abandoned in the future.
+According to [AIP-21](https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths)
+`_operator` suffix has been removed from operators. A deprecation warning has also been raised for paths
+importing with the suffix.
+The following table shows changes in import paths.
+| Old path | New path |
+|-------------------------------------|----------------------------|
+| airflow.operators.dummy_operator.py | airflow.operators.dummy.py |
Review comment:
```suggestion
| airflow.operators.dummy_operator.DummyOperator | airflow.operators.dummy.DummyOperator |
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-704123637
[The Build Workflow run](https://github.com/apache/airflow/actions/runs/291027965) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee commented on pull request #11293: Move dummy_operator.py to dummy.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee commented on pull request #11293:
URL: https://github.com/apache/airflow/pull/11293#issuecomment-705073215
@turbaszek Can you please confirm? I was excluding `docs/_api` from my search since I thought these would get generated automatically. I guess from your comment I'm wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org