You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Paul Benedict (JIRA)" <ji...@apache.org> on 2007/08/16 05:12:35 UTC

[jira] Created: (STR-3085) Module post-processing via plug-ins

Module post-processing via plug-ins
-----------------------------------

                 Key: STR-3085
                 URL: https://issues.apache.org/struts/browse/STR-3085
             Project: Struts 1
          Issue Type: New Feature
          Components: Core
            Reporter: Paul Benedict
            Assignee: Paul Benedict
             Fix For: 1.4.0


Plugins, which implement a special interface, should be invoked to customize the ModuleConfig after it has been configured but before it is frozen. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (STR-3085) Configuration post-processing via plug-ins

Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/STR-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Benedict updated STR-3085:
-------------------------------

    Description: Plugins, which implement a special interface, should be invoked to customize the configuration before and after it has been configured but before it is frozen.   (was: Plugins, which implement a special interface, should be invoked to customize the ModuleConfig after it has been configured but before it is frozen. )
        Summary: Configuration post-processing via plug-ins  (was: Module post-processing via plug-ins)

> Configuration post-processing via plug-ins
> ------------------------------------------
>
>                 Key: STR-3085
>                 URL: https://issues.apache.org/struts/browse/STR-3085
>             Project: Struts 1
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Paul Benedict
>            Assignee: Paul Benedict
>             Fix For: 1.4.0
>
>
> Plugins, which implement a special interface, should be invoked to customize the configuration before and after it has been configured but before it is frozen. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (STR-3085) Configuration post-processing via plug-ins

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/STR-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henri Yandell reopened STR-3085:
--------------------------------


This feature appears to have broken the build, leading to seven exceptions in TestActionServlet such as:

Tests run: 31, Failures: 7, Errors: 0, Skipped: 0, Time elapsed: 0.091 sec <<< FAILURE!
testInitModuleFormBeansNullFormType(org.apache.struts.action.TestActionServlet)  Time elapsed: 0.004 sec  <<< FAILURE!
junit.framework.AssertionFailedError: Unrecognized exception thrown: java.lang.NullPointerException
    at junit.framework.Assert.fail(Assert.java:47)
    at org.apache.struts.action.TestActionServlet.testInitModuleFormBeansNullFormType(TestActionServlet.java:316)
    at org.apache.struts.action.TestActionServlet.testInitModuleFormBeansNullFormType(TestActionServlet.java:316)

It looks as though the code has changed from throwing an UnavailableException to throwing a NullPointerException inside the GenericServlet.getServletContext() because the servlet's config is null. 

> Configuration post-processing via plug-ins
> ------------------------------------------
>
>                 Key: STR-3085
>                 URL: https://issues.apache.org/struts/browse/STR-3085
>             Project: Struts 1
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Paul Benedict
>            Assignee: Paul Benedict
>             Fix For: 1.4.0
>
>
> Plugins, which implement a special interface, should be invoked to customize the configuration before and after it has been configured but before it is frozen. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (STR-3085) Module post-processing via plug-ins

Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/STR-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Benedict resolved STR-3085.
--------------------------------

    Resolution: Fixed

> Module post-processing via plug-ins
> -----------------------------------
>
>                 Key: STR-3085
>                 URL: https://issues.apache.org/struts/browse/STR-3085
>             Project: Struts 1
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Paul Benedict
>            Assignee: Paul Benedict
>             Fix For: 1.4.0
>
>
> Plugins, which implement a special interface, should be invoked to customize the ModuleConfig after it has been configured but before it is frozen. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (STR-3085) Configuration post-processing via plug-ins

Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/STR-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Benedict resolved STR-3085.
--------------------------------

    Resolution: Fixed

It is impossible to set the ActionServlet's ServletContext without going through the whole initialization routine. Therefore, the NPE is swallowed. I find that acceptable because it's equal to no plug-ins existing anyway.

> Configuration post-processing via plug-ins
> ------------------------------------------
>
>                 Key: STR-3085
>                 URL: https://issues.apache.org/struts/browse/STR-3085
>             Project: Struts 1
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Paul Benedict
>            Assignee: Paul Benedict
>             Fix For: 1.4.0
>
>
> Plugins, which implement a special interface, should be invoked to customize the configuration before and after it has been configured but before it is frozen. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.