You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@arrow.apache.org by GitBox <gi...@apache.org> on 2019/09/13 20:57:46 UTC

[GitHub] [arrow-site] nealrichardson opened a new pull request #23: ARROW-6127: [Website] Add favicons and meta tags

nealrichardson opened a new pull request #23: ARROW-6127: [Website] Add favicons and meta tags
URL: https://github.com/apache/arrow-site/pull/23
 
 
   This patch:
   
   * Adds an Arrow favicon (the >>> image)
   * Adds code to switch to inverse (white) favicon on "dark mode" 
   ![image](https://user-images.githubusercontent.com/2975928/64894164-d829c800-d62d-11e9-9ec7-bdb2d091a624.png)
   * Customizes the page `<title>` based on the actual page title (previously every page was "Apache Arrow Homepage"
   * Adds twitter card and opengraph `<meta>` tags, which allow for previews on social media and Slack like this: 
   
   ![image](https://user-images.githubusercontent.com/2975928/64894305-2f2f9d00-d62e-11e9-83ec-be53b4d6c6ee.png)
   
   ![image](https://user-images.githubusercontent.com/2975928/64894321-38b90500-d62e-11e9-8eb3-1b541388bbc3.png)
   
   I previously explored a port to Hugo (which is why I added the `themes` directory to be ignored here) but didn't want to take all that on right now since we can get these improvements without it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services