You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/14 11:05:09 UTC

[GitHub] [spark] attilapiros commented on a change in pull request #29102: [SPARK-32303][PYTHON][BUILD] Remove leftover from editable mode installation in PIP test

attilapiros commented on a change in pull request #29102:
URL: https://github.com/apache/spark/pull/29102#discussion_r454277192



##########
File path: dev/run-pip-tests
##########
@@ -96,6 +96,8 @@ for python in "${PYTHON_EXECS[@]}"; do
     cd "$FWDIR"/python
     # Delete the egg info file if it exists, this can cache the setup file.
     rm -rf pyspark.egg-info || echo "No existing egg info file, skipping deletion"
+    # Also, delete the symbloic link if exists. It can be left over from the previous editable mode installation.

Review comment:
       Nit typo:
   ```suggestion
       # Also, delete the symbolic link if exists. It can be left over from the previous editable mode installation.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org