You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ivoson (via GitHub)" <gi...@apache.org> on 2025/10/06 03:31:27 UTC

[PR] [SPARK-51756][CORE][FOLLOWUP] Fix code style issues [spark]

ivoson opened a new pull request, #52521:
URL: https://github.com/apache/spark/pull/52521

   ### What changes were proposed in this pull request?
   This is a follow up of https://github.com/apache/spark/pull/50230 to fix the code style issues in `MapStatusEndToEndSuite`.
   
   
   ### Why are the changes needed?
   Fix indentation issue.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   NA
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-51756][CORE][FOLLOWUP] Fix code style issues [spark]

Posted by "ivoson (via GitHub)" <gi...@apache.org>.
ivoson commented on PR #52521:
URL: https://github.com/apache/spark/pull/52521#issuecomment-3369801849

   cc @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-51756][CORE][FOLLOWUP] Fix code style issues [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #52521:
URL: https://github.com/apache/spark/pull/52521#issuecomment-3397196789

   This is a quick followup to fix the wrong code style introduced by a recently merged PR from the same PR author, I think we should accept it? @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-51756][CORE][FOLLOWUP] Fix code style issues [spark]

Posted by "ivoson (via GitHub)" <gi...@apache.org>.
ivoson closed pull request #52521: [SPARK-51756][CORE][FOLLOWUP] Fix code style issues
URL: https://github.com/apache/spark/pull/52521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-51756][CORE][FOLLOWUP] Fix code style issues [spark]

Posted by "ivoson (via GitHub)" <gi...@apache.org>.
ivoson commented on PR #52521:
URL: https://github.com/apache/spark/pull/52521#issuecomment-3395618186

   > Let's avoid making a PR for such style changes. It's not really worth while spending time on this in a separate PR. we can fix it together when we happen to touch the code around here.
   
   Sure. Closing this then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-51756][CORE][FOLLOWUP] Fix code style issues [spark]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #52521:
URL: https://github.com/apache/spark/pull/52521#issuecomment-3395459315

   Let's avoid making a PR for such style changes. It's not really worth while spending time on this in a separate PR. we can fix it together when we happen to touch the code around here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org