You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Morio Ramdenbourg via Review Board <no...@reviews.apache.org> on 2018/09/06 05:34:10 UTC

Review Request 68647: SENTRY-2375: Fixed typos in listPrivilegesbyAuthorizable and getAllPrivilegesbyAuthorizable APIs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68647/
-----------------------------------------------------------

Review request for sentry, Arjun Mishra, Steve Moist, and Sergio Pena.


Repository: sentry


Description
-------

SENTRY-2375: Fixed typos in listPrivilegesbyAuthorizable and getAllPrivilegesbyAuthorizable APIs


Diffs
-----

  sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java 5db796dd45fcc026bfbbd17173b4c54d8051611e 
  sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java 3ef1624e824881489fbf0798d7d1d0fa7688e5f0 
  sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java a2213ae35e62b15f649940ab24ff90cc87f0cd90 
  sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceIntegration.java 73fca848ba333aa4d7d7198f82c5bd03c09c0791 


Diff: https://reviews.apache.org/r/68647/diff/1/


Testing
-------

Ran the test phase (mvn clean install) from the root level successfully.


Thanks,

Morio Ramdenbourg


Re: Review Request 68647: SENTRY-2375: Fixed typos in listPrivilegesbyAuthorizable and getAllPrivilegesbyAuthorizable APIs

Posted by Steve Moist via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68647/#review208413
-----------------------------------------------------------


Ship it!




Ship It!

- Steve Moist


On Sept. 6, 2018, 5:36 a.m., Morio Ramdenbourg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68647/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2018, 5:36 a.m.)
> 
> 
> Review request for sentry, Arjun Mishra, Steve Moist, and Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> [SENTRY-2375](https://issues.apache.org/jira/browse/SENTRY-2375): Fixed typos in listPrivilegesbyAuthorizable and getAllPrivilegesbyAuthorizable APIs
> 
> 
> Diffs
> -----
> 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java 5db796dd45fcc026bfbbd17173b4c54d8051611e 
>   sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java 3ef1624e824881489fbf0798d7d1d0fa7688e5f0 
>   sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java a2213ae35e62b15f649940ab24ff90cc87f0cd90 
>   sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceIntegration.java 73fca848ba333aa4d7d7198f82c5bd03c09c0791 
> 
> 
> Diff: https://reviews.apache.org/r/68647/diff/1/
> 
> 
> Testing
> -------
> 
> Ran the test phase (mvn clean install) from the root level successfully.
> 
> 
> Thanks,
> 
> Morio Ramdenbourg
> 
>


Re: Review Request 68647: SENTRY-2375: Fixed typos in listPrivilegesbyAuthorizable and getAllPrivilegesbyAuthorizable APIs

Posted by Arjun Mishra via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68647/#review208408
-----------------------------------------------------------


Ship it!




Ship It!

- Arjun Mishra


On Sept. 6, 2018, 5:36 a.m., Morio Ramdenbourg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68647/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2018, 5:36 a.m.)
> 
> 
> Review request for sentry, Arjun Mishra, Steve Moist, and Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> [SENTRY-2375](https://issues.apache.org/jira/browse/SENTRY-2375): Fixed typos in listPrivilegesbyAuthorizable and getAllPrivilegesbyAuthorizable APIs
> 
> 
> Diffs
> -----
> 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java 5db796dd45fcc026bfbbd17173b4c54d8051611e 
>   sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java 3ef1624e824881489fbf0798d7d1d0fa7688e5f0 
>   sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java a2213ae35e62b15f649940ab24ff90cc87f0cd90 
>   sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceIntegration.java 73fca848ba333aa4d7d7198f82c5bd03c09c0791 
> 
> 
> Diff: https://reviews.apache.org/r/68647/diff/1/
> 
> 
> Testing
> -------
> 
> Ran the test phase (mvn clean install) from the root level successfully.
> 
> 
> Thanks,
> 
> Morio Ramdenbourg
> 
>


Re: Review Request 68647: SENTRY-2375: Fixed typos in listPrivilegesbyAuthorizable and getAllPrivilegesbyAuthorizable APIs

Posted by Morio Ramdenbourg via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68647/
-----------------------------------------------------------

(Updated Sept. 6, 2018, 5:36 a.m.)


Review request for sentry, Arjun Mishra, Steve Moist, and Sergio Pena.


Repository: sentry


Description (updated)
-------

[SENTRY-2375](https://issues.apache.org/jira/browse/SENTRY-2375): Fixed typos in listPrivilegesbyAuthorizable and getAllPrivilegesbyAuthorizable APIs


Diffs
-----

  sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryAccessController.java 5db796dd45fcc026bfbbd17173b4c54d8051611e 
  sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClient.java 3ef1624e824881489fbf0798d7d1d0fa7688e5f0 
  sentry-service/sentry-service-api/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyServiceClientDefaultImpl.java a2213ae35e62b15f649940ab24ff90cc87f0cd90 
  sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryServiceIntegration.java 73fca848ba333aa4d7d7198f82c5bd03c09c0791 


Diff: https://reviews.apache.org/r/68647/diff/1/


Testing
-------

Ran the test phase (mvn clean install) from the root level successfully.


Thanks,

Morio Ramdenbourg