You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/03/03 04:06:59 UTC
[GitHub] [incubator-mxnet] wkcn opened a new pull request #17748: support
multiple-dim input for unravel_index
wkcn opened a new pull request #17748: support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748
## Description ##
Fix #17472
Support multiple-dim input for `unravel_index`
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] tiny-change. The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [x] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [x] support multiple-dim input for unravel_index
- [x] update the document of unravel_index
- [x] add the unittest for unravel_index
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wkcn commented on issue #17748: [Bug Fix] support
multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
wkcn commented on issue #17748: [Bug Fix] support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-609012571
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wkcn commented on issue #17748: [Bug Fix] support
multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
wkcn commented on issue #17748: [Bug Fix] support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-604178547
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17748: [Bug Fix]
support multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17748: [Bug Fix] support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-604178580
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wkcn commented on issue #17748: [Bug Fix] support
multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
wkcn commented on issue #17748: [Bug Fix] support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-603694197
@mxnet-bot run ci [unix-gpu, windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17748: [Bug Fix]
support multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17748: [Bug Fix] support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-603772280
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wkcn commented on issue #17748: support
multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
wkcn commented on issue #17748: support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-603155767
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wkcn commented on issue #17748: [Bug Fix] support
multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
wkcn commented on issue #17748: [Bug Fix] support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-607263022
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17748: [Bug Fix]
support multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17748: [Bug Fix] support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-604490835
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17748: [Bug Fix]
support multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17748: [Bug Fix] support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-607263081
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wkcn commented on issue #17748: support
multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
wkcn commented on issue #17748: support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-603571487
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17748: [Bug Fix]
support multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17748: [Bug Fix] support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-603694269
Jenkins CI successfully triggered : [windows-gpu, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17748: [Bug Fix]
support multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17748: [Bug Fix] support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-609012579
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wkcn commented on issue #17748: support
multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
wkcn commented on issue #17748: support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-603315168
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wkcn merged pull request #17748: [Bug Fix]
support multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
wkcn merged pull request #17748: [Bug Fix] support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wkcn commented on issue #17748: [Bug Fix] support
multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
wkcn commented on issue #17748: [Bug Fix] support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-604490764
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17748: support
multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17748: support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-603571511
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wkcn commented on issue #17748: [Bug Fix] support
multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
wkcn commented on issue #17748: [Bug Fix] support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-603772226
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wkcn commented on issue #17748: [Bug Fix] support
multiple-dim input for unravel_index
Posted by GitBox <gi...@apache.org>.
wkcn commented on issue #17748: [Bug Fix] support multiple-dim input for unravel_index
URL: https://github.com/apache/incubator-mxnet/pull/17748#issuecomment-609036259
Hi @ChaiBapchya and @haojin2 , could you please help take a review? Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services