[GitHub] [nifi] markap14 commented on a change in pull request #4356: NIFI-7576 ListenHTTP: Honor primary node only attribute

[GitBox <gi...@apache.org>]

markap14 commented on a change in pull request #4356:
URL: https://github.com/apache/nifi/pull/4356#discussion_r444220971



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java
##########
@@ -373,6 +386,14 @@ public void createHttpServer(final ProcessContext context) throws Exception {
 
     @Override
     public void onTrigger(final ProcessContext context, final ProcessSessionFactory sessionFactory) {
+        try {
+            if (!initialized.get()) {
+                createHttpServerFromService(context);
+            }
+        } catch (Exception e) {
+            context.yield();

Review comment:
       We should not swallow this exception without logging at least logging it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org