You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vikram Dixit Kumaraswamy <vi...@gmail.com> on 2013/08/21 04:42:30 UTC

Review Request 13697: HIVE-5129: Multiple table insert fails on count(distinct)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13697/
-----------------------------------------------------------

Review request for hive and Navis Ryu.


Bugs: HIVE-5129
    https://issues.apache.org/jira/browse/HIVE-5129


Repository: hive-git


Description
-------

Hive fails with class cast exception on multiple table insert fails on count(distinct).


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java a39fd21 

Diff: https://reviews.apache.org/r/13697/diff/


Testing
-------

Runs the test from HIVE-4692 successfully.


Thanks,

Vikram Dixit Kumaraswamy


Re: Review Request 13697: HIVE-5129: Multiple table insert fails on count(distinct)

Posted by Vikram Dixit Kumaraswamy <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13697/
-----------------------------------------------------------

(Updated Aug. 23, 2013, 10:44 p.m.)


Review request for hive and Navis Ryu.


Changes
-------

Addressed Harish's comments. Added to the test case and fixed a unit test failure.


Bugs: HIVE-5129
    https://issues.apache.org/jira/browse/HIVE-5129


Repository: hive-git


Description
-------

Hive fails with class cast exception on multiple table insert fails on count(distinct).


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1d6e6fe 
  ql/src/test/queries/clientpositive/multi_insert_gby3.q PRE-CREATION 
  ql/src/test/results/clientpositive/multi_insert_gby3.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/13697/diff/


Testing
-------

Runs the test from HIVE-4692 successfully.


Thanks,

Vikram Dixit Kumaraswamy


Re: Review Request 13697: HIVE-5129: Multiple table insert fails on count(distinct)

Posted by Vikram Dixit Kumaraswamy <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13697/
-----------------------------------------------------------

(Updated Aug. 23, 2013, 4:37 p.m.)


Review request for hive and Navis Ryu.


Changes
-------

Made changes to retain parallelism. Added new test case.


Bugs: HIVE-5129
    https://issues.apache.org/jira/browse/HIVE-5129


Repository: hive-git


Description
-------

Hive fails with class cast exception on multiple table insert fails on count(distinct).


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java a39fd21 
  ql/src/test/queries/clientpositive/multi_insert_gby3.q PRE-CREATION 
  ql/src/test/results/clientpositive/multi_insert_gby3.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/13697/diff/


Testing
-------

Runs the test from HIVE-4692 successfully.


Thanks,

Vikram Dixit Kumaraswamy


Re: Review Request 13697: HIVE-5129: Multiple table insert fails on count(distinct)

Posted by Vikram Dixit Kumaraswamy <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13697/
-----------------------------------------------------------

(Updated Aug. 22, 2013, 2:16 a.m.)


Review request for hive and Navis Ryu.


Changes
-------

Made changes according to Navis' suggestion.


Bugs: HIVE-5129
    https://issues.apache.org/jira/browse/HIVE-5129


Repository: hive-git


Description
-------

Hive fails with class cast exception on multiple table insert fails on count(distinct).


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java a39fd21 

Diff: https://reviews.apache.org/r/13697/diff/


Testing
-------

Runs the test from HIVE-4692 successfully.


Thanks,

Vikram Dixit Kumaraswamy