You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Rob Slifka (JIRA)" <ji...@apache.org> on 2010/03/19 20:16:27 UTC
[jira] Created: (DAEMON-153) [PATCH] Update/fix of Tomcat5.sh
script
[PATCH] Update/fix of Tomcat5.sh script
---------------------------------------
Key: DAEMON-153
URL: https://issues.apache.org/jira/browse/DAEMON-153
Project: Commons Daemon
Issue Type: Bug
Components: Jsvc
Affects Versions: 1.0.1
Environment: Linux (tested on Fedora 8 / EC2)
Reporter: Rob Slifka
A few changes:
- Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
- Added 'status' support, to ping a URL and report success if the host was reachable and replied.
- Added comments to give people a hint that further customization sourced from catalina.sh may be required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DAEMON-153) [PATCH] Update/fix of Tomcat5.sh
script
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated DAEMON-153:
------------------------
Component/s: (was: Jsvc)
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
> Attachments: DAEMON-153.patch
>
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
> - Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAEMON-153) [PATCH] Update/fix of Tomcat5.sh
script
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860623#action_12860623 ]
Sebb commented on DAEMON-153:
-----------------------------
Since the script is primarily intended for Tomcat6, maybe it should be named accordingly?
It seems to me that the environment may have JAVA_HOME (and possibly other) variables already set up, so maybe these would be better defined as defaults, e.g.
JAVA_HOME=${JAVA_HOME:-/opt/jre1.6.0_18}
Or the script could probably use setclasspath.sh to set JAVA_HOME.
If references to CATALINA_HOME need to be protected by quotes, then CLASSPATH probably needs to be protected as well as it depends on CATALINA_HOME.
In the longer term, maybe it would be possible to fold the code into catalina.sh (though that is quite complicated already).
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
> Attachments: DAEMON-153.patch
>
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
> - Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DAEMON-153) [PATCH] Update/fix of Tomcat5.sh
script
Posted by "Rob Slifka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Slifka updated DAEMON-153:
------------------------------
Attachment: DAEMON-153.patch
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Components: Jsvc
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
> Attachments: DAEMON-153.patch
>
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
> - Added 'status' support, to ping a URL and report success if the host was reachable and replied.
> - Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DAEMON-153) [PATCH] Update/fix of Tomcat5.sh
script
Posted by "Rob Slifka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Slifka updated DAEMON-153:
------------------------------
Description:
A few changes:
- Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
- Added 'status' support, to ping a URL and report success if the host was reachable and replied.
- Added comments to give people a hint that further customization sourced from catalina.sh may be required.
- Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
was:
A few changes:
- Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
- Added 'status' support, to ping a URL and report success if the host was reachable and replied.
- Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Components: Jsvc
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
> - Added 'status' support, to ping a URL and report success if the host was reachable and replied.
> - Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAEMON-153) [PATCH] Update/fix of Tomcat5.sh
script
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860540#action_12860540 ]
Sebb commented on DAEMON-153:
-----------------------------
Sorry, you are correct, it can be found in:
src/native/unix/native
However, now that Daemon is part of Commons, it seems the wrong place for Tomcat-specific scripts.
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
> Attachments: DAEMON-153.patch
>
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
> - Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAEMON-153) [PATCH] Update/fix of Tomcat5.sh
script
Posted by "Rob Slifka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860564#action_12860564 ]
Rob Slifka commented on DAEMON-153:
-----------------------------------
Hi Sebb,
On this, we agree :)
However, the current script is a non-starter and I was hoping to "stop the bleeding" as it were, and then figure out correct placement.
Rob
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
> Attachments: DAEMON-153.patch
>
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
> - Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAEMON-153) [PATCH] Update/fix of Tomcat5.sh
script
Posted by "Rob Slifka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848277#action_12848277 ]
Rob Slifka commented on DAEMON-153:
-----------------------------------
Thanks for the detailed comments!
> 1. Put pid file back in /var/run... it's more standard than
Check.
> 2. Remove JAVA_HOME/rt.jar from the CLASSPATH... the JVM
Check.
> 3. Remove -debug switch from jsvc invocation
Oops, check :)
> 4. Make the -jvm and -wait options into script variables
Check.
> 5. Quote all uses of the following variables: CATALINA_HOME,
Check.
> 6. I'm' disturbed by the 'chown' you've added: there's no
Tomcat requires write access to:
- $CATALINA_BASE/logs (for log file creation)
- $CATALINA_BASE/work (for session serialization)
I'm not sure if the jsvc init script is the right place to verify/
assert these preconditions, though they are required. I've
removed it from the patch, because I think others will benefit
from the other changes and I'd like to see it in sooner than
later ;)
> 7. Allow the user to specify the location of 'curl' and check to
> 8. Alternatively, use the -check option on jsvc to check a
I would prefer to use -check, however I can't see how the return
value is communicated back to the init script so I can use it
to check status.
{code:title=java.c}
ret = (*env)->CallStaticBooleanMethod(env, cls, method, className);
if (ret == FALSE) {
log_error("An error was detected checking the %s daemon", args->clas);
return false;
}
log_debug("Daemon checked successfully");
return true;
{code}
> 9. ... You should use -errfile '&1'
Check.
Patch replaced!
Rob
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Components: Jsvc
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
> Attachments: DAEMON-153.patch
>
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
> - Added 'status' support, to ping a URL and report success if the host was reachable and replied.
> - Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DAEMON-153) [PATCH] Update/fix of Tomcat5.sh
script
Posted by "Mladen Turk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mladen Turk updated DAEMON-153:
-------------------------------
Priority: Minor (was: Major)
There is a new example Tomcat7.sh script that will be present in 1.0.4 and later.
Also those scripts since examples are moved to examples directory and
will be distributed as samples.
However this example will serve as base for Tomcat7 script that will be
maintained in Tomcat SVN.
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
> Priority: Minor
> Attachments: DAEMON-153.patch
>
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
> - Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DAEMON-153) [PATCH] Update/fix of Tomcat5.sh
script
Posted by "Rob Slifka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Slifka updated DAEMON-153:
------------------------------
Description:
A few changes:
- Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
- Added comments to give people a hint that further customization sourced from catalina.sh may be required.
- Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
was:
A few changes:
- Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
- Added 'status' support, to ping a URL and report success if the host was reachable and replied.
- Added comments to give people a hint that further customization sourced from catalina.sh may be required.
- Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Components: Jsvc
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
> Attachments: DAEMON-153.patch
>
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
> - Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (DAEMON-153) [PATCH] Update/fix of
Tomcat5.sh script
Posted by "Rob Slifka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848277#action_12848277 ]
Rob Slifka edited comment on DAEMON-153 at 3/22/10 6:42 PM:
------------------------------------------------------------
Thanks for the detailed comments!
> 1. Put pid file back in /var/run... it's more standard than
Check.
> 2. Remove JAVA_HOME/rt.jar from the CLASSPATH... the JVM
Check.
> 3. Remove -debug switch from jsvc invocation
Oops, check :)
> 4. Make the -jvm and -wait options into script variables
Check.
> 5. Quote all uses of the following variables: CATALINA_HOME,
Check.
> 6. I'm' disturbed by the 'chown' you've added: there's no
Tomcat requires write access to:
- $CATALINA_BASE/logs (for log file creation)
- $CATALINA_BASE/work (for session serialization)
I'm not sure if the jsvc init script is the right place to verify/assert these preconditions, though they are required. I've removed it from the patch, because I think others will benefit from the other changes and I'd like to see it in sooner than later ;)
> 7. Allow the user to specify the location of 'curl' and check to
> 8. Alternatively, use the -check option on jsvc to check a
I would prefer to use -check, however I can't see how the return value is communicated back to the init script so I can use it to check status.
{code:title=java.c}
ret = (*env)->CallStaticBooleanMethod(env, cls, method, className);
if (ret == FALSE) {
log_error("An error was detected checking the %s daemon", args->clas);
return false;
}
log_debug("Daemon checked successfully");
return true;
{code}
> 9. ... You should use -errfile '&1'
Check.
Patch replaced!
Rob
was (Author: rslifka):
Thanks for the detailed comments!
> 1. Put pid file back in /var/run... it's more standard than
Check.
> 2. Remove JAVA_HOME/rt.jar from the CLASSPATH... the JVM
Check.
> 3. Remove -debug switch from jsvc invocation
Oops, check :)
> 4. Make the -jvm and -wait options into script variables
Check.
> 5. Quote all uses of the following variables: CATALINA_HOME,
Check.
> 6. I'm' disturbed by the 'chown' you've added: there's no
Tomcat requires write access to:
- $CATALINA_BASE/logs (for log file creation)
- $CATALINA_BASE/work (for session serialization)
I'm not sure if the jsvc init script is the right place to verify/
assert these preconditions, though they are required. I've
removed it from the patch, because I think others will benefit
from the other changes and I'd like to see it in sooner than
later ;)
> 7. Allow the user to specify the location of 'curl' and check to
> 8. Alternatively, use the -check option on jsvc to check a
I would prefer to use -check, however I can't see how the return
value is communicated back to the init script so I can use it
to check status.
{code:title=java.c}
ret = (*env)->CallStaticBooleanMethod(env, cls, method, className);
if (ret == FALSE) {
log_error("An error was detected checking the %s daemon", args->clas);
return false;
}
log_debug("Daemon checked successfully");
return true;
{code}
> 9. ... You should use -errfile '&1'
Check.
Patch replaced!
Rob
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Components: Jsvc
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
> Attachments: DAEMON-153.patch
>
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
> - Added 'status' support, to ping a URL and report success if the host was reachable and replied.
> - Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DAEMON-153) [PATCH] Update/fix of Tomcat5.sh
script
Posted by "Rob Slifka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Slifka updated DAEMON-153:
------------------------------
Attachment: DAEMON-153.patch
Patch for /src/native/unix/native/Tomcat5.sh
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Components: Jsvc
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
> Attachments: DAEMON-153.patch
>
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
> - Added 'status' support, to ping a URL and report success if the host was reachable and replied.
> - Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAEMON-153) [PATCH] Update/fix of Tomcat5.sh
script
Posted by "Christopher Schultz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847877#action_12847877 ]
Christopher Schultz commented on DAEMON-153:
--------------------------------------------
Rob,
Thanks for the patch!
I would recommend the following changes:
1. Put pid file back in /var/run... it's more standard than /tmp I think
2. Remove JAVA_HOME/rt.jar from the CLASSPATH... the JVM should automatically add all the bootstrap stuff
3. Remove -debug switch from jsvc invocation
4. Make the -jvm and -wait options into script variables instead of forcing values: it's nice when all configuration can be done via variables instead of editing the script itself
5. Quote all uses of the following variables: CATALINA_HOME, CATALINA_BASE, JAVA_HOME, TMP_DIR, CLASSPATH, DAEMON, PID_FILE (basically all variables that could contain spaces and would really hose things if a space were in them)
6. I'm' disturbed by the 'chown' you've added: there's no need for the user to 'own' those files... just that they have read access to them. Also, the username may not be valid as a group name :(
7. Allow the user to specify the location of 'curl' and check to make sure it exists and is runnable before trying to run it (maybe an error message that 'curl' is not found is good enough, which the shell should do for you) else you'll get a spurious message that Tomcat isn't running if curl isn't available
8. Honestly, I think I'd remove the 'status' option entirely: though useful, it has nothing to do with jsvc. Alternatively, use the -check option on jsvc to check a running service :)
9. Does specifying -errfile as the same file as -outfile actuall work? I would expect that the file would be opened twice unless jsvc is very smary. You should use -errfile '&1' and -outfile "${CATALINA_BASE}/logs/catalina.out" instead. Write a simple servlet to write to both stderr and stdout to make sure both streams are going to the right place. If '&1' isn't working properly, log a bug for that.
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Components: Jsvc
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
> Attachments: DAEMON-153.patch
>
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
> - Added 'status' support, to ping a URL and report success if the host was reachable and replied.
> - Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAEMON-153) [PATCH] Update/fix of Tomcat5.sh
script
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860305#action_12860305 ]
Sebb commented on DAEMON-153:
-----------------------------
This does not appear to be anything to do with Commons Daemon.
It looks as though the patch is intended for Tomcat5.
Tomcat uses Bugzilla for issues, see:
https://issues.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%205
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Components: Jsvc
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
> Attachments: DAEMON-153.patch
>
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
> - Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DAEMON-153) [PATCH] Update/fix of Tomcat5.sh
script
Posted by "Rob Slifka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Slifka updated DAEMON-153:
------------------------------
Attachment: (was: DAEMON-153.patch)
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Components: Jsvc
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
> Attachments: DAEMON-153.patch
>
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
> - Added 'status' support, to ping a URL and report success if the host was reachable and replied.
> - Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DAEMON-153) [PATCH] Update/fix of Tomcat5.sh
script
Posted by "Rob Slifka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860459#action_12860459 ]
Rob Slifka commented on DAEMON-153:
-----------------------------------
Sebb, isn't this script packaged/contained in the DAEMON project?
> [PATCH] Update/fix of Tomcat5.sh script
> ---------------------------------------
>
> Key: DAEMON-153
> URL: https://issues.apache.org/jira/browse/DAEMON-153
> Project: Commons Daemon
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: Linux (tested on Fedora 8 / EC2)
> Reporter: Rob Slifka
> Attachments: DAEMON-153.patch
>
>
> A few changes:
> - Enable default Tomcat logging behaviour (logs exist and now output to $CATALINA_BASE/logs).
> - Added comments to give people a hint that further customization sourced from catalina.sh may be required.
> - Updated to currently shipping defaults of Java (1.6.0_18) and Tomcat (6.0.26).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.