You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2014/12/03 00:31:26 UTC

Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1678
    https://issues.apache.org/jira/browse/SQOOP-1678


Repository: sqoop-sqoop2


Description
-------

commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date:   Tue Dec 2 15:23:12 2014 -0800

    SQOOP-1678: Sqoop2: Configurable null values

:100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
:100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
:100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
:100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
:100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
:100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
:100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
:100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
:100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
:100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java


Diffs
-----

  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java 6e369c6 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 2586f94 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 6c57cf2 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java 352ee17 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 509d772 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java abddbfb 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java 0a6369f 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java 6eae7fd 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java 63e14ae 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java b404c34 

Diff: https://reviews.apache.org/r/28614/diff/


Testing
-------

'mvn verify' with local runner.


Thanks,

Abraham Elmahrek


Re: Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values

Posted by Venkat Ranganathan <n....@live.com>.

> On Dec. 11, 2014, 3:54 a.m., Venkat Ranganathan wrote:
> > Sorry it took some time to come up to speed on the changes.   Looks good.

Abe, there are test failures.   Have you rebased and tested this?

Tests in error:
  testSerialization(org.apache.sqoop.json.TestConnectionBean): org.apache.sqoop.model.MConnector.<init>(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lorg/apache/sqoop/model/MConnectionForms;Ljava/util/List;)V
  testSensitivityFilter(org.apache.sqoop.json.TestConnectionBean): org.apache.sqoop.model.MConnector.<init>(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lorg/apache/sqoop/model/MConnectionForms;Ljava/util/List;)V
  testSerialization(org.apache.sqoop.json.TestValidationBean): FINE
  testId(org.apache.sqoop.json.TestValidationBean): FINE
  testApplyValidation(org.apache.sqoop.model.TestFormUtils): ACCEPTABLE
  testMessage(org.apache.sqoop.validation.TestValidation): FINE
  testInitialization(org.apache.sqoop.validation.TestValidation): FINE

Tests run: 214, Failures: 0, Errors: 7, Skipped: 0


- Venkat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/#review64682
-----------------------------------------------------------


On Dec. 10, 2014, 9:37 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28614/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 9:37 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1678
>     https://issues.apache.org/jira/browse/SQOOP-1678
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date:   Tue Dec 2 15:23:12 2014 -0800
> 
>     SQOOP-1678: Sqoop2: Configurable null values
> 
> :100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
> :100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
> :100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
> :100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
> :100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
> :100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
> :100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
> :100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
> :100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
> :100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java 6e369c6 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 2586f94 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 6c57cf2 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java 352ee17 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 509d772 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java abddbfb 
>   connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3d088d0 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java f4b4454 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java 6eae7fd 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java 63e14ae 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java b404c34 
> 
> Diff: https://reviews.apache.org/r/28614/diff/
> 
> 
> Testing
> -------
> 
> 'mvn verify' with local runner.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Re: Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values

Posted by Abraham Elmahrek <ab...@cloudera.com>.

> On Dec. 11, 2014, 3:54 a.m., Venkat Ranganathan wrote:
> > Sorry it took some time to come up to speed on the changes.   Looks good.
> 
> Venkat Ranganathan wrote:
>     Abe, there are test failures.   Have you rebased and tested this?
>     
>     Tests in error:
>       testSerialization(org.apache.sqoop.json.TestConnectionBean): org.apache.sqoop.model.MConnector.<init>(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lorg/apache/sqoop/model/MConnectionForms;Ljava/util/List;)V
>       testSensitivityFilter(org.apache.sqoop.json.TestConnectionBean): org.apache.sqoop.model.MConnector.<init>(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lorg/apache/sqoop/model/MConnectionForms;Ljava/util/List;)V
>       testSerialization(org.apache.sqoop.json.TestValidationBean): FINE
>       testId(org.apache.sqoop.json.TestValidationBean): FINE
>       testApplyValidation(org.apache.sqoop.model.TestFormUtils): ACCEPTABLE
>       testMessage(org.apache.sqoop.validation.TestValidation): FINE
>       testInitialization(org.apache.sqoop.validation.TestValidation): FINE
>     
>     Tests run: 214, Failures: 0, Errors: 7, Skipped: 0
> 
> Abraham Elmahrek wrote:
>     I had tested this today. Patch is green on Jira as well... let me try to run tests real quick.

Tests are passing for me locally.

Perhaps there are some old sqoop jars in your maven cache? Not sure if that would affect things.


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/#review64682
-----------------------------------------------------------


On Dec. 10, 2014, 9:37 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28614/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 9:37 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1678
>     https://issues.apache.org/jira/browse/SQOOP-1678
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date:   Tue Dec 2 15:23:12 2014 -0800
> 
>     SQOOP-1678: Sqoop2: Configurable null values
> 
> :100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
> :100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
> :100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
> :100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
> :100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
> :100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
> :100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
> :100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
> :100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
> :100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java 6e369c6 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 2586f94 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 6c57cf2 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java 352ee17 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 509d772 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java abddbfb 
>   connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3d088d0 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java f4b4454 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java 6eae7fd 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java 63e14ae 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java b404c34 
> 
> Diff: https://reviews.apache.org/r/28614/diff/
> 
> 
> Testing
> -------
> 
> 'mvn verify' with local runner.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Re: Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values

Posted by Abraham Elmahrek <ab...@cloudera.com>.

> On Dec. 11, 2014, 3:54 a.m., Venkat Ranganathan wrote:
> > Sorry it took some time to come up to speed on the changes.   Looks good.
> 
> Venkat Ranganathan wrote:
>     Abe, there are test failures.   Have you rebased and tested this?
>     
>     Tests in error:
>       testSerialization(org.apache.sqoop.json.TestConnectionBean): org.apache.sqoop.model.MConnector.<init>(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lorg/apache/sqoop/model/MConnectionForms;Ljava/util/List;)V
>       testSensitivityFilter(org.apache.sqoop.json.TestConnectionBean): org.apache.sqoop.model.MConnector.<init>(Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lorg/apache/sqoop/model/MConnectionForms;Ljava/util/List;)V
>       testSerialization(org.apache.sqoop.json.TestValidationBean): FINE
>       testId(org.apache.sqoop.json.TestValidationBean): FINE
>       testApplyValidation(org.apache.sqoop.model.TestFormUtils): ACCEPTABLE
>       testMessage(org.apache.sqoop.validation.TestValidation): FINE
>       testInitialization(org.apache.sqoop.validation.TestValidation): FINE
>     
>     Tests run: 214, Failures: 0, Errors: 7, Skipped: 0

I had tested this today. Patch is green on Jira as well... let me try to run tests real quick.


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/#review64682
-----------------------------------------------------------


On Dec. 10, 2014, 9:37 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28614/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 9:37 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1678
>     https://issues.apache.org/jira/browse/SQOOP-1678
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date:   Tue Dec 2 15:23:12 2014 -0800
> 
>     SQOOP-1678: Sqoop2: Configurable null values
> 
> :100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
> :100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
> :100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
> :100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
> :100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
> :100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
> :100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
> :100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
> :100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
> :100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java 6e369c6 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 2586f94 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 6c57cf2 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java 352ee17 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 509d772 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java abddbfb 
>   connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3d088d0 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java f4b4454 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java 6eae7fd 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java 63e14ae 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java b404c34 
> 
> Diff: https://reviews.apache.org/r/28614/diff/
> 
> 
> Testing
> -------
> 
> 'mvn verify' with local runner.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Re: Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values

Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/#review64682
-----------------------------------------------------------

Ship it!


Sorry it took some time to come up to speed on the changes.   Looks good.

- Venkat Ranganathan


On Dec. 10, 2014, 9:37 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28614/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 9:37 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1678
>     https://issues.apache.org/jira/browse/SQOOP-1678
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date:   Tue Dec 2 15:23:12 2014 -0800
> 
>     SQOOP-1678: Sqoop2: Configurable null values
> 
> :100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
> :100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
> :100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
> :100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
> :100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
> :100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
> :100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
> :100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
> :100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
> :100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java 6e369c6 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 2586f94 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 6c57cf2 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java 352ee17 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 509d772 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java abddbfb 
>   connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3d088d0 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java f4b4454 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java 6eae7fd 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java 63e14ae 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java b404c34 
> 
> Diff: https://reviews.apache.org/r/28614/diff/
> 
> 
> Testing
> -------
> 
> 'mvn verify' with local runner.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Re: Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values

Posted by Abraham Elmahrek <ab...@cloudera.com>.

> On Dec. 11, 2014, 4:51 a.m., Venkat Ranganathan wrote:
> > Sorry Abe.  Yes, I did not do a mvn clean before.   Doing that resolved it.

Awesome! Thanks for jumping in Venkat!


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/#review64692
-----------------------------------------------------------


On Dec. 10, 2014, 9:37 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28614/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 9:37 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1678
>     https://issues.apache.org/jira/browse/SQOOP-1678
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date:   Tue Dec 2 15:23:12 2014 -0800
> 
>     SQOOP-1678: Sqoop2: Configurable null values
> 
> :100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
> :100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
> :100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
> :100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
> :100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
> :100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
> :100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
> :100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
> :100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
> :100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java 6e369c6 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 2586f94 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 6c57cf2 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java 352ee17 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 509d772 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java abddbfb 
>   connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3d088d0 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java f4b4454 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java 6eae7fd 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java 63e14ae 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java b404c34 
> 
> Diff: https://reviews.apache.org/r/28614/diff/
> 
> 
> Testing
> -------
> 
> 'mvn verify' with local runner.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Re: Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values

Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/#review64692
-----------------------------------------------------------

Ship it!


Sorry Abe.  Yes, I did not do a mvn clean before.   Doing that resolved it.

- Venkat Ranganathan


On Dec. 10, 2014, 9:37 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28614/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 9:37 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1678
>     https://issues.apache.org/jira/browse/SQOOP-1678
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date:   Tue Dec 2 15:23:12 2014 -0800
> 
>     SQOOP-1678: Sqoop2: Configurable null values
> 
> :100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
> :100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
> :100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
> :100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
> :100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
> :100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
> :100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
> :100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
> :100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
> :100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java 6e369c6 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 2586f94 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 6c57cf2 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java 352ee17 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 509d772 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java abddbfb 
>   connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3d088d0 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java f4b4454 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java 6eae7fd 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java 63e14ae 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java b404c34 
> 
> Diff: https://reviews.apache.org/r/28614/diff/
> 
> 
> Testing
> -------
> 
> 'mvn verify' with local runner.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Re: Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/
-----------------------------------------------------------

(Updated Dec. 10, 2014, 9:37 p.m.)


Review request for Sqoop.


Changes
-------

Added change from 'transformation' to 'format'


Bugs: SQOOP-1678
    https://issues.apache.org/jira/browse/SQOOP-1678


Repository: sqoop-sqoop2


Description
-------

commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date:   Tue Dec 2 15:23:12 2014 -0800

    SQOOP-1678: Sqoop2: Configurable null values

:100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
:100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
:100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
:100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
:100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
:100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
:100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
:100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
:100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
:100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java


Diffs (updated)
-----

  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java 6e369c6 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 2586f94 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 6c57cf2 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java 352ee17 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 509d772 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java abddbfb 
  connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3d088d0 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java f4b4454 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java 6eae7fd 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java 63e14ae 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java b404c34 

Diff: https://reviews.apache.org/r/28614/diff/


Testing
-------

'mvn verify' with local runner.


Thanks,

Abraham Elmahrek


Re: Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/#review64635
-----------------------------------------------------------

Ship it!


Ship It!

- Veena Basavaraj


On Dec. 10, 2014, 1:09 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28614/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 1:09 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1678
>     https://issues.apache.org/jira/browse/SQOOP-1678
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date:   Tue Dec 2 15:23:12 2014 -0800
> 
>     SQOOP-1678: Sqoop2: Configurable null values
> 
> :100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
> :100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
> :100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
> :100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
> :100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
> :100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
> :100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
> :100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
> :100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
> :100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java 6e369c6 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 2586f94 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 6c57cf2 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java 352ee17 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 509d772 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java abddbfb 
>   connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3d088d0 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java f4b4454 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java 6eae7fd 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java 63e14ae 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java b404c34 
> 
> Diff: https://reviews.apache.org/r/28614/diff/
> 
> 
> Testing
> -------
> 
> 'mvn verify' with local runner.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Re: Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/#review64636
-----------------------------------------------------------

Ship it!


Ship It!

- Veena Basavaraj


On Dec. 10, 2014, 1:09 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28614/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 1:09 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1678
>     https://issues.apache.org/jira/browse/SQOOP-1678
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date:   Tue Dec 2 15:23:12 2014 -0800
> 
>     SQOOP-1678: Sqoop2: Configurable null values
> 
> :100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
> :100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
> :100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
> :100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
> :100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
> :100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
> :100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
> :100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
> :100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
> :100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java 6e369c6 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 2586f94 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 6c57cf2 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java 352ee17 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 509d772 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java abddbfb 
>   connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3d088d0 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java f4b4454 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java 6eae7fd 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java 63e14ae 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java b404c34 
> 
> Diff: https://reviews.apache.org/r/28614/diff/
> 
> 
> Testing
> -------
> 
> 'mvn verify' with local runner.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Re: Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/#review64637
-----------------------------------------------------------

Ship it!


- Veena Basavaraj


On Dec. 10, 2014, 1:09 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28614/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 1:09 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1678
>     https://issues.apache.org/jira/browse/SQOOP-1678
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date:   Tue Dec 2 15:23:12 2014 -0800
> 
>     SQOOP-1678: Sqoop2: Configurable null values
> 
> :100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
> :100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
> :100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
> :100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
> :100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
> :100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
> :100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
> :100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
> :100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
> :100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java 6e369c6 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 2586f94 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 6c57cf2 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java 352ee17 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 509d772 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java abddbfb 
>   connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3d088d0 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java f4b4454 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java 6eae7fd 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java 63e14ae 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java b404c34 
> 
> Diff: https://reviews.apache.org/r/28614/diff/
> 
> 
> Testing
> -------
> 
> 'mvn verify' with local runner.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Re: Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/
-----------------------------------------------------------

(Updated Dec. 10, 2014, 9:09 p.m.)


Review request for Sqoop.


Bugs: SQOOP-1678
    https://issues.apache.org/jira/browse/SQOOP-1678


Repository: sqoop-sqoop2


Description
-------

commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
Author: Abraham Elmahrek <ab...@elmahrek.com>
Date:   Tue Dec 2 15:23:12 2014 -0800

    SQOOP-1678: Sqoop2: Configurable null values

:100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
:100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
:100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
:100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
:100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
:100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
:100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
:100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
:100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
:100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java


Diffs (updated)
-----

  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java 6e369c6 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 2586f94 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 6c57cf2 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java 352ee17 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 509d772 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java abddbfb 
  connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3d088d0 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java f4b4454 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java 6eae7fd 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java 63e14ae 
  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java b404c34 

Diff: https://reviews.apache.org/r/28614/diff/


Testing
-------

'mvn verify' with local runner.


Thanks,

Abraham Elmahrek


Re: Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values

Posted by Abraham Elmahrek <ab...@cloudera.com>.

> On Dec. 10, 2014, 5:57 p.m., Veena Basavaraj wrote:
> > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java, line 52
> > <https://reviews.apache.org/r/28614/diff/1/?file=780480#file780480line52>
> >
> >     modifiable probably use the ssame terminilogy as transform to keep it consistent

What about when transformations or interceptors are added between From and To? We'll have some terminology overloading? How about "hasAdditionalTransformations"?


> On Dec. 10, 2014, 5:57 p.m., Veena Basavaraj wrote:
> > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java, line 79
> > <https://reviews.apache.org/r/28614/diff/1/?file=780480#file780480line79>
> >
> >     probably at some point this can be an interface optinally implemented by conenctors. Since even JDBC needs to do this, Right now this code was added in extractor in 1830 and needs to bed added in loader as well, since we found a bug

Interested idea!


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/#review64573
-----------------------------------------------------------


On Dec. 2, 2014, 11:31 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28614/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 11:31 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1678
>     https://issues.apache.org/jira/browse/SQOOP-1678
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date:   Tue Dec 2 15:23:12 2014 -0800
> 
>     SQOOP-1678: Sqoop2: Configurable null values
> 
> :100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
> :100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
> :100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
> :100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
> :100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
> :100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
> :100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
> :100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
> :100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
> :100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java 6e369c6 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 2586f94 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 6c57cf2 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java 352ee17 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 509d772 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java abddbfb 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java 0a6369f 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java 6eae7fd 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java 63e14ae 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java b404c34 
> 
> Diff: https://reviews.apache.org/r/28614/diff/
> 
> 
> Testing
> -------
> 
> 'mvn verify' with local runner.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Re: Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Dec. 10, 2014, 9:57 a.m., Veena Basavaraj wrote:
> > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java, line 52
> > <https://reviews.apache.org/r/28614/diff/1/?file=780480#file780480line52>
> >
> >     modifiable probably use the ssame terminilogy as transform to keep it consistent
> 
> Abraham Elmahrek wrote:
>     What about when transformations or interceptors are added between From and To? We'll have some terminology overloading? How about "hasAdditionalTransformations"?

BTW the java doc says transformed...and lets not use it if transform means something else down the line
   * Given the configurations. should data received be transformed?
49	
   * @param linkConfiguration Link configuration
50	
   * @param fromJobConfiguration Job configuration
51	
   * @return boolean


all this is doing it preparing it for a custom format.

so may be hasCustomFormat or something


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/#review64573
-----------------------------------------------------------


On Dec. 10, 2014, 1:09 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28614/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2014, 1:09 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1678
>     https://issues.apache.org/jira/browse/SQOOP-1678
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date:   Tue Dec 2 15:23:12 2014 -0800
> 
>     SQOOP-1678: Sqoop2: Configurable null values
> 
> :100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
> :100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
> :100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
> :100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
> :100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
> :100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
> :100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
> :100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
> :100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
> :100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java 6e369c6 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 2586f94 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 6c57cf2 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java 352ee17 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 509d772 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java abddbfb 
>   connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 3d088d0 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java f4b4454 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java 6eae7fd 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java 63e14ae 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java b404c34 
> 
> Diff: https://reviews.apache.org/r/28614/diff/
> 
> 
> Testing
> -------
> 
> 'mvn verify' with local runner.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Re: Review Request 28614: SQOOP-1678: Sqoop2: Configurable null values

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28614/#review64573
-----------------------------------------------------------


Nice enhancement, have a few comments,


connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
<https://reviews.apache.org/r/28614/#comment107339>

    nitpick, why not pass thse into the fucntions, less state in the classes is good pattern to avoid any future multi thread issue



connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
<https://reviews.apache.org/r/28614/#comment107340>

    modifiable probably use the ssame terminilogy as transform to keep it consistent



connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
<https://reviews.apache.org/r/28614/#comment107341>

    probably at some point this can be an interface optinally implemented by conenctors. Since even JDBC needs to do this, Right now this code was added in extractor in 1830 and needs to bed added in loader as well, since we found a bug



connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
<https://reviews.apache.org/r/28614/#comment107342>

    please add more help text in the .properites



connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
<https://reviews.apache.org/r/28614/#comment107343>

    nice tests.!


- Veena Basavaraj


On Dec. 2, 2014, 3:31 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28614/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 3:31 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1678
>     https://issues.apache.org/jira/browse/SQOOP-1678
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 3898ce500f7aac0104de05e3c2c33d1c6cf7d13c
> Author: Abraham Elmahrek <ab...@elmahrek.com>
> Date:   Tue Dec 2 15:23:12 2014 -0800
> 
>     SQOOP-1678: Sqoop2: Configurable null values
> 
> :100644 100644 6e369c6... 788dfd2... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java
> :100644 100644 2586f94... d92e296... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java
> :100644 100644 6c57cf2... e7b1302... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java
> :100644 100644 352ee17... f3ac167... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java
> :100644 100644 509d772... 89ff9aa... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
> :100644 100644 abddbfb... b7a9c3d... M  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
> :100644 100644 0a6369f... 52846ed... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java
> :100644 100644 6eae7fd... ac44595... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java
> :100644 100644 63e14ae... 15e3c14... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java
> :100644 100644 b404c34... be57fa0... M  connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java 6e369c6 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsExtractor.java 2586f94 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java 6c57cf2 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsUtils.java 352ee17 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java 509d772 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java abddbfb 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestExtractor.java 0a6369f 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsBase.java 6eae7fd 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestHdfsUtils.java 63e14ae 
>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java b404c34 
> 
> Diff: https://reviews.apache.org/r/28614/diff/
> 
> 
> Testing
> -------
> 
> 'mvn verify' with local runner.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>